Classic Palindrome problem

[nanderson05]

Hi I am struggling hard in Java and I have to take it for my school etc.

I am decent with coding (I think) but here is the problem that I am having. I don't know how to call my methods that I have created within my main method. I need help calling my retrieveinput method etc. Any help would be nice, thank you :)

import javax.swing.JOptionPane;

public class PalindromeMethod {
	int num;
    int digit1;
    int digit2;
    int digit4;
    int digit5;
    int digits;
    
    int a, b, c;
    boolean palin;
    
    

	/**
	 * @param args
	 */
	public static void main(String[] args) {
		// TODO Auto-generated method stub
		
		
		String numstr =JOptionPane.showInputDialog("Enter a 5 digit number");
		
		
		
	
	}
	public int retrieveinput (String numstr)
	{
		num = Integer.parseInt(numstr);
		
		if (num > 9999 && num < 100000) {
			
		}
		else System.out.println("Please enter 5 digit number");
		
		return num;
	}
		
		public void checkPalindrome (int num){
			digits = 0;
			
			digit1=num/10000;
			a=num%10000;
			digit2=a/1000;
			b=a%1000;
			c=b%100;
			digit4=c/10;
			digit5=c%10;
			if (digit1 == digit5 && digit2 == digit4){
				palin = true;
			}
			else palin = false;
}
		public void displayPalindrome (boolean palin){
			if (palin = true){
				System.out.println(num + " is a Palindrome.");
			}
			else System.out.println(num + " is not a Palindrome.");
		}
	}

[DarrylBurke]

Forum Rules
Guide For New Members
BB Code List - Java Programming Forum

db

[wsaryada]

All non-static methods belong to an instance of the class. That means when you are trying to call retrieveInput() method or checkPalindrome() method, you have to create an instance of the class first. After you have the object you can call all the method in it. To create an instance of the class use the new keyword.

[nanderson05]

So I have to make a new palindromeMethod object? Where do I insert that?

[wsaryada]

Yes, you have to create a PalindromeMethod object and you can do it in the main() method of your class.

[nanderson05]

Main meaning:

    public static void main(String[] args) {
        // TODO Auto-generated method stub
         
         
        String numstr =JOptionPane.showInputDialog("Enter a 5 digit number");
         
         
         
     
    }

So would I do this?

    public static void main(String[] args) {
        // TODO Auto-generated method stub
         
         
        String numstr =JOptionPane.showInputDialog("Enter a 5 digit number");
         
         Palindrome PalindromeMethod = new PalindromeMethod();

         
     
    }

Does this look correct?



Still getting errors as you can see :(

[DarrylBurke]

Still getting errors as you can see :(

Yes, and the error tells you exactly what's wrong.

db

[odd123]

You need to clean up your code a bit for starters. An example is your retrieveinput method, it should be:

retrieveInput();

Also, numstr should be written like:

numStr

Be sure to capitalize those variables, you'll lose easy points that way.

I am also inclined to ask, where is the constructor for the class?

String numstr =JOptionPane.showInputDialog("Enter a 5 digit number");

Looks like you are trying to invoke a non-existent constructor which takes in a String. You probably have another class somewhere else?

[nanderson05]

No I don't have another class somewhere else, and I know that the error message is telling me whats wrong but I don't understand what it means because I am new to Java and I am struggling hard obviously.

[wsaryada]

To call an instance method you need to use the identifier followed by the dot symbol and the method name. For example if you have a class call A that has a method doIt(). You call it like:

...
A a = new A();
a.doIt();
...

[odd123]

^^thats your answer. So you'd call the method, using the instance.

palindrome.retrieveInput();

[odd123]

Your problem is that your method, retrieveInput()'s return type is int, while numStr is of type String. That is where your error is coming from.

[DarrylBurke]

Your problem is that your method, retrieveInput()'s return type is int, while numStr is of type String. That is where your error is coming from.

Wrong. Look again.

db

[Junky]

There are numerous problems in the posted code.

[DarrylBurke]

PM received from odd123

Thanks for the constructive criticism, I too am a novice at programming, as you can probably tell. Regarding the palindrome problem, would the error be due to the fact that the retrieveInput method isn't taking in a String parameter?

Please keep technical questions on the forum. Don't misuse the PM feature.

db