try/catch Help please

[Goodoleboy58]

well with or without loops you got me!

[brynpttrsn]

What do you want to happen if they input a string with all alpha as opposed to not alpha?
The way I read your code it will tell the user that whatever they input (as long as its alpha) is a valid input.

Edit: yeah thats what i thought

What you want to do is throw an error manually if its not alpha:

if(!colorcustomerReturn.matches("[a-zA-Z]*")
{
    throw new Exception();
}

But before you do anything remove the for for now... we will add loops at the end.

Might not have caught my Edit from before.

Is this what you want it to do? or no?

[Goodoleboy58]

trying to incorporate it but it keeps giving me errors.... not sure what i am missing I am trying to add that line and the other lines from your last post... ill post them again here in a sec

[brynpttrsn]

you can just kinda get rid of everything under.
throw new Exception();
}
keep the else

[Goodoleboy58]

"must be caught or declared to be thrown"

if(!colorcustomerReturn.matches("[a-zA-Z]*"))
 
 {   
     throw new Exception();
 }
 
    
 else
                    
{ 
    JOptionPane.showMessageDialog(null, "Please enter a Valid Color"); 
}

[brynpttrsn]

{} on lines 51 and 69 are not needed.
InputDialogue on line 52 also needs to go.

It should work correctly (asking only once) after that is done.

You will just have input complications if the inputDialogue stays there.

Just report back on if it works exactly how you want it to if entering different types of strings into the input.

[brynpttrsn]

InputDialogue on line 52 also needs to go.

The reason:
You dont want to ask for more input before you check what is wrong with the first input.

How the program will run with this line still there:

user enters: thesearenumbers3243158493538
Program outputs: "thats not right"
User enters: Blue
Program outputs: "Good job"

Catch is never reached.


We only want it to ask once at the moment.

[Goodoleboy58]

Gotcha, input removed, I guess we can incorporate that second inquiry during the loop ehhh... that works good now the way it is laid out

[brynpttrsn]

Great! We're really close now.

Move all your variable declarations so they're all together at the top of your main method and remove the following variables:

colorreturnInputMsg, colorInputMsg, customerColor1, color, customerColor2

They are not needed.

so this means all your booleans and ints need to me moved also.
And I think you missed a few that need to be removed from my quote.
Remove any lines these variables have to do with.

Also, what is valueString for?

(I appologise, but I edit my posts a lot as questions and comments are thought of so you might miss something I've said if you don't reload it after my edits.)

[Goodoleboy58]

No problem, got booleans and ints lumped together at the top. Deleted valueString, something I was trying to tinker with. Should be good to go on variable placement.

[brynpttrsn]

These lines:

colorcustomerReturn = JOptionPane.showInputDialog( null, "Please select a color Blue, Black, Green, or Gold" ); 
            colorinvalidEntry = "We do not have that color. Please select a Valid Color";
            colorvalidEntry = "That is a Valid color";

need to be moved below your booleans and int declaration.

Edit:
Somehow missed your posted code. Just noticed that you did this already... sweet.

[Goodoleboy58]

got it, sorry had edited the previous post.... caught it right after i reposted it

[brynpttrsn]

Ok so now you should be able to just pop in a for loop on line 10 (ending on line 69). And that might be it.... maybe.
(You might some more specific error handling in your catch to edit up to do exactly what you want.)

[brynpttrsn]

Yes... one last thing.

In the for loop your condition is:
i <= 3

We add another condition to make the loop exit when the user enters a correct color like so:

for (int i=1; i <= 3 && returnFlag == 2; i++)

You might get a initialization error while compiling.
To fix that replace

int returnFlag;

with

int returnFlag = 2;

(You have to do that anyway so that the for loop executes)

[brynpttrsn]

I've also realized that the comments in your code seem misleading.
When you define a variable, that means this:

int foo;
boolean boolStuff;

Initializing means this:

a = 0;
boolStuff = true;

reading your last post now...

Edit:
Where are your {} for your for loop?

[Goodoleboy58]

tracking corrected

[brynpttrsn]

{} needed for the for loop if you missed my edit.
Edit:
or the { is on the wrong line for the for?
should be on line 12 and 73.

[Goodoleboy58]

corrected the {} also, sorry you blew my mind like 3 hours ago, im trying to keep up!

Still getting the same first question asked to me 3 times...

edited code should reflelct {}

[brynpttrsn]

{            for (int i=1; i <= 3 && returnFlag == 2; i++)  
               
            //initialize color input

Should look like:

 
for (int i=1; i <= 3 && returnFlag == 2; i++)  
{ 
            //initialize color input

[Goodoleboy58]

Ill attribute that mistake to lack of sleep! Thanks man that did it... fully functional!