Compare different size arrays

[Jasper]

Hello,

I have this issue. I want to compare different size arrays to check my data i got from a serial line. I've got it working but i doesn't feel like the right way to do it. Here is my code :

public void CheckData(byte[] buffer, int length) {
   byte [] KeepAlive = new byte[1024];
   KeepAlive[0] = 0x31; 
   KeepAlive[1] = 0x05;
   KeepAlive[2] = 0x32;
   KeepAlive[3] = 0x05;
   byte [] ACK = new byte [1024];
   ACK[0] = 0x06;
   if (Arrays.equals(buffer, KeepAlive)) {
      try {
      outputStream.write(ACK);
      } catch (IOException ex) {}
   }
}

So basicly, i call the method CheckData with a buffer of 1024 bytes (can't be changed). Now i want to compare the first 4 bytes of this buffer with a 4-byte KeepAlive sequence. If equal, then send back ACK.

The above example does work, but a more professional approach would be welcome :)

Thanks in advance!

[Norm]

What do you want the results of the compare to be if the arrays are different sizes? What does the Arrays equals() method do when the arrays are different sizes?

You could use a for loop and compare each element of the two arrays.

[Tolls]

I'm amazed the above works, because the keepAlive array has 1020 entries that are all 0 so, unless the given buffer also only has 0 in the end 1020 bytes it will never give true.

If you want to compare just the first 4 bytes then keepAlive should be byte[4] and the call would be equals(Arrays.copyOf(buffer, 4), keepAlive).
Also I would suggest turning keepAlive into a static final class constant, KEEP_ALIVE.

[Jasper]

@ Tolls

Indeed, when the keep alive package is send. The complete buffer has all 0 in the last 1020 bytes. If not, something is wrong. But as I said, this code works.

Now, I altered my code and used the copyOf method and still got succes. This feels like nicer way to do it. Thanks!
Also thanks for the tip for using final class constants.