JMenuItem query

[delion19]

Hi all,

I am relatively new to Java and the forum here. Was wondering if I could get some help with a problem I've been working on for the past few hours. Here's the general idea.

1. I have 1 main Jframe with an Jpanel that contains many different buttons.
2. When a button is clicked, a new JDialog is opened using actionPerformed with Jtextareas for input. The dialog also includes a menubar - file and help.
3. from the dropdown file menu, 3 options (MenuItems) can be selected; save, save & exit or cancel.

The problem that I am having is with the response when one of these menuitems are selected. I want to be able to execute a particular portion of code on click of that menu item, but have been unable to get a proper response thus far.


I should also include that the code for these responses has been placed in the same area as the ones for the button clicks.

A snippet is shown below.

frame creation

JFrame myFrame = new JFrame();
        JDesktopPane desktop = new JDesktopPane();
        JMenuBar menubar = new JMenuBar();
        JMenu menu = new JMenu("File"), menu1 = new JMenu("View"), menu2 = new JMenu("Edit"), submenu;JMenuItem submenu1, submenu2, submenu3;
        menu.setMnemonic(KeyEvent.VK_F);
        menu.getAccessibleContext().setAccessibleDescription("The first Menu with Items");
        menubar.add(menu);menubar.add(menu1);

internal frame and panel creation as well as a few buttons

JInternalFrame internalFrame = new JInternalFrame("Welcome to the "
                + "Car Dealership Application",true,true,true,true);
        JPanel panel = new JPanel(new FlowLayout());
        myFrame.setSize (framewidth, framelength);
        internalFrame.setSize(framewidth-3, framelength-10);
        myFrame.setVisible(true);
        internalFrame.setVisible(true);
        myFrame.setTitle ("Dealership Application");
        myFrame.setLocation (framelocationx, framelocationy);
        myFrame.setDefaultCloseOperation(myFrame.EXIT_ON_CLOSE);
        myFrame.getContentPane().add(panel);
        myFrame.getContentPane().add(desktop);
        
        desktop.add(internalFrame);

        JLabel windowLabel = new JLabel ("Please Click on the button the "
                + "corresponds to the action that you wish to perform");
        internalFrame.add(panel);
        panel.add(windowLabel);
        JButton addNewCar = new JButton ("Add New Car");
        panel.add(addNewCar);
        addNewCar.addActionListener(this);

Portion of actionPerformed Method

public void actionPerformed (ActionEvent e) 
    {
        JButton clickedButton = (JButton) e.getSource();
        //JMenuItem clickedmenuitem = (JMenuItem) e.getSource();
        if(clickedButton.getText().equals("Add New Car"))
        {
           // JOptionPane.showMessageDialog(null, "You are about to add a new Car");
            
            //JPanel panel = new JPanel(new FlowLayout());
            JMenuBar menubar = new JMenuBar();
            JMenu menu = new JMenu("Help"), menu1 = new JMenu("File"), menu2 = new JMenu("Edit"), submenu;JMenuItem submenu1, submenu2, submenu3;
            menubar.add(menu1);menubar.add(menu);            
            menu.addSeparator();
        submenu = new JMenu("Add");
        submenu.setMnemonic(KeyEvent.VK_A);
        
        JMenuItem menuitem = new JMenuItem("New Car",KeyEvent.VK_N);
        menuitem.setAccelerator(KeyStroke.getKeyStroke(
        KeyEvent.VK_N, ActionEvent.ALT_MASK));
        submenu.add(menuitem);
        menuitem = new JMenuItem("Used Car",KeyEvent.VK_U);
        menuitem.setAccelerator(KeyStroke.getKeyStroke(
        KeyEvent.VK_U, ActionEvent.ALT_MASK));
        submenu.add(menuitem);
        menuitem = new JMenuItem("Car Model",KeyEvent.VK_M);
        menuitem.setAccelerator(KeyStroke.getKeyStroke(
        KeyEvent.VK_M, ActionEvent.ALT_MASK));
        submenu.add(menuitem);
        
        menu1.addSeparator();
        submenu1 = new JMenuItem("Save",KeyEvent.VK_S);
        submenu1.setAccelerator(KeyStroke.getKeyStroke(
        KeyEvent.VK_S, ActionEvent.ALT_MASK));
        submenu2 = new JMenuItem("Save & Exit",KeyEvent.VK_E);
        submenu2.setAccelerator(KeyStroke.getKeyStroke(
        KeyEvent.VK_E, ActionEvent.ALT_MASK));
        submenu3 = new JMenuItem("Cancel",KeyEvent.VK_A);
        submenu3.setAccelerator(KeyStroke.getKeyStroke(
        KeyEvent.VK_A, ActionEvent.ALT_MASK));
        
        
        menu1.add(submenu1);
        menu1.add(submenu2);
        menu1.add(submenu3);
        menu.add(submenu); 

JDialog pane = new JDialog();
            pane.setTitle("New Car Menu");
            pane.setSize(framewidth, framelength);
            pane.setLayout(new FlowLayout());
            pane.setModal(true);
            
            JTextField VINtext = new JTextField(VIN,45);
            JTextField colortext = new JTextField(color,45);
            JTextField pricetext = new JTextField(price,45);
            JTextField maketext = new JTextField(make,45);
            JTextField modeltext = new JTextField(model,45);
            JTextField yeartext = new JTextField(yea,45);
            
            JLabel windowLabel = new JLabel ("Please enter the required  "
                + "information then click <save> or click <cancel> to exit"
                    + " without saving.");
            
            pane.add(windowLabel);

last 2 line should be executed on menuitem click

pane.setJMenuBar(menubar);    
            pane.setVisible(true);
            

                if (e.getSource().equals(submenu1)){
                    
            JOptionPane.showMessageDialog(null, "Your info is saved");}

FYI, I have tried using dotnotation to define a new actionlistener

submenu1.addActionListener(new ActionListener(){
                public void ActionPerformed (ActionEvent ae){System.out.println("working");}

                @Override
                public void actionPerformed(ActionEvent ae) {
                    throw new UnsupportedOperationException("Not supported yet.");
                }
            });

I get no response on click

Please let me know if I should include any additional code. thanks

[JosAH]

I normally prefer one ActionListener per JMenuItem; the particular ActionListener immediately knows what to do: one of load a file, save a file, exit etc. I don't see that in your code.

kind regards,

Jos

[delion19]

I normally prefer one ActionListener per JMenuItem; the particular ActionListener immediately knows what to do: one of load a file, save a file, exit etc.

Thanks Jos, implemented it in that format and now I have the workable responses - one per JMenuItem. Still working out the kinks to get it right though.

Thanks