Arrays

[sugst893]

Ok so I am reading in a csv file to an array, but keep getting a out of bounds error (I know what this means) but cant work out why it is happening in my fields array.

 public static void main(String[] args) {
                 BufferedReader in;
		

		String line;
                 
		Statment[] Transactions = new Statment[127];
		try	{
			in = new BufferedReader(new FileReader("pays.csv"));
                       int i=0;
			while ((line = in.readLine())!= null)
                        {
                        String[] fields = line.split(",");
			 
                         String date= fields[0];
                         String gross= fields[1];
                         String tax =fields[2];
                         String net =fields[3];// line 34
                         
                          
                         Transactions[i]= new Statment(date,gross,tax,net); 
			i++;	
			}
			
		}	
		catch (IOException e){
			System.out.println("There was a problem with the file");}

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 3
	at pbankanalysis.BankAnalysisApp.main(BankAnalysisApp.java:34)

[Fubarable]

Understand that you're walking a dangerous line when you use "magic numbers" to access your array as you're doing.

What happens if you put println statement in the code to test what the fields array actually holds before you start assigning its component parts off.

[sugst893]

Thanks for that I found the error it wasn't in my code as such it was my file it had blanks and my code wasn't handling null values. can you explain what you mean by magic numbers.

Stephen

[Fubarable]

Thanks for that I found the error it wasn't in my code as such it was my file it had blanks and my code wasn't handling null values. can you explain what you mean by magic numbers.

You are accessing the array using hard-coded numbers (the magic numbers) rather than a variable in a for loop that will only loop to the maximum of the array.