Help with If/Else not working correctly?

[kalaiss]

Good morning, thanks for having a look at this.

Basically when I enter my nextBoolean value as true, the code works as intended. But when I enter a false value, the if(firstbat==false) won't work. I've also tried using an else statement but still no go.

heres the code and thanks very much

			if(firstbat==true)
				{
				System.out.println(""+ namep1 + " is batting first.");
				System.out.println("How many innings should be played, 1 or 2?");
				noInnings=sc.nextInt(3);
				System.out.println("You have chosen to play " + noInnings + " innings.");
				System.out.println("Player 1, " + namep1 +", is up to bat! This is his first innings");
				
				rngTool = generator.nextInt(11); // vehicle type 9 parts car 1 part vehicle
				if(rngTool>9)
					{
						rngTool= generator.nextInt(4);
						switch(rngTool)
							{
								case 0:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is an SUV, the colour is Red. 6 runs are added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is an SUV, the colour is not Red. 1 run is added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 1;
										break;
									}
								break;
						
								case 1:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is a Van, the colour is Red. 6 runs are added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is a Van, the colour is not Red. 1 run is added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 1;
										break;
									}
								break;
						
								case 2:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is a Truck, the colour is Red. 6 runs are added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is a Truck, the colour is not Red. 1 run is added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 1;
										break;
									}
								break;
							
								case 3:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is a Bus, the colour is Red. 6 runs are added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is a Bus, the colour is not Red. 1 run is added to "+namep1+"'s innings total.");
										scoreP1I1 = scoreP1I1 + 1;
										break;
									}
								break;
							}
				System.out.println("score is "+scoreP1I1+".");
					}
				
			else
				{
				System.out.println(""+ namep2 + " is batting first.");
				System.out.println("How many innings should be played, 1 or 2?");
				noInnings=sc.nextInt(3);
				System.out.println("You have chosen to play " + noInnings + " innings.");
				System.out.println("Player 2, " + namep2 +", is up to bat! This is his first innings");
				
				rngTool = generator.nextInt(11); // vehicle type 9 parts car 1 part vehicle
				if(rngTool>9)
								{
						rngTool= generator.nextInt(4);
						switch(rngTool)
							{
								case 0:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is an SUV, the colour is Red. 6 runs are added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is an SUV, the colour is not Red. 1 run is added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 1;
										break;
									}
								break;
						
								case 1:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is a Van, the colour is Red. 6 runs are added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is a Van, the colour is not Red. 1 run is added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 1;
										break;
									}
								break;
						
								case 2:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is a Truck, the colour is Red. 6 runs are added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is a Truck, the colour is not Red. 1 run is added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 1;
										break;
									}
								break;
							
								case 3:
								rngTool = generator.nextInt(13);
								switch(rngTool)
									{
										case 0:
										System.out.println("The vehicle is a Bus, the colour is Red. 6 runs are added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 6;
										break;
								
										default:
										System.out.println("The vehicle is a Bus, the colour is not Red. 1 run is added to "+namep2+"'s innings total.");
										scoreP2I1 = scoreP2I1 + 1;
										break;
									}
								break;
							}
				System.out.println("score is "+scoreP2I1+".");
					}

thank you in advance

[Fubarable]

That's a lot of code that you're asking us to go through -- can you post a response below that pares the code down to the necessary essentials? Also please use [code] [/code] tags so that it remains formatted. Finally, there's no need to do

if (foo == true) {

} else if (bar == false) {

}

As it's much simpler and cleaner to just do:

if (foo) {

} else if (!bar) {

}

[shall]

I don't see any nextBoolean or if (firstbat == false) in the code. Also, what do you mean by it won't work?

[pbrockway2]

Hi kalaiss, welcome to the forums!

A couple of things that may help you get speedier help: first use the "code" tags when you post code. Put [code] at the start of the code and [/code] at the end. That way formatting gets preserved. Of course, to be effective in making your code readable indents should be kept to a moderate size: I would suggest 4 spaces (and no tabs) per indent level.

Secondly, people reading the post will have no idea what "won't work", "no go" and similar mean. You ought to describe both the intended behaviour and the behaviour you observe when the program is run. Likewise an expression like "when I enter my nextBoolean value as true" suggests that there is a nextBoolean variable involved, but it does not occur in the posted code snippet. And, in the absence of code, we can only guess what it means to enter a variable's value.

Consider reposting with code that is complete - ie others can compile and run it. Keep it short. There's a huge switch statement in there: if it's not part of the problem, remove it. Basically it would help if you were to construct a small program that illustrates the problem you are having, and accompany it with a description of what that problem is (intended vs actual runtime behaviour).

[kalaiss]

Thanks everyone for the advice

I did try that exact if statement by the way with the same result.

That result (not working) was when I input my nextBoolean value, if I put in true, the code continued to play a lovely game of car cricket. If I entered a false value, rather than continuing with the code under if(firstbat==false), it would simply say "Process Completed" and end the program.

Using jcreator pro if that helps

Cheers again

[shall]

I'm not familiar with jcreator pro or your skills with the IDE. Are you debugging the program using breakpoints?

[kalaiss]

I'm not familiar with jcreator pro or your skills with the IDE. Are you debugging the program using breakpoints?

there are no break points as such, just incorrect output, and my skills are limited :p

one other issue im having that is probably alot easier to solve is the following

					switch(noInnings)
						{
							case scoreP1T == scoreP2T:
							System.out.println("The players scores are equal! The game is a draw.");
							break;
							
							case scoreP1T > scoreP2T:
							System.out.println(""+namep1+" scored more runs than "+namep2+". Player 1 is the winner!.");
							break;
							
							case scoreP2T > scoreP1T:
							System.out.println(""+namep2+" scored more runs than "+namep1+". Player 2 is the winner!.");
							break;
						}
				}

bugs saying that im using booleans instead of int's but ive checked by instantiations and they all seem correct.

Any ideas?

[shall]

I seriously suggest you use Netbeans (http://netbeans.org/downloads/) - select the "All" column. I only have part of program, so I'm not able to test it.

[pbrockway2]

If you can't understand a compiler message, post it and say to which line(s) of your code it is referring.