Stack not popping

[bugger]

The code below should pop 4 elements, but it just shows 2 elements. I am not able to understand the prolem there:

Code:

		Stack stack = new Stack();
		stack.push("Obj1");
		stack.push("Obj2");
		stack.push("Obj3");
		stack.push("Obj4");
		
		System.out.println(stack.size());
		
		for(int i=0;i<stack.size();i++)
		{
			System.out.println("Stack header is: " + stack.peek());
			System.out.println("Popped value is: " + stack.pop());
		}

Output:

Code:

Stack header is: Obj4
Popped value is: Obj4
Stack header is: Obj3
Popped value is: Obj3

[jelly]

Your problem is caused by

Code:

for(int i=0;i<stack.size();i++)

you are getting the size of the stack each time round but your index is increasing in value while the stack size is decreasing so:

loop 1, i = 0, stack.size() = 4, you print values
loop 2, i = 1, stack.size() = 3, you print values
loop 3, i = 2, stack.size() = 2, and you drop out of the loop

take the original stack size first and then use that for the loop check, i.e.

Code:

int original_stack_size = stack.size();
for(int i=0; i< original_stack_size; i++)

as well as fixing the problem it is also more efficient

[bugger]

Thanks jelly. That explains.