adding keylistener to JFrame

[Alkor]

Ok im making a basic game here is my code:

package City;

import java.awt.event.*;
import javax.swing.*;

public class City implements KeyListener{
    
        Player p = new Player();
        Map map = new Map();
        
    public static void main(String[] args){

        JFrame GameFrame = new JFrame("City");
        GameFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        GameFrame.setSize(800,600);
        GameFrame.setVisible(true);
        GameFrame.setResizable(false);
        GameFrame.addKeyListener(this);
    }
    
    public void MenuOn(){
        
        
        
    }

    public void MenuOff(){
        
    }

    @Override
    public void keyTyped(KeyEvent e) {
        switch (e.getKeyCode()) {
                case KeyEvent.VK_LEFT:
                p.moveLeft();
                    break;
                case KeyEvent.VK_RIGHT:
                p.moveRight();
                    break;
                case KeyEvent.VK_UP:
                p.moveUp();
                    break;
                case KeyEvent.VK_DOWN:
                p.moveDown();
                    break;       
                }
        }

    @Override
    public void keyPressed(KeyEvent e) {
        
    }

    @Override
    public void keyReleased(KeyEvent e) {
        
    }
    
}

I'm a error by GameFrame.addKeyListener(this); non-static variable, well im not using a variable...any ideas?

[DarrylBurke]

1. Learn to follow coding conventions so your code isn't confusing to other programmers: Code Conventions for the Java Programming Language: Contents

2. You're referring to "this" which is a reference to the current instance of the class, from a static method that isn't tuied to any particular instance. If you don't understand that, take a step back and learn the fundamentals of Java before progressing to GUIs.

3. Adding a KeyListener to a JFrame isn't going to get you anywhere, since a JFrame is completely covered by its rootPane, which in turn has children. KeyEvents are only delivered to the component that has the focus.

4. Swing components are designed to use key bindings. Once you understand the basics, search for the Oracle tutorial on How to Use Key Bindings and follow that route.

Since the primary issue here is that a non-static member cannot be accessed from a static method, I'm retaining this in New to Java. If and when you reach a stage that you have a genuine AWT/Swing problem, please post in the appropriate section of the forum.

db

[Alkor]

Sorry i wasnt thinking much i moved jframe to a new method and called that method and keylistener now works and i also added a pane.
Thanks for your help

[DarrylBurke]

4. Swing components are designed to use key bindings. Once you understand the basics, search for the Oracle tutorial on How to Use Key Bindings and follow that route.

Sorry i wasnt thinking much i moved jframe to a new method and called that method and keylistener now works and i also added a pane.

So, you prefer to do things the wrong way. I'll try to remember that the next time you need help.

db