Socket help

[jobud9]

When I try to connect to the socket with my browser it says it can't connect, and I don't get any errors.
I am starting my thread, that's just in another file.
code:

package jo.hn;

import java.io.BufferedReader;
import java.io.DataOutputStream;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.ServerSocket;
import java.net.Socket;

public class httpd implements Runnable{
	Thread t1 = new Thread(new server());
	private boolean ShouldRun = true;
	int port = 5152;
	public void run(){
		System.out.println("running!");
		while(ShouldRun){
			System.out.println("making thread");
			t1.start();
		}
	}
	private class server implements Runnable{
		public void run() {
			try{
				System.out.println("thread made!");
				ServerSocket Server = new ServerSocket(port);
				Socket sock = Server.accept();
				BufferedReader input = new BufferedReader(new InputStreamReader(sock.getInputStream()));
				DataOutputStream output = new DataOutputStream(sock.getOutputStream());
				Serve(input,output);
			}
			catch(IOException e){
				e.printStackTrace();
				ShouldRun = false;
			}
			catch(Exception e){
				e.printStackTrace();
			}
		}
		private void Serve(BufferedReader in,DataOutputStream out){
			try {
				String tmp = in.readLine();
				String tmp2 = new String(tmp);
				tmp.toUpperCase();
				int start = 0;
				int end = 0;
				for (int a = 0; a < tmp2.length(); a++) {
					if (tmp2.charAt(a) == ' ' && start != 0) {
						end = a;
						break;
					}
					if (tmp2.charAt(a) == ' ' && start == 0) {
						start = a;
					}
				}
				tmp2.substring(start + 2, end);
				
				System.out.println("printing!");

				String s = "HTTP/1.0 ";
				s = s + "200 OK";
				s = s + "\r\n";
				s = s + "Connection: close\r\n";
				s = s + "Content-Type: Text/html\r\n";
				s = s + "\r\n";
				s = s + "<b>hello!</b>";

				out.writeChars(s);
			}
			catch (Exception e) {
				e.printStackTrace();
			}
		}
	}
}

[Norm]

What URL are you entering into the browser?

[jobud9]

http://localhost:5152/

[Norm]

You need to debug your code to see where and when it is executing. Add printlns in all the methods so you know when they start and when the code exits. Also print out the values of all the variables whose values change. For example: tmp.

Make sure all the catch blocks call printStackTrace()

[jobud9]

I am still not getting any errors. is there anything wrong with my threading?

[Norm]

What was printed out when you added the printlns to your code?

[jobud9]

in the loop, it sends out messages, but not inside the server class.

[Norm]

How is the code in the server class called? I don't see a constructor.

[jobud9]

the server class is on line 16

[Norm]

I see the class definition, but I do not see where any of its methods are being called.
It does not have a constructor which would be one place where you could have calls to the other methods in the class.

[jobud9]

how should I call it? I need to run it every time the loop is called.. just construct it and add server.start() into the loop?

[jobud9]

apparently now. I'm just getting a Illegal thread state error..

[Norm]

I'm just getting a Illegal thread state error..

Where? I don't see any Thread classes in your code.

how should I call it

You are calling the constructor with this:
new server();
It calls the default constructor which doesn't do much. If you want the constructor to do something you need to code one.

[jobud9]

sorry. iv'e updated my code to show you what I have now. you can see where i'm getting my illegal thread state error

[Norm]

You can only start a Thread once. How many times are you trying to start the thread in the loop?
Why do you want to start so many threads?
try getting rid of the loop

[jobud9]

I need the loop to see when someone connects to the socket and create a unique thread to serve the client. each client needs their own thread so no client has to wait for a response.

[Norm]

For testing remove the thread and see if ONE client can connect.
WHEN you can get one client to connect and work the way you want,
THEN worry about more than one client connecting.

The way you allow more than one client is to create a thread when the accept() method returns with a new socket.
Use the new thread to handle the connection with that socket and then loop back to the accept statement where the code will wait until the next client connects.
You use ONE ServerSocket for all the clients to connect to.

I'm done for tonight.

[jobud9]

you see! this is proof that i'm just rubbish at Java:
my life as a Java developer.. - YouTube

[Norm]

Its useful to design your program before writing it.
Write a simple version first before trying to make the complicated one.
Learn to walk before trying to run.