Out of Bound Exception Error

[Calaminh]

CodingBat Java Array-1 unlucky1

My code:

public boolean unlucky1(int[] nums) {

for(int i =0; i<nums.length; i++)
{
    if (nums.length <= 1)
    {
        return false;
    }
    
 if((nums[0] == 1 && nums[1] == 3) || (nums[1] == 1 && nums[2] == 3))
 {
  return true;
 }
 
 if((nums[nums.length-1] == 1 && nums[nums.length] == 3) ||(nums[nums.length-2] == 1 && nums[nums.length-1] == 3))
 {
  return true;
 }
 
}

return false;
  
}

What do I do to fix this?

[HowardHyde]

Array indexes in Java are zero-based. For example if your array has 4 elements in it, they are numbered 0, 1, 2, and 3, NOT 1, 2, 3, 4.
The expression nums[nums.length] effectively attempts to refer to an element that is one greater than the highest-numbered element. Hence the ArrayIndexOutOfBoundsException. Use nums[nums.length-1] to get the last element in your array.

Shameless plug: Moderator edit: removed

[DarrylBurke]

Howard, there's a separate section of these forums for Reviews/Advertising. Please limit any shameless plugs to that area.

db

[HowardHyde]

Darryl,
Thanks for pointing that out. I have posted there.
The next time that I spend 2 minutes (or as occasionally happens, 2 hours) researching and answering someone's specific forum question, is it OK if I sign my reply 'Howard Hyde, author, Java Web Database Application Development at JavaWebDB.com'?

[Calaminh]

Array indexes in Java are zero-based. For example if your array has 4 elements in it, they are numbered 0, 1, 2, and 3, NOT 1, 2, 3, 4.
The expression nums[nums.length] effectively attempts to refer to an element that is one greater than the highest-numbered element. Hence the ArrayIndexOutOfBoundsException. Use nums[nums.length-1] to get the last element in your array.

Shameless plug: Moderator edit: removed

Um, I did start off the array using 0, and I did use nums[nums.length-1] ...?

[JosAH]

Um, I did start off the array using 0, and I did use nums[nums.length-1] ...?

Ahem:

nums[nums.length] == 3

kind regards,

Jos

[Calaminh]

Ahem:

nums[nums.length] == 3

kind regards,

Jos

Oh, thanks for the catch.