Double ItemEvents sent by JComboBox

[fatabass]

Hi.

Here is the code:

import java.awt.FlowLayout;
import java.awt.event.ItemEvent;
import java.awt.event.ItemListener;
import javax.swing.JComboBox;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JOptionPane;

public class MyComboBoxClass extends JFrame
{
	private JComboBox myJComboBox;	
	private JLabel myJLabel;
	
	private static final String[] names = 
		{"","Simpons", "Beavies & Butthead", "South Park", "Ninja Turtles",
		"Gone With The Wind", "Dilbert"};
	
	public MyComboBoxClass()
	{
		super( "Which is not a cartoon? ");
		setLayout( new FlowLayout() );
		
		myJLabel = new JLabel( "Which is not a cartoon? ");
		this.add(myJLabel);
		
		myJComboBox = new JComboBox();
		myJComboBox.setMaximumRowCount(4);

		for(int i = 0; i<names.length;i++)
		{
			String tobeadded = (names[i]);
			myJComboBox.addItem(tobeadded);
		}
		myJComboBox.addItemListener(new Listener());
		this.add(myJComboBox);
		
	}// end MyComboBoxClass constructor
	
	public class Listener implements ItemListener
	{
		public void itemStateChanged(ItemEvent e) 
		{
			//System.out.println("Get Item: " + e.getItem());
			//System.out.println("Get State Change: " + e.getStateChange());
			
			if(e.getItem().equals("Gone With The Wind") && e.getStateChange() == 1)
			{
				System.out.println("Congrats!");
				JOptionPane.showMessageDialog(null,"Congrats");
			}
			
			else
			{
				System.out.println("Try Again!");
				JOptionPane.showMessageDialog(null,"Try again!");
			}
		}//end method itemStateChanged( ItemEvent e )
	}// end class Listener implements ItemListener
}//end class MyComboBoxClass extends JFrame

I have a TestClass that drives this one just fine, no problems there..

My question is:

Basically when I pick Simpons from the Combobox: Two JOptionPanes are seen saying Try again!
When I pick Gone With The Wind, I first get a "Try Again" JOptionPane, and then a "Congrats!" one.

So obviously the ItemEvents are sent to my listener, one for the option that is being UNSELECTED, and one for the one that is SELECTED.
But I do not care about the UNSELECTED one, I only care about the SELECTED one.

Any help?

[fatabass]

public class Listener implements ItemListener
	{
		public void itemStateChanged(ItemEvent e) 
		{
			System.out.println("Get Item: " + e.getItem());
			System.out.println("Get State Change: " + e.getStateChange());
			
			if(e.getStateChange()!=1)
			{
				
			}
			else
			{
				if(e.getItem().equals("Gone With The Wind") && e.getStateChange() == 1)
				{
					//System.out.println("Congrats!");
					JOptionPane.showMessageDialog(null,"Congrats");
				}
				
				else
				{
					//System.out.println("Try Again!");
					JOptionPane.showMessageDialog(null,"Try again!");
				}
			}
			

		}//end method itemStateChanged( ItemEvent e )
	}// end class Listener implements ItemListener
}//end class MyComboBoxClass extends JFrame

Hi Myself;

You have just modified your code, and the problem is solved.
Congrats!

:)

( I came up with the solution after 4 seconds I asked it. )

Thank you, myself.

[JosAH]

Use the symbolic version ItemEvent.SELECTED instead of the magic value '1'.

kind regards,

Jos

[fatabass]

Right, thanks.
Useful tip.