How to set button to be pressed more than once

[ajs1351]

i have a button , that will do an action. it will do it once, but it wont do it again when i press it again. how do i get the button to repeat the action again, until it has fullfilled the requirements.

import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;



public class CountingConstant extends JFrame  {

          JFrame MFrame;
         
          
          
    
    
    
       CountingConstant()
       {
           
           final JLabel[] labels = new JLabel[10];
           MFrame = new JFrame("Pirate Constant Counting");
           MFrame.setDefaultCloseOperation(EXIT_ON_CLOSE);
           MFrame.setSize(500,500);
           MFrame.pack();
           MFrame.setVisible(true);
           
          
           MFrame.setLayout(new GridLayout(10,1));
           
           labels[0] = new JLabel("0");
           labels[1] = new JLabel("1");
           labels[2] = new JLabel("2");
           labels[3] = new JLabel("3");
           labels[4] = new JLabel("5");
           labels[5] = new JLabel("4");
           labels[6] = new JLabel("7");
           labels[7] = new JLabel("6");
           labels[8] = new JLabel("9");
           labels[9] = new JLabel("8");
           
           for(int i = 0 ; i < labels.length; i++)
           {
           MFrame.add(labels[i]);
           }
           
           JButton button = new JButton("Begin");
           
           button.addActionListener(new ActionListener()
                   {
            @Override
                    public void actionPerformed(ActionEvent e) 
                    {
				
	           int ii = 7;
                   int changableLength = labels.length;
       
          for(int i = 0; i < changableLength; i++)
          {
        
       int iii = (ii + (110-1) ) % changableLength;
    
   
          labels[iii].setText("");
         
         }

                   }});
           MFrame.add(button);
       }
    
    
    public static void main(String[] args) {
        
        
        new CountingConstant();
        
    }
}

[Fubarable]

i have a button , that will do an action. it will do it once, but it wont do it again when i press it again. how do i get the button to repeat the action again, until it has fullfilled the requirements.

But your button does do its action again when the button is pressed -- it sets the same JLabel's text to "". It just so happens that after the button has been pressed once, this label already has no text display, but the button's action listener doesn't care. Perhaps you wish to explain what behavior you're trying to elicit that the button's listener isn't performing? Perhaps you wish to remove a label from the gui and from the array? perhaps you wish to change the value of the variable that currently never changes named "changableLength"? Who knows?

Also sorry to be blunt, but this code has awful indentation and formatting:

import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;



public class CountingConstant extends JFrame  {

          JFrame MFrame;
         
          
          
    
    
    
       CountingConstant()
       {
           
           final JLabel[] labels = new JLabel[10];
           MFrame = new JFrame("Pirate Constant Counting");
           MFrame.setDefaultCloseOperation(EXIT_ON_CLOSE);
           MFrame.setSize(500,500);
           MFrame.pack();
           MFrame.setVisible(true);
           
          
           MFrame.setLayout(new GridLayout(10,1));
           
           labels[0] = new JLabel("0");
           labels[1] = new JLabel("1");
           labels[2] = new JLabel("2");
           labels[3] = new JLabel("3");
           labels[4] = new JLabel("5");
           labels[5] = new JLabel("4");
           labels[6] = new JLabel("7");
           labels[7] = new JLabel("6");
           labels[8] = new JLabel("9");
           labels[9] = new JLabel("8");
           
           for(int i = 0 ; i < labels.length; i++)
           {
           MFrame.add(labels[i]);
           }
           
           JButton button = new JButton("Begin");
           
           button.addActionListener(new ActionListener()
                   {
            @Override
                    public void actionPerformed(ActionEvent e) 
                    {
				
	           int ii = 7;
                   int changableLength = labels.length;
       
          for(int i = 0; i < changableLength; i++)
          {
        
       int iii = (ii + (110-1) ) % changableLength;
    
   
          labels[iii].setText("");
         
         }

                   }});
           MFrame.add(button);
       }
    
    
    public static void main(String[] args) {
        
        
        new CountingConstant();
        
    }
}

So awful it is difficult to read and even harder to interpret your code if you're an outsider who didn't write it. I ask that if you want us to put in the effort to try to understand your code and try to help you, please put in the effort yourself to make it easy for us to do so by making your code us uniform and standard code style with uniform indentations. For instance:

import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;

public class CountingConstant extends JFrame {

   JFrame MFrame;

   CountingConstant() {

      final JLabel[] labels = new JLabel[10];
      MFrame = new JFrame("Pirate Constant Counting");
      MFrame.setDefaultCloseOperation(EXIT_ON_CLOSE);
      MFrame.setSize(500, 500);
      MFrame.pack();
      MFrame.setVisible(true);

      MFrame.setLayout(new GridLayout(10, 1));

      labels[0] = new JLabel("0");
      labels[1] = new JLabel("1");
      labels[2] = new JLabel("2");
      labels[3] = new JLabel("3");
      labels[4] = new JLabel("5");
      labels[5] = new JLabel("4");
      labels[6] = new JLabel("7");
      labels[7] = new JLabel("6");
      labels[8] = new JLabel("9");
      labels[9] = new JLabel("8");

      for (int i = 0; i < labels.length; i++) {
         MFrame.add(labels[i]);
      }

      JButton button = new JButton("Begin");

      button.addActionListener(new ActionListener() {
         @Override
         public void actionPerformed(ActionEvent e) {
            int ii = 7;
            int changableLength = labels.length;
            for (int i = 0; i < changableLength; i++) {
               int iii = (ii + (110 - 1)) % changableLength;
               labels[iii].setText("");
            }
         }
      });
      MFrame.add(button);
   }

   public static void main(String[] args) {
      new CountingConstant();
   }
}

[ajs1351]

yea im trying to remove label form the array. but if i use the remove method. it gives me an "Array index out of range".

[code]
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;

public class CountingConstant extends JFrame {

JFrame MFrame;

CountingConstant()
{

final JLabel[] labels = new JLabel[10];
MFrame = new JFrame("Pirate Constant Counting");
MFrame.setDefaultCloseOperation(EXIT_ON_CLOSE);
MFrame.setSize(500, 500);
MFrame.pack();
MFrame.setVisible(true);

MFrame.setLayout(new GridLayout(10, 1));

labels[0] = new JLabel("0");
labels[1] = new JLabel("1");
labels[2] = new JLabel("2");
labels[3] = new JLabel("3");
labels[4] = new JLabel("5");
labels[5] = new JLabel("4");
labels[6] = new JLabel("7");
labels[7] = new JLabel("6");
labels[8] = new JLabel("9");
labels[9] = new JLabel("8");

for (int i = 0; i < labels.length; i++)

{

MFrame.add(labels[i]);

}

JButton button = new JButton("Begin");

button.addActionListener(new ActionListener()
(

{

@Override
public void actionPerformed(ActionEvent e)

{

int ii = 7;
int changableLength = labels.length;
for (int i = 0; i < changableLength; i++)

{

int iii = (ii + (110 - 1)) % changableLength;
labels[iii]. remove(iii);

}

}

}

);
MFrame.add(button);



}

public static void main(String[] args)

{

new CountingConstant();

}

}

[ajs1351]

at first i was trying to remove the label form the array. but i keep getting an error " Array index out of Range" . i use the remove method but it is not working. so how do i go about this?

[Fubarable]

I would use an ArrayList of JLabel or ArrayList<JLabel>, not an array, and then when the label has been selected, remove it from both the ArrayList and the container that holds it, and then call revalidate() and repaint() on the container that holds it.

[ajs1351]

if i have this arraylist m how do i add it to the container. b/c everytime i try to add it its not compatible.

         ArrayList<JLabel> label = new ArrayList<JLabel>();
        
        String[] nums = {"0","1","2","3","5","4","7","6","9","8"};  

      
       for(int i = 0 ; i < nums.length; i++)
        {
             label.add(new JLabel(nums[i]));
             p.add(label[]);     // CONTAINER   . what needs to be added?    p.add(label.get(i))  ??
             
        }

[Dark]

What is the error you get when you try? You said "b/c everytime i try to add it its not compatible." That doesn't tell us what compile error you are getting. Posting a compile error will help get a faster response and honestly a compile error tells you exactly whats wrong. If you don't know how to fix it after you find out whats wrong, then asking for help is the best decision.

tl;dr: Post the compiler error please.

[Fubarable]

Right now you're creating your JLabel on the same line that you add it to its container, so there's no way to get a reference to it and add it to the list. Instead you should create a JLabel within the for loop on its own line

JLabel myLabel = new JLabel(foo[i]);

and then add that same object to the container and to the ArrayList<JLabel>.

[ajs1351]

Is this what you mean ? creating the array is no problem. but when i add it to the jframe. it only displays the last array index.

 ArrayList<JLabel> label = new ArrayList<JLabel>();
  
 String[] nums = {"0","1","2","3","5","4","7","6","9","8"}; 
 
 
for(int i = 0 ; i < nums.length; i++)
 {
      label.add(new JLabel(nums[i]));  // adds the 10 contents.
            
 }


for(int i = 0 ; i < label.size() ; i++)
 {
   p.add(label.get(i));      //   it only shows the last index of the array
 }

[pbrockway2]

p.add(label.get(i)); // it only shows the last index of the array

Check that the layout manager for p is appropriate for displaying multiple labels.

[edit] You talk about adding the label "to the jframe", but you really need to be careful about the container that you are using - very likely a JPanel instance . Check out How to use Panels and Using Toplevel COntainers.

[ajs1351]

k, so i redid the code using a jpanel . but i still cant it to remove the Jlable that correspond to the array element that was removed.

when i press the button, it did remove 5 elements in the array. because i printed out the array size.

but it is not removing the jlabel.

So i still needed to remove the Jlabel or if i cant remove it replace with a text of some sort.

that where im at now.

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;
import java.awt.*;
import java.util.ArrayList;
import javax.swing.JPanel;
import javax.swing.JTextField;


public class CountingConstant    {

         private JFrame MFrame;
         private JPanel Jp;
         private JTextField IT = new JTextField(25);
         private JTextField CT = new JTextField(25);
         private JButton button = new JButton("Begin");
         private JLabel[]  labels;
         private JLabel  Display = new JLabel();
         private ArrayList<JLabel> ArrayLab;
    
    
        public CountingConstant()
       {
           
            
           MFrame = new JFrame("Pirate Constant Counting");
           MFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
           MFrame.setSize(500,500);
           MFrame.setVisible(true);
           Jp = new JPanel();
           Jp.setBackground(Color.yellow);
           
           ArrayLab = new ArrayList<JLabel>();
           ArrayLab.add(0, new JLabel("0"));
           ArrayLab.add(1, new JLabel("1"));
           ArrayLab.add(2, new JLabel("2"));
           ArrayLab.add(3, new JLabel("3"));
           ArrayLab.add(4, new JLabel("5"));
           ArrayLab.add(5, new JLabel("4"));
           ArrayLab.add(6, new JLabel("7"));
           ArrayLab.add(7, new JLabel("6"));
           ArrayLab.add(8, new JLabel("9"));
           ArrayLab.add(9, new JLabel("8"));
        
           
           
           
           Jp.setLayout(new GridLayout(10,1));
           

           
           for(int i = 0 ; i < ArrayLab.size(); i++)
           {
           Jp.add(ArrayLab.get(i));
           }
           
            Jp.add(IT);
            Jp.add(CT);

           
         
           button.addActionListener(new ActionListener()
                   {
                         @Override
                         public void actionPerformed(ActionEvent e) 
                           {
				
	                      int Indx = Integer.parseInt(IT.getText());
                              int Count = Integer.parseInt(CT.getText());

                                  //Removes All ODD Numbers.
                                 for(int i = 0; i < ArrayLab.size(); i++)
                                   {
                                     Count = ( Indx + (Count-1) ) % ArrayLab.size();
        
                                        ArrayLab.remove(Count);     //removes the element of the array.
                            
                                   }
                                      Display.setText(Integer.toString(ArrayLab.size()));    //size of the array.
                             }        
                   }
                );
            Jp.add(Display);
           //Add Button To Panel
           Jp.add(button);
           
           
           //ADD Panel TO JFRAME
           MFrame.add(Jp);
       }
    
    
    public static void main(String[] args) {
        
        
        new CountingConstant();
        
    }
}

[pbrockway2]

With the expression "ArrayLab.remove(Count);" you are removing a label at a given index position within the list of labels. You also have to remove that label from the panel (see Container API docs), or set its text (see JLabel API docs).

[edit] Also it would be a very good thing if you rewrote the code to conform with Java coding practices: methods and variables start with a lowercase letter.

[ajs1351]

i used a container.remove for the labels. but it is not removing the right labels. its not matching the what the array has removed.

button.addActionListener(new ActionListener()
                   {
                         @Override
                         public void actionPerformed(ActionEvent e) 
                           {
				
	                      int indx =  Integer.parseInt(it.getText());
                              int count = Integer.parseInt(ct.getText());

                                  //Removes All ODD Numbers.
                                 for(int i = 0; i < arraylab.size(); i++)
                                   {
                                     count = ( indx + (count-1) ) % arraylab.size();
        
                                        arraylab.remove(count);
                                        jp.remove (arraylab.get(count));   //container removing label
                               
                                       jp.repaint();
                            
                                   }
                                      display.setText(Integer.toString(arraylab.size()));
                             }        
                   }
                );

[pbrockway2]

arraylab.remove(count);
jp.remove (arraylab.get(count));   //container removing label

That looks like the right idea, but think about what those lines do. The first removes a label (at index count) from the array, the second tries to get the label from the array (in order to remove it from the panel). But you can't expect to get() something that you have removed! The order of these lines is wrong.

(In fact the remove() method actually returns the thing that was removed which is handy in cases like this where you want to do something further with that thing.)

[ajs1351]

So if the order of those lines are wrong. first remove the container label, then remove the array?


wont it be the same thing?

[pbrockway2]

wont it be the same thing?

There's only one way to find out: try it.

In case there's any confusion when you remove the labels from the list you do by index value. This has nothing to do with the text displayed on that label.

[ajs1351]

yea i tried it , and it removes the labels. but still removing the wrong indexes of the array.

but i know the formula i have there works in removing all odd numbers in the array with a starting index of 7 . constant count = 110.

i can get this to work on a console application with no issues. but i cant get it to work on a gui interface.

[pbrockway2]

We have something of a moving target here: "it is not removing the label" -> "it is not removing the right labels" -> "removes the labels, but still removing the wrong indexes of the array".

It might be a good idea to alter your code so that it prints out the value of indx and, each time around the loop prints out the value of the count and the label being removed from the container. Focus your description of your problem on the behaviour (output) you observe and the behaviour you expect or intend. This is a continuation of the point Dark made before when you were getting compiler messages: we don't see your computer and need things described precisely - compiler messages, output, etc.

Bear in mind that you have not said what the code should do. Or what the code currently is. Perhaps there is another way - besides keeping an array and a container in synch - of doing what you are trying to do.

[Fubarable]

I wonder if you're trying to demonstrate the Josephus Problem or a variant thereof?

[ajs1351]

yes it similar to Josephus Problem. trying to get rid of the odds number elements in the array. with a initial index starting point. and constant count .

but my arraylist is not in sequence 0-9 . rather 0,1,2,3,5,4,7,6,9,8

in this case i have initial starting Index : 7 Count : 110

the formula i use which works in the console version is

  indx = (indx + (count-1) % arraylab.size();

this will eleminate all the odd elements in the array.

this is my output that i get from my console Version. which im trying to get similar with my array of Jlabels. which is not doing it.

 Starting Index: 7 ArraySize: 10

	ELement: 7 has been removed

Starting Index: 6 ArraySize: 9

	ELement: 9 has been removed

Starting Index: 7 ArraySize: 8

	ELement: 5 has been removed

Starting Index: 4 ArraySize: 7

	ELement: 1 has been removed

Starting Index: 1 ArraySize: 6

	ELement: 3 has been removed

Starting Index: 2 ArraySize: 5

Remaining Elements in the Array: [0, 2, 4, 6, 8]