Java Codeing Help

[Richard5324]

i am writing a code for a buttion when click to check a text field for Email sines Such as @ and . and also that it has to be 10 or more char i got these code so far dose anyone no were i am going wrong it dosent seen to work

if (TxtEmail.getText().trim().length() < 10) {
            JOptionPane.showMessageDialog(rootPane, "Invalid Email");
           }
            if (TxtEmail.toString().contains("@")){
                  return;}
            else{JOptionPane.showMessageDialog(rootPane, "Invalid Email Need @");}

                  if (TxtEmail.toString().contains(".")){
                  }else{ JOptionPane.showMessageDialog(rootPane, "Invalid Email Need .");}
                  return;

i got the 10 char to work but i cant seem to get the @ and the . to work also working on net beans if u needed to know
Thank You

[JosAH]

Shouldn't you check TxtEmail.getText().contains("@") instead? (the same appplies for the ".")

kind regards,

Jos

[Richard5324]

Thanks for thank Jos

[Richard5324]

i cant seem to get the 2nd one to work keep giving me a error (UNREACHERBAL TEXT)

            if (TxtEmail.getText().contains("@")){}
            else{JOptionPane.showMessageDialog(rootPane, "Invalid Email Need @");}
                return;
            if (TxtEmail.getText().contains(".")){}
            else{JOptionPane.showMessageDialog(rootPane, "Invalid Email Need @");}
                return;

[Fubarable]

Let's format your code better. Please see my comments in your code:

if (TxtEmail.getText().contains("@")){}
else {
   JOptionPane.showMessageDialog(rootPane, "Invalid Email Need @");
}

return; // this will *** always *** be called 

// when will this line ever be reached?
if (TxtEmail.getText().contains(".")){}
else { 
   JOptionPane.showMessageDialog(rootPane, "Invalid Email Need @"); 
}

return;

Here's where your improper code formatting has hindered your ability to see what your code is actually doing, and shows the importance of use of proper code formatting. So the lesson is to be more careful with your formatting, to not be afraid to use whitespace to make your code more readable (but not too much whitespace).

Also, I've added code tags to your post same as Jos to help make your code readable in this forum. please use them yourself when posting code in this forum. To do this, place the tag [code] above your code block, and [/code] below your block.