Starsign Program

[WillHorne]

Hi

im trying to write a program that tells you what starsign your in using if and else if statements

it works for one if statment like this

import java.util.Scanner;


public class Starsign {

/**
* @param args
*/
public static void main(String[] args) {

Scanner scan = new Scanner(System.in);
System.out.println("Enter Birth Day");
int num = scan.nextInt();
System.out.println("Enter Birth Month");
int month = scan.nextInt();


{
if (month >= 4 && num >= 20){
if (month <= 5 && num <= 20); }
System.out.println("You are a Taurus");
}

}
}


but as soon as i start adding other statements in it dosent work

import java.util.Scanner;


public class Month {

/**
* @param args
*/
public static void main(String[] args) {
// TODO Auto-generated method stub

Scanner scan = new Scanner(System.in);
System.out.println("Enter Birth Day ");
int day = scan.nextInt();
System.out.println("Enter Birth Month ");
int month = scan.nextInt();


{
if (month >= 1 && day >= 20) {
if (month <= 2 && day <= 18)
System.out.println("You are a Aquarius");
}
else if (month >= 2 && day >= 19) {
if (month <= 3 && day <= 20)
System.out.println("You are a Picies");
}
else if (month >= 3 && day >= 21) {
if (month <= 4 && day <= 19)
System.out.println("You are a Aries");
}
else if (month >= 4 && day >= 20) {
if (month <= 5 && day <= 20)
System.out.println("You are a Taurus");
}
else if (month >= 5 && day >= 21) {
if (month <= 6 && day <= 20)
System.out.println("You are a Gemini");
}
else if (month >= 6 && day >= 21) {
if (month <= 7 && day <= 22)
System.out.println("You are a Cancer");
}
else if (month >= 7 && day >=23) {
if (month <= 8 && day <= 22)
System.out.println("You are a Leo");
}
else if (month >= 8 && day >= 23) {
if (month <= 9 && day <= 22)
System.out.println("You are a Virgo");
}
else if (month >= 9 && day >= 23) {
if (month <= 10 && day <= 22)
System.out.println("You are a Libra");
}
else if (month >= 10 && day >= 23) {
if (month <= 11 && day <= 21)
System.out.println("You are a Scorpio");
}
else if (month >= 11 && day >= 22) {
if (month <= 12 && day <= 21)
System.out.println("You are a Sagittarius");
}
else if (month >= 12 && day >= 22) {
if (month <= 1 && day <= 19)
System.out.println("You are a Capricorn");
}
else
System.out.print("Invalid Coding");
}

}
}

Any help would be apreciated

Thanks

[Shoss]

The logic of your if statements is a little off. For example, the first statement -

if (month >= 1 && day >= 20) {
  if (month <= 2 && day <= 18)
    System.out.println("You are a Aquarius");
}

How can the day variable be both >= 20 and <= 18?

[javaTurtle]

Hello, try using this as you if statements:

if ((month == 1 && day >= 20) || (month == 2 && day <= 18))
{
System.out.println("You are a Aquarius");

}

[WillHorne]

Hi

Thanks for the advice but it hasn't worked

both my version and yours only gives the right output when i input the dates that are in the if statement for each star sign

e.g entering
Day -21
Month -3
prints out you are an Aries
but
Day-22
Month-3
prints out nothing


That's the same for all the signs

[Shoss]

What do your if statements look like now, can you post them? javaTurtle's method looks like it should work.

[WillHorne]

import java.util.Scanner;


public class Month {

/**
* @param args
*/
/**
* @param args
*/
public static void main(String[] args) {
// TODO Auto-generated method stub

Scanner scan = new Scanner(System.in);
System.out.println("Enter Birth Day ");
int day = scan.nextInt();
System.out.println("Enter Birth Month ");
int month = scan.nextInt();

{
if (month == 1 && day >= 20)
if (month == 2 && day <= 18)
System.out.println("You are a Aquarius ");

else if (month == 2 && day >= 19)
if (month == 3 && day <= 20)
System.out.println("You are a Picies");

else if (month == 3 && day >= 21)
if (month == 4 && day <= 21)
System.out.println("You are a Aries");

else if (month == 4 && day >= 20)
if (month == 5 && day <= 20)
System.out.println("You are a Taurus");

else if (month == 5 && day >= 21)
if (month == 6 && day <= 20)
System.out.println("You are a Gemini");

else if (month == 6 && day >= 21)
if (month == 7 && day <= 22)
System.out.println("You are a Cancer");

else if (month == 7 && day >=23)
if (month == 8 && day <= 22)
System.out.println("You are a Leo");

else if (month == 8 && day >= 23)
if (month == 9 && day <= 22)
System.out.println("You are a Virgo");

else if (month == 9 && day >= 23)
if (month == 10 && day <= 22)
System.out.println("You are a Libra");

else if (month == 10 && day >= 23)
if (month == 11 && day <= 21)
System.out.println("You are a Scorpio");

else if (month == 11 && day >= 22)
if (month == 12 && day <= 21)
System.out.println("You are a Sagittarius");

else if (month == 12 && day >= 22)
if (month == 1 && day <= 19)
System.out.println("You are a Capricorn");


else
System.out.print("Invalid Coding");
}

}
}

[WillHorne]

import java.util.Scanner;


public class Month {

	/**
	 * @param args
	 */
	/**
	 * @param args
	 */
	public static void main(String[] args) {
		// TODO Auto-generated method stub

		Scanner scan = new Scanner(System.in);
		System.out.println("Enter Birth Day ");
		int day = scan.nextInt();
		System.out.println("Enter Birth Month ");
		int month = scan.nextInt();
		
	{
		if (month == 1 && day >= 20) 
			if (month == 2 && day <= 18)
			System.out.println("You are a Aquarius ");
			
		else if (month == 2 && day >= 19) 
			if (month == 3 && day <= 20)
			System.out.println("You are a Picies");
			
		else if (month == 3 && day >= 21) 
			if (month == 4 && day <= 21)
			System.out.println("You are a Aries");
			
		else if (month == 4 && day >= 20) 
			if (month == 5 && day <= 20)
			System.out.println("You are a Taurus");
			
		else if (month == 5 && day >= 21) 
			if (month == 6 && day <= 20)
			System.out.println("You are a Gemini");
			
		else if (month == 6 && day >= 21) 
			if (month == 7 && day <= 22)
			System.out.println("You are a Cancer");
			
		else if (month == 7 && day >=23) 
			if (month == 8 && day <= 22)
			System.out.println("You are a Leo");
			
		else if (month == 8 && day >= 23) 
			if (month == 9 && day <= 22) 
			System.out.println("You are a Virgo");
			
		else if (month == 9 && day >= 23) 
			if (month == 10 && day <= 22)
			System.out.println("You are a Libra");
			
		else if (month == 10 && day >= 23) 
			if (month == 11 && day <= 21)
			System.out.println("You are a Scorpio");
			
		else if (month == 11 && day >= 22) 
			if (month == 12 && day <= 21)
			System.out.println("You are a Sagittarius");
			
		else if (month == 12 && day >= 22) 
			if (month == 1 && day <= 19)
			System.out.println("You are a Capricorn");
			
		
		else 
			System.out.print("Invalid Coding");
	}
		
}
}

[javaTurtle]

If its not working, maybe you are still "nesting" the if statements. There is not any need to nest the if statemnets. Post your code so we can see what is going on. Thanks!

[Norm]

	if (month == 1 && day >= 20)       // If this is true what is the value for month?
			if (month == 2 && day <= 18)   // if the above is true, will this ever be true?

A suggestion: Always use {}s with if statements. Some day you are going to insert a statement following an if and push the following statement out of the if statements control but the indentation will fool you to not see the change in the logic flow.