Geometric shapes

[droidus]

I need help returning some values in this Geometric shapes class. I have to use extends. here are my three classes that go together. For some reason, I am only getting the color.

[Java] Shape - Pastebin.com
[Java] ShapesDriver - Pastebin.com
[Java] Sphere - Pastebin.com

[Junky]

For some reason, I am only getting the color.

Your description of the problem is very vague.
The chances of people following those links and wading through all your code is very low. Instead post a SSCCE and ask a specific question.

[droidus]

public class Shape {

	protected String color;
	protected double surfaceArea;
	protected double volume;
	protected double pi = Math.PI;
	boolean end = false;
	
	public Shape(String a) {
		color = a;
	}

	public String color(String color) {
		this.color = color;
		return this.color;
	}
	public double surfaceArea(double surfaceArea) {
		this.surfaceArea = surfaceArea;
		return this.surfaceArea;
	}
	public double volume(double volume) {
		this.volume = volume;
		return this.volume;
	}
	
	// Get the name of the class
	public String getThisClass() {
		String thisClassString = this.getClass().toString();
		String newString = "";
		char character;
		boolean start = false;
		
		for (int i = 0; i<thisClassString.length(); i++) {
			character = thisClassString.charAt(i);
			
			if(character == ' ') {
				start = true;
			} 
			else if(start == true) {
				newString = newString + character;
			}
			else {
				// do nothing -- continue the loop
			}
		}
		return newString;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see java.lang.Object#toString()
	 */
	@Override
	public String toString() {
		// Get the name of the class (or the name of the shape that we are working with)
		String thisClassIs = getThisClass();
		
		// For a sphere
		if ((thisClassIs).equals("sphere")) {
			end = true;
			return "SPHERE\nVolume: " + this.volume + "\nColor: " + this.color +  "\nSurface Area: " + this.surfaceArea;
		} 
		// For a cube
		else if((thisClassIs).equals("Cube") && end == false) {
			return "\n\nCUBE\nVolume: " + this.volume + "\nColor: " + this.color +  "\nSurface Area: " + this.surfaceArea;
		}
		else {
			return "Volume: " + this.volume + "\nColor: " + this.color + "/nSurface Area: " + this.surfaceArea;
		}
	}
}

public class ShapesDriver {

	/**
	 * @param args
	 */
	public static void main(String[] args) {
		// Puts in a color, surface area, and volume
		sphere ball = new sphere("Green", 5.7, 6.9 ,5);
		System.out.print(ball);
		
		/*Cube cuboid = new Cube("Yellow", 5.7, 6.9, 8.5);
		System.out.print(cuboid);*/
	}
}

public class sphere extends Shape {
	
	private double r;
	
	public sphere(String color, double a, double c, double r) {
		super (color);
		volume();
		surfaceArea();
		this.r = r;
	}
	
	public void volume () {
		volume = (4/3) * super.pi * Math.pow(r, 3);
	}
	
	public void surfaceArea() {
		surfaceArea = 4 * super.pi * Math.pow(r, 2);
	}
}

[Junky]

and your question is?

[droidus]

Why is my volume and surface area returning 0's?

[Junky]

I have an issue with your toString method. Why is it doing things based upon the subclasses? Any subclasses should have their own toString methods. Think of it this way, before Sphere, Cube, Triangle etc classes exist the toString of Shape shoudl be fully functional. But as you have it now it is doing soemthing based on a class that does not exist, Cube. In real life if someone ask you what your name is would you reply "My name is John and my son is called Peter" even though you do not have a son?

[pbrockway2]

public sphere(String color, double a, double c, double r) {
    super (color);
    volume();
    surfaceArea();
    this.r = r;
 }

You are calling volume() and surfaceArea() while the radius is still zero. Set this.r=... first.

(Also it's a good idea to follow Java coding conventions and call the class Sphere starting with a capital letter.)

[Junky]

public void volume () {

They aren't returning anything.

[droidus]

ok, so i've added this snippet of code to my sphere class:

@Override
	public String toString() {
		return color;
	}

how do i go about getting the volume and surface area properly?

[Junky]

Did you bother to read replies 7 & 8? Between them you should be able to fix your problem.