ArrayIndexOutOfBoundsException problem

[coasterguy10]

Im working on a program that is supposed to read in a Car or SoldCar object and add it to an array. Some other methods will follow but right now im having trouble getting the program to read in my data. We cant use scanner so this way is different for me. The program compiles, but then throws an ArrayIndexOutOfBoundsException at line 67 and i dont know why. If someone could take a look and tell me if what I have written is even setting me in the right direction. Btw, I dont use ArrayList very much, so I dont know if im even adding the objects into the ArrayList correctly. Thanks

   import java.util.ArrayList;
   import java.io.FileReader;
   import java.io.BufferedReader;
   import java.io.FileNotFoundException;
   import java.io.IOException;

   public class SellingCars
   {
      public static void main(String[] args)
      {
         String type;
         int id, modelYear;
         double dealerCost;
         double priceSold;
         Date dateArrived, dateSold;
         String customer;
         String makeMod;
      
         ArrayList<Car> cars = new ArrayList<Car>();
          
         FileReader reader=null;
         Car car;
         SoldCar sCar;
      
         String temp="";
         
         try
         {
            reader = new FileReader("cars.txt");
            BufferedReader in = new BufferedReader(reader);
            
            while(temp != null)
            {
               temp =in.readLine();
               String[] data = temp.split(" ");
               if (data[0] == "X")
                  break;
               else if (data[0] == "C")
               {
                  dealerCost = Double.parseDouble(data[1]);
                  id = Integer.parseInt(data[2]);
                  dateArrived = new Date(data[3], Integer.parseInt(data[4])
                     							, Integer.parseInt(data[5]));
                  modelYear = Integer.parseInt(data[6]);
                  makeMod = data[7];
                  car = new Car(dealerCost, id, dateArrived, modelYear, makeMod);
                  cars.add(car);
               }
               else if (data[0] == "S1")
               {
                  id = Integer.parseInt(data[1]);
                  priceSold = Double.parseDouble(data[2]);
                  customer = data[3];
                  dateSold = new Date(data[4], Integer.parseInt(data[5])
                     							, Integer.parseInt(data[6]));
                  sCar = new SoldCar(id, priceSold, customer, dateSold);
                  cars.add(sCar);
               }
               else
               {
                  dealerCost = Double.parseDouble(data[1]);
                  id = Integer.parseInt(data[2]);
                  dateArrived = new Date(data[3], Integer.parseInt(data[4])
                     							, Integer.parseInt(data[5]));
                  modelYear = Integer.parseInt(data[6]);
                  makeMod = data[7];
                  priceSold = Double.parseDouble(data[8]);
                  customer = data[9];
                  dateSold = new Date(data[10], Integer.parseInt(data[11])
                     							, Integer.parseInt(data[12]));
                  sCar = new SoldCar(dealerCost, id, dateArrived, modelYear, makeMod,
                     					priceSold, customer, dateSold);
                  cars.add(sCar);
               }
               
               temp = in.readLine();
            }
         
         }
            catch (IOException ioe)
            {
               ioe.printStackTrace();
            }
      }
   }

[Fubarable]

I'm assuming that the line causing your error is this one?:

priceSold = Double.parseDouble(data[8]);

You are working with hard-coded array indices (for example the [8] above is a hard-coded number), but are doing so without knowing that the array contains at least 9 or more members. You can test this out, and it would be a good idea for you to do this, if only to see what your program is doing. I would add the following lines in your code above:

      try {
         reader = new FileReader("cars.txt");
         BufferedReader in = new BufferedReader(reader);

         while (temp != null) {
            temp = in.readLine();
            String[] data = temp.split(" ");
            
            // *** added lines of code:
            System.out.println("data length: " + data.length); // how many items are really in the array
            System.out.println("show data: " + java.util.Arrays.toString(data));

Another problem is that you are comparing Strings using the == operator:

if (data[0] == "X")
   break;

Note that == checks if two objects are one and the same, and that's not what you care about here. Rather you want to know if the data[0] String contains one char only and that char is 'X', and to find that out, you'll want to use the equals method. So change that line to

if (data[0].equals("X")) {
   break;
}

You'll also want to enclose all blocks of code including if blocks in curly braces as I've done above.

[coasterguy10]

Ok i fixed the == problem, that was an oversight on my part. But now I am getting a NullPointerException at line 35, where I split the data up

[coasterguy10]

You are working with hard-coded array indices (for example the [8] above is a hard-coded number), but are doing so without knowing that the array contains at least 9 or more members. You can test this out, and it would be a good idea for you to do this, if only to see what your program is doing. I would add the following lines in your code above:

      try {
         reader = new FileReader("cars.txt");
         BufferedReader in = new BufferedReader(reader);

         while (temp != null) {
            temp = in.readLine();
            String[] data = temp.split(" ");
            
            // *** added lines of code:
            System.out.println("data length: " + data.length); // how many items are really in the array
            System.out.println("show data: " + java.util.Arrays.toString(data));

I added those lines to see what was going in, and it looks like the program is only taking every other line of data in the text file. Any ideas?

[Fubarable]

Ok i fixed the == problem, that was an oversight on my part. But now I am getting a NullPointerException at line 35, where I split the data up

The only variable that can be null on that line and cause a NPE is temp, and this is not surprising:

while (temp != null) {
   temp = in.readLine();
   String[] data = temp.split(" ");

You check that temp isn't null when the while loop begins, but then read in a value immediately at the start of the loop, and that value could be null. The solution is to read in the value in the while boolean statement itself:

while ((temp = in.readline()) != null) {
   //  temp = in.readLine(); // *** comment or remove this line!
   String[] data = temp.split(" ");