Just curious if my code could be more concise

[bohrstein]

import java.util.*;
public class test1 {
	public static void main(String[] args) {
		Scanner keyboard = new Scanner(System.in);
		System.out.print("Would you like to draw a card? ");
		String answer = keyboard.nextLine();
		int random = (int)(Math.random() * 13) +1;
		int card = (int)(Math.random() * 5) +1;
		String card1 = Integer.toString(card);		
		for(int i = 0; i < 1; i = i +1)
		{
			if(answer.equals("yes") || answer.equals("Yes"))
			{
				if(card == 1)	
				{
					if(random == 11 || random == 12 || random == 13 || random == 1)
					{
						if(random == 1)
						{
							card1 = "Spades";
							System.out.println("Your card is the Ace of " + card1);
						}
						else if(random == 11)
						{
							card1 = "Spades";
							System.out.println("Your card is the Jack of " + card1);
						}
						else if(random == 12)
						{
							card1 = "Spades";
							System.out.println("Your card is the Queen of " + card1);
						}
						else if(random == 13)
						{
							card1 = "Spades";
							System.out.println("Your card is the King of " + card1);
						}
						
					}
					if(random > 1 && random < 11)
					{
						card1 = "Spades";
						System.out.println("Your card is the " + random + " of " + card1);
					}
				}
				if(card == 2)
				{
					if(random == 11 || random == 12 || random == 13 || random == 1)
					{
						if(random == 1)
						{
							card1 = "Hearts";
							System.out.println("Your card is the Ace of " + card1);
						}
						else if(random == 11)
						{
							card1 = "Hearts";
							System.out.println("Your card is the Jack of " + card1);
						}
						else if(random == 12)
						{
							card1 = "Hearts";
							System.out.println("Your card is the Queen of " + card1);
						}
						else if(random == 13)
						{
							card1 = "Hearts";
							System.out.println("Your card is the King of " + card1);
						}
						
					}
					if(random > 1 && random < 11)
					{
						card1 = "Hearts";
						System.out.println("Your card is the " + random + " of " + card1);
					}
				}
				if(card == 3)
				{
					if(random == 11 || random == 12 || random == 13 || random == 1)
					{
						if(random == 1)
						{
							card1 = "Diamonds";
							System.out.println("Your card is the Ace of " + card1);
						}
						else if(random == 11)
						{
							card1 = "Diamonds";
							System.out.println("Your card is the Jack of " + card1);
						}
						else if(random == 12)
						{
							card1 = "Diamonds";
							System.out.println("Your card is the Queen of " + card1);
						}
						else if(random == 13)
						{
							card1 = "Diamonds";
							System.out.println("Your card is the King of " + card1);
						}
						
					}
					if(random > 1 && random < 11)
					{
						card1 = "Diamonds";
						System.out.println("Your card is the " + random + " of " + card1);
					}
				}
				if(card == 4)
				{
					if(random == 11 || random == 12 || random == 13 || random == 1)
					{
						if(random == 1)
						{
							card1 = "Clubs";
							System.out.println("Your card is the Ace of " + card1);
						}
						else if(random == 11)
						{
							card1 = "Clubs";
							System.out.println("Your card is the Jack of " + card1);
						}
						else if(random == 12)
						{
							card1 = "Clubs";
							System.out.println("Your card is the Queen of " + card1);
						}
						else if(random == 13)
						{
							card1 = "Clubs";
							System.out.println("Your card is the King of " + card1);
						}
						
					}
					if(random > 1 && random < 11)
					{
						card1 = "Clubs";
						System.out.println("Your card is the " + random + " of " + card1);
					}
				}
							
			}
			if(answer.equals("no") || answer.equals("No"))
				System.out.println("LAME!!!!");
			//if(answer != "no" && answer!= "No" && answer == "yes" && answer != "Yes")
			//{
				//System.out.println("That is invalid");
				
			//}
				
				
		
		}
	
	}

}

[Fubarable]

Just briefly eyeballing it, I'd say yes, it can be more concise, but I can't really tell you details because I can't read your code. Please edit your post above and addcode tags above and below your posted code. Something like this:

[code]

your code goes here

[/code]

[bohrstein]

ok I fixed it

[Fubarable]

You've got a ton of redundancies. All the code that looks the same could be made into one single block.

Evaluate the suit in one block, and then evaluate the rank or value of the card in a second block of code. Consider use of arrays as well to simplify some of this. I'd also recommend enums, but I'm guessing that this is for school and you're not allowed to use them.

Also, that's a heck of a lot of aces. :)

[Fubarable]

For instance, if you put your suit Strings into an array of String, you could get the suit name in one line of code. The same can be done for the card value names.

[bohrstein]

yea it is for school and we haven't learned arrays set so I was just seeing what i could do with what I knew. And how would you write it as an array or enum; could you explain enum?

[chipp]

long time not "come" to the forum :D btw, this:

					if(random == 11 || random == 12 || random == 13 || random == 1)
					{
						if(random == 1)
						{
							card1 = "Spades";
							System.out.println("Your card is the Ace of " + card1);
						}
						else if(random == 11)
						{
							card1 = "Spades";
							System.out.println("Your card is the Ace of " + card1);
						}
						else if(random == 12)
						{
							card1 = "Spades";
							System.out.println("Your card is the Ace of " + card1);
						}
						else if(random == 13)
						{
							card1 = "Spades";
							System.out.println("Your card is the Ace of " + card1);
						}
						
					}

i think you should do like this:

	if(random == 11 || random == 12 || random == 13 || random == 1) {
		card1 = "Spades";
		System.out.println("Your card is the Ace of " + card1);
	}

simplified...

[bohrstein]

I am an idiot, it should have been ace, jack, queen, king

[chipp]

so it should be like this:

switch (random) {
case 1: card1 = "ace"; break;
case 11: card1 = "jack"; break;
case 12: card1 = "queen"; break;
case 13: card1 = "king"; break;
default: break;
}
System.out.println ("Your card is the " + card1);

[bohrstein]

oh okay, I wasn't sure if you could have a switch within an if statement, thanks