String.replace function

[johnhelen]

Hello

I want to replace two SubString inside a String.

I tried the code below but it did not work

public String getFormattedString (String var1, String var2) {
    String rawText = "Name [name] and price [price]";
    rawText.replace("[name]", var1);
    rawText.replace ("[price]", var2);
    return rawText; 
}

If I changed to this, it will work but I believe this is not good way as I have to create 3 Strings

public String getFormattedString (String var1, String var2) {
    String rawText = "Name [name] and price [price]";
    String temp = rawText.replace("[name]", var1);
    String formattedText = temp.replace ("[price]", var2);
    return formattedText; 
}

Can you please help
Many thanks
john

[DarrylBurke]

Strings are immutable. Every time you "change" a String you create a new String. Discarding the return values, as in your first code snippet, doesn't change that.

Just do things the right way and stop worrying about possible micro-optimizations.

db