Need help with get/set & arrayList in multiple methods

[FiasseKrystella]

I'm currently doing a project for my course and got totally lost with the object interaction part, read my teaching material couple of times but still couldn't get the codes right. The question goes:

1:Write a class Card.java which represents one playing card. It should have
a constructor to create a card from a suit and a rank. You should provide appropriate get/set methods.
a method String toString() to return the name of the card, e.g. "King Diamond"


2: Write a class Pack.java which represents a pack of 52 playing cards. Every card in the pack must be unique. It should have
a constructor to create a new pack of 52 cards. It should have 4 suits, each suit should have 13 cards of different ranks.
a method void shuffle() to randomise the sequence of cards in the pack.
a method Card dealCard() to return the card from the top of the pack.
a method getCard(int n) to return the nth card from the pack.

3: Write a main program PackTest to test your class Pack. The program should create a new pack and print the names of all 52 cards one per line:
1: Ace Heart
2: Two Heart
...
52: King Spade

and heres my code:

Card

public class Card {
static String cardIdentity;
public Card(String cardValue){
cardIdentity=cardValue;
}
public String showCard(){
return cardIdentity;
}
}

Pack: This method will setup an ArrayList consist of 52 unique card with a value and shape

import java.util.ArrayList;
public class Pack {
ArrayList<Card> cardList=new ArrayList<Card>();
public Pack() {
String[] value={"Ace","Two","Three","Four","Five","Six","Se ven","Eight","Nine","Ten","Jack","Queen","King"};
String[] rank={"Spade","Heart","Diamond","Club"};
for(int v=0;v<52;v++){
int r=0;
if(v==12||v==25||v==38){
r++;
}
cardList.add(new Card(v+" "+r));
}
} //End of Pack method
public Card getCard(int g){

return cardList.get(g); // My method for getting the card name from a specific card, but it seemed wrong
}
}

Pack Test

public class PackTest {

public static void main(String[]args) {
Pack deck = new Pack();
for(int i=0;i<52;i++){
System.out.println((deck.getCard(i))); My problem starts here, it won't print the name of card instead it will print some wierd values eg.Card@3f317f
}

}

}

[R-J]

cardList.add(new Card(v+" "+r));

needs to be changed to...

cardList.add(new Card(value[v]+" "+rank[r]));

You are only passing the indexes into the array as your string, you need to resolve the array values with the syntax there. I would make a nested loop. Your outer loop would run from 0 to value.length, counted by v. Your inner loop would run from 0 to rank.length and be counted by r.

Then you can remove...

int r=0;
if(v==12||v==25||v==38){
r++;

System.out.println((deck.getCard(i)));

Needs to be

System.out.println((deck.getCard(i).showCard()));

You are just printing out a memory location, you need to further specify which part of a "Card" you want to print, in this case the string "cardIdentity".

static String cardIdentity;

Should be

private String cardIdentity;

The static will make it so that every time you change one object, you change all of the objects and you'll have the same card, so we remove the "static" tag.

You want to make it a private variable because otherwise your accessor method (showCard method) is redundant. Making it private preserves encapsulation.

[FiasseKrystella]

Thank you very much for your help, R-15. I've managed to get it right and working from your assistance.

[R-J]

No problem. I looked at your requirements and it looks like you need to rename your showCard() method to toString() as well.

[FiasseKrystella]

Yes. I was still thinking of how to create the toString() method not realizing that I've already created the same method of a diff. name. Lol