URGENT toString method help

[johnnyjava]

Hey guys im new to java and am having problems getting a Junit test class to pass as my tostring method wont work for me.Can anybody help me write the code to make this pass, this assignment is due tomorrow and i really need this to pass


public void testConstructor()
{
assertEquals("John Smith (id 5643) has an account balance of 5000.5",
theCustomer.toString());
}

[KevinWorkman]

That's not how this works. Please see the link in my signature on asking questions the smart way before you post again.

[Fubarable]

Hello and welcome to the java-forums. Please note that your urgency and grade are not our problem. Also we are more than happy to answer any specific questions you may have but are not here to write your code.

[JeffGrigg]

I would guess from looking at this that your instructor wants you to create a class, possibly called something like Customer, and that this class should include at least three fields. You would probably want to pass the values in as constructor parameters. And then assign field values in the body of the constructor method. Then implementing (overriding) the 'toString()' method should be easy.

I do hope that some instruction and/or reading assignment happened before giving you this homework.

[Fubarable]

I'm not sure what the original poster is asking here myself: "having problems getting a Junit test class to pass as my tostring method". At least to me his problem is very unclear.

[johnnyjava]

Sorry im new to the forum,so I am not used to how things go here,@ Fubarable im just unsure how to format tostring properly,i have been writing code to make a test pass.

[Fubarable]

Sorry im new to the forum,so I am not used to how things go here,@ Fubarable im just unsure how to format tostring properly,i have been writing code to make a test pass.

I'm not sure how you need to format it yet either. Perhaps if you post your exact instructions we can clarify this for you.

[johnnyjava]

@Fubarable.Basically my task was to write code to make a junit test pass.Ive have gotten everything to pass apart from Testing the constructor of the Customer class using the overridden toString() method.
This is what is in the test class
public void testConstructor()
{
assertEquals("John Smith (id 5643) has an account balance of 5000.5",
theCustomer.toString());
}

to make it pass i wrote this to make it pass
return name + "(" + "id" + id + ")"
+ " has an account balance of" + balance;


but it still didnt work im just wondering where I have go wrong here,

[KevinWorkman]

Print out what you're returning from toString(). Compare that to the String in your assert. Check each character carefully. Line them up side by side or on top of one another if you have to.

[johnnyjava]

this is the code i have written to make the test pass

public class Customer {
private int id;
private String name;
private float  balance;

public Customer(int anId, String aName, float aBalance        ){
	this.id=anId;
	this.name= aName;
	this.balance=aBalance;
}

public void setId(int anId       ){
	id=anId;
	
}
 public int getId(    ){
	 return id;
	 
 }
public void setName(String aName){
	name=aName;
	
}

public String getName(   ){
	return name;
	
}

public void setBalance(float aBalance){
	balance=aBalance; 
	  return name + "(" + "id" + id + ")"
	  + " has an account balance of" + balance;
	  
	
}

public float getBalance(){
	return balance;
	
}
  public String toString(){
	 
  }

}

this is the test

i m p o r t junit.framework.TestCase;
/**
 * @ a u t h o r Agile Systems Ltd.
 *
 */
p u b l i c c l a s s CustomerTest e x t e n d s TestCase 
{
/**
 * Customer reference variable storing reference to
 * Customer object. Used in all tests
 */
Customer theCustomer = n e w Customer(5643, "John Smith", 5000.5f);
/**
 * Testing the constructor of the Customer class
 * using the overridden toString() method
 */
p u b l i c v o i d testConstructor()
{
assertEquals("John Smith (id 5643) has an account balance of 5000.5", 
theCustomer.toString());
}
/**
 * Testing the setId() method. In the process
 * this tests the getId() method as well
 */
p u b l i c v o i d testSetId()
{
theCustomer.setId(6000);
assertEquals(6000, theCustomer.getId());
} 
/**
 * Testing the setName() method. In the process
 * this tests the getName() method as well
 */
p u b l i c v o i d testSetName()
{
theCustomer.setName("Sean Smith");
assertEquals("Sean Smith", theCustomer.getName());
}
/**
 * Testing the setBalance() method. In the process
 * this tests the getBalance() method as well
 */
p u b l i c v o i d testSetBalance()
{
theCustomer.setBalance(200f);
assertEquals(200f, theCustomer.getBalance());

[Tolls]

public void setBalance(float aBalance){
	balance=aBalance; 
	  return name + "(" + "id" + id + ")"
	  + " has an account balance of" + balance;
	  
	
}

This won't even compile, and it should be pretty clear why.

[johnnyjava]

@tolls
public class Customer {
private int id;
private String name;
private float balance;





public Customer(int anId, String aName, float aBalance ){
this.id=anId;
this.name= aName;
this.balance=aBalance;
}

public void setId(int anId ){
id=anId;

}
public int getId( ){
return id;

}
public void setName(String aName){
name=aName;

}

public String getName( ){
return name;

}

public void setBalance(float aBalance){
balance=aBalance;


}

public float getBalance(){
return balance;

}
public String toString(){

return name + "(" + "id" + id + ")"
+ " has an account balance of" + balance;








}

}



i copied and pasted it wrong this is what i wrote but it still wont work

[Tolls]

So, did you do what KevinWorkman suggested and print that out so you can see what it is actually returning from the toString() method?

[JeffGrigg]

When a JUnit test fails, the message in the exception typically gives you important information about where the test failed, and why. So including the stack trace of the JUnit failure in a posting to this group would be very helpful.

This is what I'm getting:

junit.framework.ComparisonFailure: expected:<John Smith[ (id 5643) has an account balance of ]5000.5> but was:<John Smith[(id5643) has an account balance of]5000.5>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at junit.framework.Assert.assertEquals(Assert.java:87)
	at CustomerTest.testConstructor(CustomerTest.java:19)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at ... [blah, blah, blah] ...
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

This tells me that you have it almost have it correct. You are soooo close!!!

[johnnyjava]

@JeffGrigg I just cant see where im going wrong
@tolls do you mean like System.out.println will work?

[Tolls]

Yes.
For both Strings.

[KevinWorkman]

do you mean like System.out.println will work?

What happened when you tried it?

[JeffGrigg]

JUnit inserts square brackets ('[' and ']') in the string values to show where the differences are. Removing the square brackets, we get...

junit.framework.ComparisonFailure: expected:<John Smith (id 5643) has an account balance of 5000.5> but was:<John Smith(id5643) has an account balance of5000.5>

Those two String values are not exactly the same. I can see three places where they differ. Can you?