Collision Detection, a little bit buggy.

[iamsothecoolest]

I've decided to try to learn the fundamentals of making a game. So, I started off by making a background and a character that moves. But then I wanted it so that when the character tries to go out of the frame, it's not allowed to. For the movement code, I used a tutorial that I modified to my needs because I didn't even know what classes from the Java library to use. But then I decided to just make my collision detection from scratch. But it's a little bit buggy. It won't detect and stop the character for a couple of milliseconds. Here's my code:

if(key == KeyEvent.VK_UP) {
			if(getUpLocked() == false) {
				if(getCharY() != 0 && getCharY() > 0) {
					yChange = -1;
					setDownLocked(false); //allows you to move if you haven't collided
				}
				else {
					yChange = 0;
					charY = 0;
					setUpLocked(true); //doesn't allow you to move if you collide
				}
			}
		}

I don't know if this is enough of my code to find the source of the problem but that's why I offered the source code.

[Norm]

It won't detect and stop the character for a couple of milliseconds

What stops the character?
Do you mean the x,y position continues to change and the paint method continues to draw the character after the collision was detected. What is the disconnect between the detection and the stopping?
Is there any relationship between when the user presses a key and when the collision is detected? Can the character continue to move if the key is not pressed?
Without seeing the code, we can only guess why the motion doesn't stop IMMEDIATELY when the flag is set.

[iamsothecoolest]

The easiest way to see what I'm talking about would be to compile the code in the attachment

[Norm]

Have you looked at the points I asked about?

[Norm]

Add some printlns to show the values of x and y as the character moves around. Look at what the values are when it goes out of the frame. Compare those with where the edges of the frame are.

[iamsothecoolest]

Oh, I actually already had the showing coordinates idea implemented . But the coordinates where it goes out of the frame varies each time with the furthest being around 100 pixels out of the frame.
EDIT: Like I said, the easiest way to see would be to compile the program in the .zip file I attached.

[Norm]

You need to do some more debugging:
Add some printlns to your code to show the x,y values of the character each time it is drawn. Add printlns where the x,y position of the character changes. Add printlns where the collision is detected. See if it continues making changes to the x,y after the collision is detected.

[Iron Lion]

Unrelated to the question, but this is redundant:

if(getCharY() != 0 && getCharY() > 0) {

If the second condition is true, the first is going to be true as well, so there's no need to test for both.

[iamsothecoolest]

Unrelated to the question, but this is redundant:

If the second condition is true, the first is going to be true as well, so there's no need to test for both.

That was just me being a stupid experimenter.

EDIT: Got rid of the first condition of the if statement. That was the one that was unecessary.

[iamsothecoolest]

Have you tried compiling it yet?

[Norm]

Yes, that's how I know what to tell you about how to debug it.