Out of bounds exception

I am using a for loop to extract digits out of a string. The string in question is cdates, which = "MW 130 230". I get an out bounds exception, but I'm using cdates.length() as the limit for the loop. How can it be going out of bounds? Weirdly, the exception occurs when the for loop enters (or tries to enter) iteration # 7. The string is longer than that. What the deuce is going on?!?!

Code:

---

public boolean timeConflictWith(DiaryItem c) {
                String thisdt = this.getDaysTimes();
                String cdates = c.getDaysTimes();
                StringBuffer filter = new StringBuffer(cdates);
                String Cee = "";
                String Tee = "";
                String ctime = "";
                boolean conflict = false;
                for(int i = 0; i < cdates.length(); i++){
                        char ch = cdates.charAt(i);
                        if(Character.isDigit(ch)){
                                ctime = ctime + ch;
                                filter.deleteCharAt(i);
                        }
                }
                cdates = "" + filter;
                cdates.replaceAll("AM","");
                cdates.replaceAll("PM","");
                cdates.trim();
                for(int j = 0; j < cdates.length(); j++) {
                        if(thisdt.length() < j){
                                break;
                        }       
                        else {       
                                char C = cdates.charAt(j);
                                Cee = " " + C;
                        }
                        for(int k = 0; k < thisdt.length(); k++){
                        char T = thisdt.charAt(k);
                        Tee = "" + T;
                        int result = Tee.compareTo(Cee);
                        if(result != 0)
                                continue;
                        else{
                                String cstart = cdates.substring(0,4);
                                String cend = cdates.substring(4);
                                int cstart2 = Integer.parseInt(cstart);
                                int cend2 = Integer.parseInt(cend);
                                conflict = cstart2 >= this.starttime && cstart2 < this.endtime ||
                                        cend2 > this.starttime && cend2 <= this.endtime;
                          return conflict;
                        }
                        }
                }
                return conflict;
        }

---

Hi - Instead of creating a StringBuffer called filter, why don't you create another String called filter and set it equal to cdates.

There is a useful method in the String class called replace, which you can read up on. All you will have to do is replace the character with an empty character.

Let me know if that works.

The error message will tell you on which line the exception occurs. Please indicate which line this is.

The error occurs at:
filter.deleteCharAt(i);

You have a problem with your logic. Each time around the loop i will get bigger, yet each time you delete a char from filter it will get smaller. Eventually i will be larger than filter.length().

Quote:

---

Originally Posted by MetalR0

The error occurs at:
filter.deleteCharAt(i);

---

That's what I thought too. The index of the character from cdates becomes invalid for filter when you start deleting characters. Come to think of it I think what I mentioned earlier will not work either. SOrry

Quote:

---

Originally Posted by return

That's what I thought too. The index of the character from cdates becomes invalid for filter when you start deleting characters. Come to think of it I think what I mentioned earlier will not work either. SOrry

---

Okay this is a suggestion, why consider using an array of characters? That's how I'm thinking maybe others have a more efficient idea?

Got it. Thanks!

If your task is remove digits from the String then you have 2 options.

Instead of starting with the StringBuffer containing all the chars and then start deleting the digits. You can start with an empty StringBuffer and only add a char to it if it is not a digit.

Or you can use the replaceAll method. Research how regular expressions work. You could start by looking at the Pattern class in the Java API which has plenty of information.

ReplaceAll was a godsend. Thanks!