Is this thread safe?

[veronique]

Is this implementation thread safe? How do I make it thread safe? It seems to be working when I run it, but I'm not sure if it's correct.

public class Calculate {

private int[] list = {0, 0};

public synchronized String getElements()
{
return list;
}

public synchronized void setElements(int first, int second) {
list[0] = first;
list[1] = second;
}
}



thanks

[masijade]

Looks to be.

[veronique]

Sorry could you elaborate pls?

[masijade]

As in on what?

You do realise, however, that the Dimension object you return is not thread-safe, however, right? As whoever retrieves it can change its coordinates themselves. You want to return a clone of the Dimension object is you want to prevent that.

[veronique]

How would I return a clone? return this.coordinates?

[masijade]

As in with the clone method? Or as in creating a new one using the coordinates from the first?

[veronique]

using coordinates from the first.

thanks

[kjkrum]

The Dimension class has a copy constructor. So instead of returning coordinates, return new Dimension(coordinates).