Scramble a String

[Zman3359]

I'm trying to scramble a String and I have it working, I was just wondering if there is a more efficient way of doing it than what I have. Does anyone have a suggestion on how to make this more efficient?

String abc = "abcdefghijklmnopqrstuvwxyz";
String scrambled = "";
Random randGen = new Random();

while(scrambled.length() != abc.length())
{
   char rand = abc.charAt(randGen.nextInt(abc.length()));
   if(!scrambled.contains("" + rand))
      scrambled += rand;
}

[Norm]

What is more efficient:
Fewer machine instructions executed
or fewer source statements.

Should the output String contain the same number of letters as the input String?
Your algorithm appears to only allow one copy of any letter. The longest that your output string could be would be 26 letters for any long string input to it.

[Zman3359]

I have no idea which is more efficient... The output String should contain the exact characters of the input String just mixed up.

[Norm]

The output String should contain the exact characters of the input String just mixed up.

Have you tested it with some different input to see what happens?

I have no idea which is more efficient.

I was asking you what you meant by being efficient. How do you determine if one piece of code is more efficient than another?

Which is worth more a one dollar bill or 30 quarters. The one dollar bill is more efficient to carry.

[sunde887]

One thing I can say immediately is to use a stringbuilder instead of string concatenation. Then use append. Norm made some good points as well, this should probably take a string input and scramble it.