Method call

[Norm]

If it returns 0 then is that the correct quantity for the product it is looking at?
Can you write a loop to print out all the product ids with their quantities?

[ralf]

Any idea what I'm doing wrong?

[Norm]

You need to understand how to use those methods.

As an exercise: write a loop to print out all the product ids with their quantities.

[ralf]

This is what I have tryed so far

The output:
1: Quantity 0// print 0 even there are two item with id number 132
1: ID 132
2: Quantity 0
2: ID 132

 for(int i = 0; i < stock.size(); i++)
             {
                System.out.println(i+1 + ": Quantity " + findProduct(id).getQuantity());
                System.out.println(i+1 + ": ID " + findProduct(id).getID());
                }

[Norm]

You don't show where id is defined or where it is given values.
Why is the id value always 132? Should the id value change as you go around the loop?
Where do you use the loop index i?

[ralf]

 This code is where the item is being added: I add it like this: (new Product(132, "Clock Radio")) and if I add the same line two or more times, then I think the quantity should keep a record on how many items there are. So no, the id value should not change. 
I insert 132 into the parameter in the method numberInStock
The index i it used to loop through the list

 public void addProduct(Product item)
    {
        stock.add(item);
    }

[ralf]

This is the constructor in the class Product, where quantity is set to 0. This is the value I get returned when I use the method numberInStock and not the number of items which are stored in stock arraylist

 public Product(int id, String name)
    {
        this.id = id;
        this.name = name;
        quantity = 0;
    }

[Norm]

Can you write a loop to print out all the product ids in stock with their quantities?
Print the product ids in column one and the quantities in column two.

[ralf]

I'm not shore if I understand you correct, but is it something like this for loop?
The output from the code below:

Quantity :0

ID :37
Quantity :0

ID :37
Quantity :0

ID :37
Quantity :0

ID :37

 for(int i = 0; i < stock.size(); i++)
             {

                System.out.println("Quantity :" + findProduct(id).getQuantity());
                 System.out.println();
                 System.out.println("ID :" + findProduct(id).getID());
                }

[Norm]

Here is what I was looking for:

   Product ID    Quantity
       101             4
       122             1
       133             6
       201             3

You only print the quantity for product id = 37. Is that the only product in the stock list?
For testing you should add at least 6 different product ids to the list with different quantities for each one.

[ralf]

I have this method which print out details
With this output:
Product: 23: Microwave Oven stock level: 0
Product: 23: Microwave Oven stock level: 0
Product: 23: Microwave Oven stock level: 0
Product: 37: Mobile Phone stock level: 0
Product: 132: Clock Radio stock level: 0

    public void printProductDetails()
    {
         Iterator it = stock.iterator();
        while(it.hasNext()) {
            Product product = (Product) it.next();
            System.out.println("Product: " + product);
            
           // System.out.println("Stock " + "Hello" + " " + stock);
        }
        
        
    }

[Norm]

But that is not what was requested.
The output was to be only the product id and the quantity.
Nothing else.
Does the class has methods for you get those values? Can you use them?

This is a very simple project. If you don't see how to use the methods in the Product class for this then you won't be able to use the Product class for your other project.

[ralf]

Hello, Norm!

I think this short code actually is sufficient for the task to find quantity
It is only the return line that is needed.
The next method that I'm about to do is a method to incresae the quantity. Until that method is done the return will return only 0
Or what do you think?

 public int numberInStock(int id)
    {// System.out.println("Quantity: " + findProduct(id).getQuantity());
        return findProduct(id).getQuantity();
                 //System.out.println("Quantity: " + findProduct(id).getQuantity());
      //         }
     //  return 0; 
            }

[Norm]

I think you should compile and execute it and see what happens. Test it with many different cases:
product not found, quantity = 0 and quantity > 0

[ralf]

It seems to work at least when I'm insert a number into the parameter, a number I know exist in the list of quantity, but if I insert a number which there are no items with that number, then I get:


java.lang.NullPointerException
at StockManager.numberInStock(StockManager.java:124)

[Norm]

What does the findProduct() method return when there are no items with that number?

[ralf]

The findProduct() return this when there are no items with that number

java.lang.NullPointerException
at StockManager.numberInStock(StockManager.java:124)

I try to use an if test stop the nullpointer, but it don't work yet, any idea?

[Norm]

Yes, you could use an if test to detect if a null was returned.

[ralf]

I'm stuck on this method numberInStock
Any idea on how I should do the test for 0?
should I use an if test inn an if test?

[Norm]

do the test for 0

You could use an if test:
if (variable == 0) ...