Really stuck in java

[evelina1]

Hi..I am pretty new to JAVA and im suppose to write a code that generates a maze...i have the code and i run it and i keep getting arrayoutofbound exception..here is the code.

public class StudentMazeGenerator
implements MazeGenerator
{
	private static final int h2 = 0;
	private static final int w2 = 0;
	private boolean[][] currMazeLoc;
	private boolean visited;
	//private Object randomNumInt;
	int[] listArray = {0,1,2,3};



	public  Maze generateMaze(int width, int height, MazeGeneratorListener listener)
	{
		Maze mazeFactory = MazeFactory.createMaze(width, height);

		currMazeLoc = new boolean[width][height]; 
		generatePath(mazeFactory, width, height, listener);

		return mazeFactory;
	}

	public void generatePath(Maze maze, int w, int h, MazeGeneratorListener  listener)
	{
		//	int[] listArray = new int[] {0,1,2,3};
		currMazeLoc[w][h] = visited;
		listener.mazeModified(maze);
		while(!unCheckedCell(w, h))
		{
			Random random = new Random();
			int temp = random.nextInt();
			if(temp == 0 && h != 0)
			{
				//check inside each of them to make sure ur not goin out of bound
				//ur at the end of the maze and u want to go east there is no more room...u get arrayindexoutofboundException
				if(!(currMazeLoc[w][h-1]))
				{
					maze.removeWallNorthOf(w, h); 
					h--;  
					listener.mazeModified(maze);
					generatePath(maze, w, h ,listener);  
				}  
			}  
			if(temp == 1 && w != w2 - 1)  
			{   
				if(!currMazeLoc[w+1][h])  
				{  
					maze.removeWallSouthOf(w, h);  
					h++;  
					listener.mazeModified(maze);
					generatePath(maze, w, h ,listener);  
				}  
			}  
			if(temp == 2 && h!= h2 - 1)  
			{    
				if(!currMazeLoc[w][h+1])  
				{  
					maze.removeWallEastOf(w, h);  
					h++;  
					listener.mazeModified(maze);
					generatePath(maze, w, h ,listener);    
				}  
			}  
			if(temp == 3 && w != 0)  
			{  
				if(!currMazeLoc[w-1][h])  
				{  
					maze.removeWallWestOf(w,h); 
					h--;  
					listener.mazeModified(maze);
					generatePath(maze, w, h ,listener);    
				}  
			}        
			return;  	
		}
	}
	//intArray.length-1;
	//int temp = listArray[i]
	//create an array of the (0 to 3) for N, S , E, W
	//create a method that shuffles the array N, E, S, W
	public void shuffle()
	{
		Random random = new Random();
		int[] listArray = new int[] {0,1,2,3};
		for (int i=0; i<listArray.length; i++)
		{
			int randomNum = random.nextInt(listArray.length -1);
			int temp = listArray[i];
		}
	}




	public boolean unCheckedCell(int w1, int h1) {
		if (( w1 == 0) && (h1 == 0))
			return (currMazeLoc[w1+1][h1] && currMazeLoc[w1][h1+1]);
		else if((w1 == (w2 - 1)) && (h1 == (h2 - 1)))  
			return (currMazeLoc[w1-1][h1] && currMazeLoc[w1][h1-1]); 
		else if((w1 == 0) && (h1 == (h2 - 1)))
			return (currMazeLoc[w1][h1-1] && currMazeLoc[w1+1][h1]); 
		else if (w1 == (w2 - 1) && (h1 == 0))
			return (currMazeLoc[w1 -1][h1] && currMazeLoc[w1] [h1 +1]);
		else
			return (currMazeLoc[w1+1][h1] && currMazeLoc[w1][h1+1] && currMazeLoc[w1-1][h1] && currMazeLoc[w1][h1-1]); 
		//return false;
	}	       

	public int nextInt(int n)  
	{  
		return (int)(0 + Math.random() * n);  
	}  

}

[sunde887]

Post the exact error message please. Stack traces are helpful, they tell you what part of the code threw an exception/caused an error. Somewhere you are indexing into an array above the length, or below 0.

public int nextInt(int n)  
	{  
		return (int)(0 + Math.random() * n);  
	}

Also in this piece of code, there is no point to add 0. .5555555555555+ 0 is still the same, it can be changed to

return (int)(Math.random()*n);

[evelina1]

Exception in thread "Thread-4" java.lang.ArrayIndexOutOfBoundsException: 10
at StudentMazeGenerator.generatePath(StudentMazeGener ator.java:39)
at StudentMazeGenerator.generateMaze(StudentMazeGener ator.java:31)
at MazeFrame$MazeGenerationThread.run(MazeFrame.java: 275)

[Norm]

java.lang.ArrayIndexOutOfBoundsException: 10
at StudentMazeGenerator.generatePath(StudentMazeGener ator.java:39)

Look at the code at line 39. The value of the index in the array used on that line is 10 but the array does not have 11 elements. Check your logic to see how the index got past the end of the array.

Add some printlns to show the index values as the code executes if you need to see when the indexes go bad.

[evelina1]

So i made some changes..since i had my width and height mixed up in some places but i still get out of bound exception.

public class StudentMazeGenerator
implements MazeGenerator
{
	private static final int h2 = 0;
	private static final int w2 = 0;
	private boolean[][] currMazeLoc;
	private boolean visited;
	//private Object randomNumInt;
	int[] listArray = {0,1,2,3};



	public  Maze generateMaze(int width, int height, MazeGeneratorListener listener)
	{
		Maze mazeFactory = MazeFactory.createMaze(width, height);

		currMazeLoc = new boolean[width][height]; 
		generatePath(mazeFactory, width, height, listener);

		return mazeFactory;
	}

	public void generatePath(Maze maze, int currX, int currY, MazeGeneratorListener  listener)
	{
		//	int[] listArray = new int[] {0,1,2,3};
		currMazeLoc[currX][currY] = visited;
		listener.mazeModified(maze);
		while(!unCheckedCell(currX, currY))
		{
			Random random = new Random();
			int temp = random.nextInt();
			if(temp == 0 && currY != 0)
			{
				//check inside each of them to make sure ur not goin out of bound
				//ur at the end of the maze and u want to go east there is no more room...u get arrayindexoutofboundException
				if(!(currMazeLoc[currX][currY-1]))
				{
					maze.removeWallNorthOf(currX, currY); 
					//h--;  
					listener.mazeModified(maze);
					generatePath(maze, currX, currY-1 ,listener);  
				}  
			}  
			if(temp == 1 && currY != 9)  
			{   
				//if ur on south u can go as far 9 so u need to check ur y coordinate to make sure ur not going more than the size.
				if(!currMazeLoc[currX][currY+1]) 
				{  
					maze.removeWallSouthOf(currX, currY);  
					//h++;  
					listener.mazeModified(maze);
					generatePath(maze, currX, currY+1 ,listener);  
				}

			}  
			if(temp == 2 && currX != 9)  
			{    
				if(!currMazeLoc[currX+1][currY])  
				{  
					maze.removeWallEastOf(currX, currY);  
					//h++;  
					listener.mazeModified(maze);
					generatePath(maze, currX+1, currY ,listener);    
				}  
			}  
			if(temp == 3 && currX != 0)  
			{  
				if(!currMazeLoc[currX-1][currY])  
				{  
					maze.removeWallWestOf(currX,currY); 
					//h--;  
					listener.mazeModified(maze);
					generatePath(maze, currX-1, currY ,listener);    
				}  
			}        
			return;  	
		}
	}
	//intArray.length-1;
	//int temp = listArray[i]
	//create an array of the (0 to 3) for N, S , E, W
	//create a method that shuffles the array N, E, S, W
	public void shuffle()
	{
		Random random = new Random();
		int[] listArray = new int[] {0,1,2,3};
		for (int i=0; i<listArray.length; i++)
		{
			int randomNum = random.nextInt(listArray.length -1);
			int temp = listArray[i];
		}
	}

	public boolean unCheckedCell(int w1, int h1) {
		if (( w1 == 0) && (h1 == 0))
			return (currMazeLoc[w1+1][h1] && currMazeLoc[w1][h1+1]);

		else if((w1 == (w2 - 1)) && (h1 == (h2 - 1)))  
			return (currMazeLoc[w1-1][h1] && currMazeLoc[w1][h1-1]); 

		else if((w1 == 0) && (h1 == (h2 - 1)))
			return (currMazeLoc[w1][h1-1] && currMazeLoc[w1+1][h1]); 

		else if (w1 == (w2 - 1) && (h1 == 0))
			return (currMazeLoc[w1 -1][h1] && currMazeLoc[w1] [h1 +1]);

		else
			return (currMazeLoc[w1+1][h1] && currMazeLoc[w1][h1+1] && currMazeLoc[w1-1][h1] && currMazeLoc[w1][h1-1]); 
		//return false;
	}	       

	public int nextInt(int n)  
	{  
		return (int)(Math.random()*n); 
	}  

}

error i get:

Exception in thread "Thread-3" java.lang.ArrayIndexOutOfBoundsException: 10
at StudentMazeGenerator.generatePath(StudentMazeGener ator.java:39)
at StudentMazeGenerator.generateMaze(StudentMazeGener ator.java:31)
at MazeFrame$MazeGenerationThread.run(MazeFrame.java: 275)

[Norm]

Did you add printlns to show the indexes used on line 39?
The print out could help you fix your problem.

[evelina1]

do i add that after the line 39...where do i have to do printlns?

[Norm]

You need to print the values out BEFORE they cause the exception so you can see them.