Reversing an array

im getting incorrect output in my code of reversing an array,plz help

Code:

---

import java.util.*;
class a
{
public static void main(String args[])
{
int i,temp;
int []a=new int[5];
Scanner sc=new Scanner(System.in);
System.out.println("Enter the elements of the first array");
for(i=0;i<5;i++)
{
a[i]=sc.nextInt();
}
for(i=0;i<2;i++)
{
temp=a[i];
a[i]=a[4-i];
a[4-i]=temp;
}
System.out.println("The reversed array is:");
System.out.println(a[i]);
}
}

---

Quote:

---

im getting incorrect output in my code

---

Can you show us what you are getting?

Please wrap you code in code tags to preserver its formatting. Use the # icon above to right of input area.

Your code is hardcoded to only work for 5 elements.
What would you have to do to make it work for 8 elements or 50 elements?

if im entering the input as
1
2
3
4
5
im getting 3 as the output ie im getting a[2] as the output

Quote:

---

Originally Posted by Norm

Your code is hardcoded to only work for 5 elements.
What would you have to do to make it work for 8 elements or 50 elements?

---

then how to make it generic,will int []a=new int[]; work?

Quote:

---

to make it generic

---

To generate an array to sort you'll have to specify its size:
int[] anArray = new int[333];
The code to reverse the array should get anArray as an argument and use the anArray.length property to get its size.

See the Arrays class toString() method as an easy way to print the contents of an array.

Cross posted at Reversing an array

so whats the bug in my code?i think the logic is rite

Re-posting your code in code tags will encourage me to read it. Without it I don't really feel like deciphering your scribbles.

Quote:

---

Originally Posted by Dark

Re-posting your code in code tags will encourage me to read it. Without it I don't really feel like deciphering your scribbles.

---

sorry,done

Well when I said putting it in code tags, you have to put the formatted code in there otherwise it will still look exactly like it did before. Just in a blue box.

However, I took a look at it anyways. Honestly I have no idea what you are doing.

Code:

---

for(i=0;i<2;i++)
                {
                        temp=a[i];
                        a[i]=a[4-i];
                        a[4-i]=temp;
                }

---

This seems way to complicated for what you are trying to accomplish. And you're only getting one input because this line of code is outside of a loop, so it will only run once.

Code:

---

System.out.println("The reversed array is:");
System.out.println(a[i]);

---

My advice is that once you created your original array, you just loop through it backwards. Instead of using more variables to try and find which slot you should be fetching information from.

For loops don't have to start at 0 and go up, you can set them to the length of your array and work down.

thnx,i got it