bar chart painting problem

[mitttig]

I am doing a project but i encountered a problem i need some help with it.

The code i made is supposed to draw a bar chart. But somehow it doesn't paint something.
I have been looking on it for a while now but i don't get it.

    public void graphicSD(String reportName)
    {
        try
        {
            graphicFrame = new JFrame();

            graphicFrame.setTitle(reportName);

            graphicFrame.setSize(800, 600);
            graphicFrame.setLayout(new FlowLayout());

            Object[][] data = CM.getReportQueryData(reportName);
            System.out.println(data);

            BarGraph barGraph = new BarGraph(data);
            JPanel barGraphContainer = new JPanel();
            barGraphContainer.setSize(300,300);
            barGraphContainer.add(barGraph);

            graphicCancel = new JButton("Annuleren");
            graphicFrame.add(graphicCancel);
            graphicCancel.addActionListener(this);

            JPanel buttonPanel = new JPanel();
            buttonPanel.add(graphicCancel);

            graphicFrame.add(barGraphContainer);
            graphicFrame.add(buttonPanel);
            graphicFrame.setVisible(true);
        }
        catch (ConnectException ex)
        {
            JOptionPane.showMessageDialog(this,
            "Server is not available at this time.",
            "Inane error",
            JOptionPane.ERROR_MESSAGE);
        }
    }


   
    }
}

this part makes a nice begin screen with a button(ShowStaafDiagram) and some stuff more that is a bit hard to describe here.
When you click the button(ShowStaafDiagram) it goes through the ActionListener and after that to the method GraphicSD. When in graphicSD it makes another screen with a cancel button and there goes the bar chart code.

public class BarGraph extends JPanel
{
  private Object[][] data;

    public BarGraph(Object[][] data)
  {
    this.data = data;

  }

  @Override
  public void paintComponent(Graphics g)
  {
    super.paintComponent(g);

//from here on it's mostly getting the scaling for bar chart

    if (data == null || data.length == 0)
      return;
    double minValue = 0;
    double maxValue = 0;
    System.out.println(minValue);
    for (int i = 0; i < data.length; i++)
    {
      if (minValue > ((BigDecimal)data[i][1]).doubleValue())
          System.out.println(data[i][1]);
       minValue = ((BigDecimal)data[i][1]).doubleValue();
      if (maxValue < ((BigDecimal)data[i][1]).doubleValue())
          System.out.println(data[i][1]);
        maxValue = ((BigDecimal)data[i][1]).doubleValue();
    }

    Dimension d = getSize();
    int clientWidth = d.width;
    int clientHeight = d.height;
    int barWidth = clientWidth / data.length;

    Font titleFont = new Font("SansSerif", Font.BOLD, 20);
    FontMetrics titleFontMetrics = g.getFontMetrics(titleFont);
    Font labelFont = new Font("SansSerif", Font.PLAIN, 10);
    FontMetrics labelFontMetrics = g.getFontMetrics(labelFont);

    int titleWidth = titleFontMetrics.stringWidth(title);
    int y = titleFontMetrics.getAscent();
    int x = (clientWidth - titleWidth) / 2;
    g.setFont(titleFont);


    int top = titleFontMetrics.getHeight();
    int bottom = labelFontMetrics.getHeight();
    if (maxValue == minValue)
      return;
    double scale = (clientHeight - top - bottom) / (maxValue - minValue);
    y = clientHeight - labelFontMetrics.getDescent();
    g.setFont(labelFont);

   //It's actually getting painted here. So i guess here is the main problem
    for (int i = 0; i < data.length; i++)
    {
      int valueX = i * barWidth + 1;
      int valueY = y;
      int height = (int) (((BigDecimal)data[i][1]).doubleValue() * scale);
      if (((BigDecimal)data[i][1]).doubleValue() >= 0)
        valueY += (int) ((maxValue - ((BigDecimal)data[i][1]).doubleValue()) * scale);
      else
      {
        valueY += (int) (maxValue * scale);
        height = -height;
      }

      g.setColor(Color.green);
      g.drawRect(valueX, valueY, barWidth - 2, height);
      g.setColor(Color.black);
      g.fillRect(valueX, valueY, barWidth - 2, height);
      int labelWidth = labelFontMetrics.stringWidth((String)data[i][0]);
      x = i * barWidth + (barWidth - labelWidth) / 2;
      g.drawString((String)data[i][1], x, y);
    }
  }

}

http://imageshack.us/photo/my-images/543/screen2ypi.jpg

now i don't know where it goes wrong? any ideas here from the people who know how to program?

[KevinWorkman]

That's almost definitely way too much code for anybody to wade through. We have hundreds of posts here, so we don't have time to do a ton of debugging for you. If you boil your problem down to an SSCCE that demonstrates the problem in as few lines as possible, we can go from there.

[Norm]

Are the methods being called as you expect? Are the values correct when the methods are called?

Add some printlns to show that the methods are being called and that the values are correct.

[Norm]

Are the methods being called as you expect? Are the values correct when the methods are called?

Add some printlns to show that the methods are being called and that the values are correct.

[mitttig]

i'm trying to debug as much as possible. In the second part aren't any println's coming out. If i'm thinking out loudly my guess is something with the container(BarGraphContainer first part). I do not completely understand how it works.

[Norm]

In the second part aren't any println's coming out.

If there are no printlns then the code isn't being executed. Can you back track and find out why?

For example your posted code does not do a println to show if the paintComponent method is called.

[camickr]

When you do custom painting you are responsible for overriding the getPreferredSize() method to return the size of your panel so the layout manager can layout your panel properly. Add a LineBorder to your panel and I'm sure you will just see a small square indicating that even if the painting is done there will be nothing to display.

[mitttig]

When you do custom painting you are responsible for overriding the getPreferredSize() method to return the size of your panel so the layout manager can layout your panel properly. Add a LineBorder to your panel and I'm sure you will just see a small square indicating that even if the painting is done there will be nothing to display.

You are indeed right about the small square. but what i don't get is how to fix it?
I'm remembering that i saw some chinese looking letters in that spot.

i have an override just before the paintComponent

[Norm]

how to fix it?

Add the following method to the panel class

    
    @Override
    public Dimension getPreferredSize() {    //<<<<<<<<<<<<<< NEED THIS
      return ourSize;
    }

Define a Dimension ourSize to desired size.