Renaming a file

[sunde887]

I'm having some trouble renaming a file. Seems simple enough, close stream, then use file1.renameTo(file1), but I'm getting consistent failures. Perhaps it's something small but I just can't quite figure this one out.

Here is the relevant code, the goal is to open a file, read a line, convert it, and write a changed line.

import java.io.*;

public class EncryptFile{
	private final Encryption encryptScheme;
	private final File file;
	
	public EncryptFile(Encryption encryptScheme, File file){
		this.encryptScheme = encryptScheme;
		this.file = file;
	}
	
	public boolean encryptFile(){
		File temp = new File("temp.txt");
		FileReader fr = null;
		FileWriter fw = null;
		BufferedReader br = null;
		PrintWriter pw = null;
		int count = 0;
		try{
			fr = new FileReader(file);
			br = new BufferedReader(fr);
			fw = new FileWriter(temp);
			pw = new PrintWriter(fw);
			
			String line;
			while((line = br.readLine()) != null){
				if(count == 0){
					if(line.equals("Encrypted using " + encryptScheme.toString()))
						throw new IllegalStateException("File already encrypted");
					count++;
					pw.println("Encrypted using " + encryptScheme.toString());
				}
				line = encryptScheme.encrypt(line);
				pw.println(line);
			}
		} catch(FileNotFoundException fnfe){
			fnfe.printStackTrace();
		} catch(IOException ioe){
			ioe.printStackTrace();
		} finally{
			try{
				if(fr != null)
					fr.close();
				if(fw != null)
					fw.close();
			} catch(IOException ioe){
				ioe.printStackTrace();
			}
		}
		if(!temp.renameTo(file)){
			System.out.println("Failed rename");
			return false;
		}
		if(!file.delete()){
			System.out.println("Failed deletion");
			return false;
		}
		return true;
	}
	public boolean decryptFile(){return true;}
	
	public static void main(String[] args){
		/*
		if(args.length != 2)
			System.out.println("Proper usage is: \"java EncryptFile [flags] file\"");
		*/
		File file = new File("test.txt");
		EncryptFile ef = new EncryptFile(new CaesarCipher(13), file);
		ef.encryptFile();
	}
}

I get no errors, it simply reports "Failed rename" every time. I believe the streams are closed properly because when I switch around the rename and delete if blocks, the delete occurs.

[sunde887]

Ugh, switching around the blocks now works as expected. Thread solved, I apologize, feel free to delete if necessary, however; if you leave it for others in the future, the solution seems to be deleting the file, than renaming it. Perhaps before the file was deleted it was still open on the os?

[JosAH]

Ugh, switching around the blocks now works as expected. Thread solved, I apologize, feel free to delete if necessary, however; if you leave it for others in the future, the solution seems to be deleting the file, than renaming it. Perhaps before the file was deleted it was still open on the os?

Suppose you have two files, A and B, you can't rename A to B if a B already exists; first you have to delete B before you can rename A to B.

kind regards,

Jos

[sunde887]

Abu, makes sense, thanks Jos!

[JosAH]

Abu, makes sense, thanks Jos!

You're welcome of course; please set the thread to 'solved' (he said as a moderator ;-)

kind regards,

Jos

[sunde887]

Abu should be ahh, damn autocorrect. Is there a way to make threads solved still?

[JosAH]

Abu should be ahh, damn autocorrect. Is there a way to make threads solved still?

I guess so, you're the thread starter so there should be an option 'thread tools' (or similar) near the top of this page ... b.t.w. what on earth 'autocorrects' ahh to abu?

kind regards,

Jos

[Toll]

Since the forum migration, I haven't been able to mark either of my two threads as solved, to be honest. Nor do I see any solved threads anymore, so I think that function is AWOL at the moment...

[JosAH]

Since the forum migration, I haven't been able to mark either of my two threads as solved, to be honest. Nor do I see any solved threads anymore, so I think that function is AWOL at the moment...

I'll go and ask; recue is on its way! Fear not!

kind regards,

Jos ;-)

[JosAH]

I'll go and ask; recue is on its way! Fear not!

I asked the forum gods and their answer is: unfortunately no, this feature is not present in the new release of the forum software. Oh well ...

kind regards,

Jos