Java program error

[Taszk]

i want to use at least 2 methods

i want to write a program that inputs 3 integers, which are sides of a triangle
and determines the type of triangle it is:

isosceles
equilateral
scalene
not valid sides of a triangle

If it is a valid triangle print the type of triangle it is, its area and perimeter.
the program will then repeat for another set of sides, until a 0 is entered for the 1st side of the triangle (the other 2 sides should not be read in for this case)

This is what i got so far:

import java.util.*;
public class BookExample{
	public static void main(String[] args)
		{int a, b, c, p;
			System.out.println("Enter the length of side \"a\" of the triangle to begin:");
			Scanner in=new Scanner(System.in);
			a=in.nextInt();			
			
	if(a==0)
		System.exit(0);
		
			b=in.nextInt();
			c=in.nextInt();
			
	getTriType();
	getArea();
	p = a+b+c;
		}
	
public static void getTriType()
	{if(a==0||b==0||c==0||a<0||b<0||c<0||a+b>=c||b+c>=a||a+c>=b)
		{System.out.println("According to the given sides these are invalid sides of a Triangle");
		}
	else if(a==b&&a==c&&b==c)
		{System.out.print("According to the given sides, since a,b and c are equal ");
		 System.out.print("the triangle is an Equilateral triangle.");
		}
	else if(a==b||a==c||b==a||b==c||c==a||c==b)
		{System.out.print("According to the given sides, since two sides are equal ");
		 System.out.print("the triangle is an Isosceles triangle.");
		}
	else
		{System.out.print("According to the given sides, since a,b and c are not equal ");
		 System.out.print("the triangle is a Scalene triangle.");
		}
	}
	
public static double getArea(int a,int b,int c)
	{double s = 0.5 * (a + b + c);
	 double area = Math.sqrt(s*(s-a)*(s-b)*(s-c));
	}
}

I know i'm still missing to output the area and perimeter but i'm trying to get rid of my error(s) first. My first error is "BookExample.java:16: getArea(int,int,int) in BookExample cannot be applied to ()" i know what it has to do with i just can't figure out how to fix the problem. Thanks for the help.

[Junky]

i know what it has to do with i just can't figure out how to fix the problem.

That statement is contradictory. If you know what is has to do then you know how to fix it. How many parameters does the getArea method want? How many parameters are you passing to it?

[airowe]

My first error is "BookExample.java:16: getArea(int,int,int) in BookExample cannot be applied to ()" i know what it has to do with i just can't figure out how to fix the problem. Thanks for the help.

You need to make the parameters of the function definition the same as the parameters in the function call within your main.

getArea(); is not the same as

public static double getArea(int a, int b, int c)

when you call getArea from main, make sure you include the values that you inputted from the console.

[Taszk]

You need to make the parameters of the function definition the same as the parameters in the function call within your main.

getArea(); is not the same as

public static double getArea(int a, int b, int c)

when you call getArea from main, make sure you include the values that you inputted from the console.

so what your saying is when i call getArea from main i would need to call it as is getArea(int a,int b,int c); ?

[airowe]

so what your saying is when i call getArea from main i would need to call it as is getArea(int a,int b,int c); ?

Yep. Your function call needs to match some function definition, somewhere.

In this problem, you want to pass the values that you received from the console (Your user) to the getArea() function so you can calculate the area of the user's triangle.

[Junky]

so what your saying is when i call getArea from main i would need to call it as is getArea(int a,int b,int c); ?

You could try, although you would get a different error message. The compiler already knows what types your variables are, no need to tell it again.

[Taszk]

Thanks. I knew more errors were going to follow up right behind that one. Now i'm getting something like "BookExample.java:16: '.class' expected
getArea(int a,int b,int c);"

[Junky]

/me predicts the future.

[Taszk]

You could try, although you would get a different error message. The compiler already knows what types your variables are, no need to tell it again.

I see what your talking about i changed it and just called the variables instead and did the same to my other function which began getting an error that said something like 'can't find a' etc...(a,b,c); now my error is completely different.

import java.util.*;
public class BookExample{
	public static void main(String[] args)
		{int a, b, c, p;
			System.out.println("Enter the length of side \"a\" of the triangle to begin:");
			Scanner in=new Scanner(System.in);
			a=in.nextInt();			
			
	if(a==0)
		System.exit(0);
		
			b=in.nextInt();
			c=in.nextInt();
			
	getTriType(a,b,c);
	getArea(a,b,c);
	p = a+b+c;
		}
	
public static void getTriType(int a, int b, int c)
	{if(a==0||b==0||c==0||a<0||b<0||c<0||a+b>=c||b+c>=a||a+c>=b)
		{System.out.println("According to the given sides these are invalid sides of a Triangle");
		}
	else if(a==b&&a==c&&b==c)
		{System.out.print("According to the given sides, since a,b and c are equal ");
		 System.out.print("the triangle is an Equilateral triangle.");
		}
	else if(a==b||a==c||b==a||b==c||c==a||c==b)
		{System.out.print("According to the given sides, since two sides are equal ");
		 System.out.print("the triangle is an Isosceles triangle.");
		}
	else
		{System.out.print("According to the given sides, since a,b and c are not equal ");
		 System.out.print("the triangle is a Scalene triangle.");
		}
	}
	
public static double getArea(int a,int b,int c)
	{double s = 0.5 * (a + b + c);
	 double area = Math.sqrt(s*(s-a)*(s-b)*(s-c));
	}
}

my new error is "BookExample.java:41: missing return statement
}
^"

[Taszk]

/me predicts the future.

Lol. Well i did mention above that after that error i'm pretty sure there was going to be more.

[airowe]

my new error is "BookExample.java:41: missing return statement

What method do you have written that needs a return statement?

[Junky]

What does that error message suggest to you? I think it is telling you that there is supposed to be a return statement but it is missing. Do you have any methods that SHOULD have a return statement but DON'T?

[Taszk]

Being that i'm new to java i'm actually lost right now.

[Junky]

public static double getArea(int a,int b,int c)

This is your getArea method. It's return type is double. This means you are promising that the method will return a double. Are you?

[Taszk]

public static double getArea(int a,int b,int c)

This is your getArea method. It's return type is double. This means you are promising that the method will return a double. Are you?

no. I have a question being that in that method i have s and area as a type double does it matter if i change the type double to void?

Edit:

public static void getArea(int a,int b,int c)

[airowe]

The method is named "getArea". You don't want to change it to void or it won't "get" anything.

You want that method to return a value of type double which is the area of the triangle.

Returning a Value from a Method (The Java™ Tutorials > Learning the Java Language > Classes and Objects)

[Taszk]

The method is named "getArea". You don't want to change it to void or it won't "get" anything.

You want that method to return a value of type double which is the area of the triangle.

Returning a Value from a Method (The Java™ Tutorials > Learning the Java Language > Classes and Objects)

Thanks a lot to the both of you i got the errors out the way now to try and finish it up. Hopefully i won't run into anymore mistakes but if i do i hope i could comeback.