array index out of bounds exception, AGAIN!

[samanyu]

I am using this code, somewhere in the middle of a huge program.

 else if(ev.getSource() == okButton1){ 
        if(a<neigh1.s)a++;
for( int i=0; i<(810/30); i++) {
            for( int j=0; j<(630/30); j++) {
                rules[a-1][i][j]=exch3.rulbas[i][j];}}}

And I am getting an out_of_bounds exception. Is this command allowed? Where could my array possibly be going awry?
I have initialized them as follows:

public static int a=0;
    public rule2 exch3;
    public static int rules[][][]= new int[neigh1.s][810/30][630/30];

and

class rule2   implements Serializable {
      public int rulbas[][];....etc

[DarrylBurke]

1. Learn to not use magic numvbers.

for( int i = 0; i < rules[a-1].length; i++) {
    for( int j = 0; j < rules[a-1][i].length; j++) {
           rules[a-1][i][j] = exch3.rulbas[i][j];
    }
}

2. Learn how to format code for readability: Code Conventions for the Java(TM) Programming Language: Contents

db

[DarrylBurke]

Is this command allowed?

Java has statements. Not commands.

db

[samanyu]

Okay. Well I didn't use magic numbers in the statement, simply replaced the variable with the value it contained for better understanding.
And the code fragment didn't work, obviously, since one variable was simply replaced with another. I am asking if there is some hierarchical issues I haven't thought about.
Also is there a simpler way of putting the values of many 2D matrices into a 3D matrix?

[kjkrum]

Well I didn't use magic numbers in the statement, simply replaced the variable with the value it contained for better understanding.

That creates a worse understanding. Nobody can tell where those values might have come from, or what they might represent. Giving every variable a meaningful name will actually help you avoid errors like this.

[samanyu]

OK. i apologise. Is the code inside the nested for loops correct? Can I do that?

[Norm]

Can I do that?

The code appears to be copying the value from one array to another. Yes you can do that if ....
both arrays are defined with the correct number of dimensions
indexes are in bounds
types of the two arrays are compatible

[samanyu]

OK. I'll work on the indexes and get back to you.

[samanyu]

Yes, I solved the problem using a print option after every step, I saw where I was going wrong. Thanks to DarrylBurke and Norm. Cheers.