Can't get the variable's value

[jaylimix]

import java.util.Scanner;
import java.math.*;

public class Q1 {

    public static void main(String[] args) {

    	int sum=0;

    	System.out.println("Enter the scores(negative number to end)");

    	for(int i=1;i<10;i++){

		System.out.print("Score "+i+": ");

		int[] number= new int[10];

		Scanner input= new Scanner(System.in);

    	number[i]= input.nextInt();

		sum+= number[i];

		if(number[i]<0){

			break;
		}

		int average= sum/2;

		if(number[i]>=average){

			int above=0;

			++above;
		}

		else{

			int below=0;

			++below;
		}
    	}

    	System.out.printf("Results\n------\n");
    	System.out.println("Average is "+ average);
    	System.out.println("Number of scores above or equal to average is "+ above);
    	System.out.println("Number of scores below average is "+ below);
    }


}

Hi all, I can't figure out how can I get the values of average, above and below, I mean I can't include it inside the for loop.

[Norm]

You need to consider the scope of the variables' definitions. A variable is only known within the {} that enclose its definition. Outside of the enclosing {} it is not known. Read about "scope" for more info.

Basically move the definitions of the variables to the same level as where you are trying to reference them.

For example sum is at the highest level in main(). The others are within a for loop.

[jaylimix]

Hi thanks, I can't believe how easy it is to solve it yet I can't think of it. All I did was change the position of the variable. I'm still having a problem though, below is my output:

Enter the scores(negative number to end)
Score 1: 5
Score 2: 6
Score 3: 4
Score 4: 6
Score 5: 2
Score 6: 3
Score 7: 8
Score 8: -1
Results
------
Average is 17
Number of scores above or equal to average is 2
Number of scores below average is 5

[Norm]

I'm still having a problem though

please explain what it is

[jaylimix]

The output should be:

Average is 17
Number of scores above or equal to average is 0
Number of scores below average is 7

Because non of the scores are above or equal to average(17) but all of the scores are below the average(17).

[Norm]

You need to post your new code after you made the fixes for the first problem.

Try debugging your code by adding printlns to show variable values as the code is executed. For example add one before an if test to show the values of the two variables that are being compared.

[jaylimix]

import java.util.Scanner;
import java.math.*;

public class Q1 {

    public static void main(String[] args) {

    	int average=0;

    	int above=0;

    	int below=0;

    	int sum=0;

    	System.out.println("Enter the scores(negative number to end)");

    	for(int i=1;i<10;i++){

		System.out.print("Score "+i+": ");

		int[] number= new int[10];

		Scanner input= new Scanner(System.in);

    	number[i]= input.nextInt();

		sum+= number[i];

		if(number[i]<0){

			break;
		}

		average= sum/2;

    	}

    	if(number[i]>=average){

			++above;
		}

		else{

			++below;
		}

    	System.out.printf("Results\n------\n");
    	System.out.println("Average is "+ average);
    	System.out.println("Number of scores above or equal to average is "+ above);
    	System.out.println("Number of scores below average is "+ below);
    }


}

This is my current code with the outputs:


Enter the scores(negative number to end)
Score 1: 5
Score 2: 6
Score 3: 9
Score 4: 1
Score 5: 2
Score 6: 3
Score 7: -1
Results
------
Average is 13
Number of scores above or equal to average is 2
Number of scores below average is 4

[jaylimix]

import java.util.Scanner;
import java.math.*;

public class Q1 {

    public static void main(String[] args) {

    	int average=0;

    	int above=0;

    	int below=0;

    	int sum=0;

    	System.out.println("Enter the scores(negative number to end)");

    	for(int i=1;i<10;i++){

		System.out.print("Score "+i+": ");

		int[] number= new int[10];

		Scanner input= new Scanner(System.in);

    	number[i]= input.nextInt();

		sum+= number[i];

		if(number[i]<0){

			break;
		}

		average= sum/2;

    	}

    	if(number[i]>=average){

			++above;
		}

		else{

			++below;
		}

    	System.out.printf("Results\n------\n");
    	System.out.println("Average is "+ average);
    	System.out.println("Number of scores above or equal to average is "+ above);
    	System.out.println("Number of scores below average is "+ below);
    }


}

This is my current code with the outputs:


Enter the scores(negative number to end)
Score 1: 5
Score 2: 6
Score 3: 9
Score 4: 1
Score 5: 2
Score 6: 3
Score 7: -1
Results
------
Average is 13
Number of scores above or equal to average is 2
Number of scores below average is 4

[Norm]

Try debugging your code by adding printlns to show variable values as the code is executed. For example add one before an if test to show the values of the two variables that are being compared.

Play computer with your program. Do the statements one by one and write down the results of each statement on a piece of paper as you go thru the program. You should be able to see where your logic problem is.

[Tolls]

You are comparing each score as it is entered against the average up to that point.

Print out the value of average as you go through the loop to see what I mean.
In addition, that is not the average of those scores...

[JosAH]

Enter the scores(negative number to end)
Score 1: 5
Score 2: 6
Score 3: 9
Score 4: 1
Score 5: 2
Score 6: 3
Score 7: -1
Results
------
Average is 13
Number of scores above or equal to average is 2an
Number of scores below average is 4

How can the average be 13 while all of the numbers are less than 13? There must be an error in the computation of the average.

kind regards,

Jos

[jaylimix]

Ya I made a mistake in this computation -> average= sum/2;

Now I'm trying to figure out what to replace the 2. It needs to be sum of scores divide by the number of scores.

[Norm]

It needs to be sum of scores divide by the number of scores.

That means you must do it in two steps. First step: sum the numbers, second step divide

[JosAH]

That means you must do it in two steps. First step: sum the numbers, second step divide

And only then comes step 3: find the numbers that are lower/higher than the average (calculated in step two). Doing those elementary steps greatly simplifies your loops, i.e. you don't have to try to cram everything in one big loop.

kind regards,

Jos

[yellowledbet]

Ya I made a mistake in this computation -> average= sum/2;

Now I'm trying to figure out what to replace the 2. It needs to be sum of scores divide by the number of scores.

So you need a variable to count how many scores are entered. Increment it each time a score is entered.

[goldest]

So you need a variable to count how many scores are entered. Increment it each time a score is entered.

Instead [if used correctly] the for loop initiator variable "i" can be used to calculate the average.

Goldest

[jaylimix]

Output:

Enter the scores(negative number to end)
Score 1: 1
Score 2: 2
Score 3: 3
Score 4: -1
Results
------
Average is 2
Number of scores above or equal to average is 3
Number of scores below average is 0

I got my average correct now but my above and below are still wrong.

import java.util.Scanner;
import java.math.*;

public class Q1 {

    public static void main(String[] args) {

    	int average=0;

    	int above=0;

    	int below=0;

    	int sum=0;

    	int j=0;

    	System.out.println("Enter the scores(negative number to end)");

		int[] number= new int[10];

    	for(int i=1;i<number.length;i++){

		System.out.print("Score "+i+": ");

		Scanner input= new Scanner(System.in);

    	number[i]= input.nextInt();

		sum+= number[i];

		++j;

		if(number[i]<0){

			break;
		}

		average= sum/j;

    	if(number[i]>=average){

			++above;
		}

		else{

			++below;
		}

    	}

    	System.out.printf("Results\n------\n");
    	System.out.println("Average is "+ average);
    	System.out.println("Number of scores above or equal to average is "+ above);
    	System.out.println("Number of scores below average is "+ below);
    }


}

[JosAH]

You did cram everything in one big, complicated loop; try to execute it by hand and see how the value of variable average changes and influences the outcome of variables above and below. Do those calculations afterwards when the value of variable average is known.

kind regards,

Jos

[jaylimix]

Okay I've separated it into 2 for loops but I'm still having problem with the out put:

Enter the scores(negative number to end)
Score 1: 1
Score 2: 2
Score 3: 3
Score 4: -1
Results
------
Average is 2.0
Number of scores above or equal to average is 1 // this should be 2
Number of scores below average is 2 // this should be 1

import java.util.Scanner;
import java.math.*;

public class Q1 {

    public static void main(String[] args) {

    	double average=0;

    	int above=0;

    	int below=0;

    	double sum=0;

    	int numberOfScore=0;

    	Scanner input= new Scanner(System.in);

    	System.out.println("Enter the scores(negative number to end)");

		int[] number= new int[10];

    	for(int i=1;i<number.length;i++){

		System.out.print("Score "+i+": ");

    	number[i]= input.nextInt();

    	if(number[i]<0){

			break;
		}

		else{

		sum+= number[i];

		++numberOfScore;

    	average=sum/numberOfScore;

		}
    	}

    	for(int i=0;i<numberOfScore;i++){

     	if(number[i]>=average){

    		++above;
    	}

    	else{

    		++below;
    	}
    	}

    	System.out.printf("Results\n------\n");
    	System.out.println("Average is "+ average);
    	System.out.println("Number of scores above or equal to average is "+ above);
    	System.out.println("Number of scores below average is "+ below);
    }


}

[Norm]

Add some printlns to show what numbers are being considered above the average and what are below the average.
For example add this for the above if test:
System.out.println("above=" + number[i] +", average=" + average);

The output will show you how your if tests are working

If that doesn't show what is happening, keep adding printlns to show ALL the numbers you are working with.
That is what I had to do to find the bugs in your code.
Keep adding printlns until you see what is wrong.