OnClick inside a loop

[sehudson]

I am doing some Android programming, and I had a question about onClickListeners (android is done in Java).


I am dynamically creating table rows as I walk down Cursor results of an SQL query and adding them to the table. Right before I add the table to the row, I am trying to set a listener for EACH row, and the action will be based on the row. The problem is that when the action is triggered, 'rowCount' keeps evaluating to the total # of Rows, instead of what it was at the time I created the Listener. Any way to get this to work?

while(values.moveToNext()){
    	 System.out.println("On Row "+RowCount);
    	 trA[RowCount] = new TableRow(this);             

              trA[RowCount].setId(RowCount);
              
              
              trA[RowCount].setOnClickListener(
                      new OnClickListener() {
                          @Override
                          public void onClick(View v) {
                        	 // SetValues(trA[RowCount].getId());
                          
                          }
                          

              });

              //Add the Row to the table
              tl.addView(trA[RowCount]);
              RowCount++;
     }

[Norm]

'rowCount' keeps evaluating to the total # of Rows, instead of what it was at the time I created the Listener

Sounds like you're not reseting the value. What shows when the println is printed on entry to the loop?

[sehudson]

I switched it around a little bit. I set currentRow to-1 right before the loop, and do the increment as soon as I enter the loop. There are 6 rows in the table(cursor results) so I get

On Row 0
On Row 1
On Row 2
On Row 3
On Row 4
On Row 5

I think the issue is the listener. I guess when the code reaches the setOnClickListener, it doesn't actually do anything, other than recognize that a listener is created? So after the table is created, I click on a row, and the listener is activated, but the code inside the listener references 'currentRow', but I was hoping that the 'currentRow' it used was the 'currentRow' at the time I 'declare' the listener, but apparently not because when I click the row, the currentRow value it uses is 5, no matter which row I click on.

So it looks like this

currentRow=-1;
while(values.moveToNext()){
currentRow++;
    	 System.out.println("On Row "+currentRow);
    	 trA[currentRow] = new TableRow(this);             

              trA[currentRow].setId(currentRow);
              
              
              trA[currentRow].setOnClickListener(
                      new OnClickListener() {
                          @Override
                          public void onClick(View v) {
                        	 // SetValues(trA[currentRow].getId());
                          
                          }
                          

              });

              //Add the Row to the table
              tl.addView(trA[currentRow]);
     }

[Norm]

at the time I 'declare' the listener

Do you mean at the time you create an instance of the listener?
You could pass the current value of the variable to the listener when you create the listener.

Or when you add the listener to the component that has the actions listened for?
Add a method to the listener to call to pass the value of the variable at that time.

[sehudson]

I think I see what you are saying, you mean in the 'guts' of the listener?

This portion,

              trA[currentRow].setOnClickListener(
                      new OnClickListener() {
                          @Override
                          public void onClick(View v) {
                        	//logic here?????
                          
                          }
                          

              });

I don't think that part gets evaluated until the event actually occurs.

[Norm]

I gave two options, which are you referring to?

I don't think that part gets evaluated until the event actually occurs.

Instead of using an anonymous class, create one that you can pass args to its constructor

Or perhaps you could add a line in what your have: ???

 trA[currentRow].setOnClickListener(
                      new OnClickListener() {
                           final int SavedRowCnt = currentRow;  // Save current value
                          @Override
                          public void onClick(View v) {
                        	//logic here?????
                          
                          }
                          

              });

[sehudson]

can you show an example of your 1st suggestion, I'm not sure what you mean.

"Instead of using an anonymous class, create one that you can pass args to its constructor"

[Norm]

I meant to say: define a new class that is a listener with a constructor that you can pass the values to the object.
Something like:

class MyListener extends listener {
  MyListener(int valueToSave) {
    this.valueToSave = valueToSave;  // save value locally

[sehudson]

I created a class called MyListener

public class MyListener implements OnClickListener {
	private int rowID;

	public MyListener(int valueToSave) {
	    this.rowID = valueToSave;  // save value locally	    
	    
	    System.out.println("*** Row"+valueToSave);
	    
	  }

	@Override
	public void onClick(View v) {
		// TODO Auto-generated method stub
		
	}


}

As I create each row, I am setting up each of the Listeners in my MyClickListener[]:

ocl[rowCount] = new MyListener(rowCount)

I have a print out, so I see that the listener is being created, but for some reason, this guy isn't being triggered when I click on a row.

@Override
public void onClick(View v) {
// TODO Auto-generated method stub

}

[pbrockway2]

but for some reason, this guy isn't being triggered when I click on a row.

Are you calling setOnClickListener() on the view to associate the listener with it?

------------

As you have seen the value the listener gets is the value you give it when you create it. Using a global variable for the row count is asking for trouble: use a local one passed to the listener's constructor or just made final as in the following Swing example:

import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;

import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.SwingUtilities;


public class ListenerEg extends JPanel {
	private static final int NUM = 10;
		// better not to have a variable row...
	private int row;
	
	public ListenerEg() {
		super(new GridLayout(0, 1));
		for(row = 0; row < NUM; row++) {
			JButton toAdd = new JButton("Click me!");
			final int num = row;
			toAdd.addActionListener(new ActionListener() {
				@Override
				public void actionPerformed(ActionEvent arg0) {
					System.out.println("Click! num=" + num + " row=" + row);
				}
			});
			add(toAdd);
		}
	}
	public static void main(String[] args) {
		SwingUtilities.invokeLater(new Runnable() {
			@Override
			public void run() {
				JFrame frame = new JFrame("ListenerEg test");
				frame.add(new ListenerEg());
				frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
				frame.pack();
				frame.setVisible(true);
			}
		});
	}
}