Can't figure out what's wrong, help please.

[Taszk]

i see where your coming from but for some odd reason enter 1,2,3,4,5,6,7,8,9,10 and 0 to exit gives me 2 as smallest and 3 as second smallest. Shouldn't it be 1 and 2?

and now when i just enter 0 to exit i get those numbers i initialized at the beginning as output. i tried putting the print statement inside the if but since there's a loop it repeats it when it goes around.

[Dark]

Don't put the print statement in the while loop.

You set your variables to the numbers I said? Post your updated code so I can see it.

[sunde887]

I kind of figured he probably wasn't very familiar with arrays/array lists. Just suggested it because the logic can be much simpler.

[Taszk]

import java.util.*;
public class Project2Beta{
	public static void main(String[] args){
		//main method calls output method and executes it
		output();

		
		//Variables must be integers
		int num, Larg=-2147483648, Small=2147483647, Small2=2147483647;
		Scanner in=new Scanner(System.in);
		num=in.nextInt();
	
		
	while (num != 0){
		output1();
		num=in.nextInt();
		if(num > Larg){
				Larg=num;}
		if(num < Small2 && num > Small && num != 0){
				Small2=num;}
		if(num < Small && num !=0){
				Small2 = Small;
				Small=num;
				}
							
		
		}	
		System.out.print("Largest: "+Larg+" \nSmallest: "+Small+" \nSecond Smallest: "+Small2);
	}
	
	//Method called output 	
	public static void output(){
		System.out.print("Enter a number to begin executing Largest, Smallest and ");
		System.out.println("Second Smallest number program, Otherwise terminate program by entering 0");
	}
	
	//Method called output1
	public static void output1(){
		System.out.print("Enter another number: ");
	}
}

I didn't put the print statement in it. I put the print statement inside the brackets of the ending of the last if statement.

[goldest]

The place where you are reading the input in while loop is causing the problem. Read the number at the end of the while loop, instead of in the beginning. Thats what is causing you to skip the first value.

while (num != 0){
		output1();
		[COLOR="red"]//num=in.nextInt(); Don't have this here[/COLOR]
		if(num > Larg){
				Larg=num;}
		if(num < Small2 && num > Small && num != 0){
				Small2=num;}
		if(num < Small && num !=0){
				Small2 = Small;
				Small=num;
				}
		num=in.nextInt(); [COLOR="red"]// Have it here[/COLOR]
		}

Hope that helps,

Goldest

[Dark]

import java.util.*;
public class Project2Beta{
	public static void main(String[] args){
		//main method calls output method and executes it
		output();

		
		//Variables must be integers
		int num, Larg=-2147483648, Small=2147483647, Small2=2147483647;
		Scanner in=new Scanner(System.in);
		[b]num=in.nextInt();
	
		
	while (num != 0){
		output1();
		num=in.nextInt();[/b]
		if(num > Larg){
				Larg=num;}
		if(num < Small2 && num > Small && num != 0){
				Small2=num;}
		if(num < Small && num !=0){
				Small2 = Small;
				Small=num;
				}
							
		
		}	
		System.out.print("Largest: "+Larg+" \nSmallest: "+Small+" \nSecond Smallest: "+Small2);
	}
	
	//Method called output 	
	public static void output(){
		System.out.print("Enter a number to begin executing Largest, Smallest and ");
		System.out.println("Second Smallest number program, Otherwise terminate program by entering 0");
	}
	
	//Method called output1
	public static void output1(){
		System.out.print("Enter another number: ");
	}
}

I didn't put the print statement in it. I put the print statement inside the brackets of the ending of the last if statement.

Its ignoring the first number because you're overwriting it when it enters into the while loop.
Just delete the first num = in.nextInt(); and it'll work just fine. Set num to 1.

[Taszk]

Thank you all for your help. Really appreciate it.

Is there any place i could put the print statement so it still prints the output and if i enter zero at the beginning of the program it just exits without displaying anything?

[Dark]

Write another if statement for it.

if(!(Larg == -2147483648 && Small == 214748647 && Small2 == 214748647)){System.out.println("My print statement.");}

[goldest]

Is there any place i could put the print statement so it still prints the output and if i enter zero at the beginning of the program it just exits without displaying anything?

Keep the current code as it is. But if you want to exit if the first input itself is a zero then you can use System.exit(). Something like,

.... num = in.nextInt();
if (num == 0) {
        // optional print statement.
	System.exit(0);
}
while (num != 0) {...... //rest of the code

Use this just before your while loop, after you read the integer first time. You can also have any print statement inside the if statement for display purpose before exiting. :cool:

Hope that helps,

Goldest

[Taszk]

Thanks for everything. :)

[goldest]

Thanks for everything. :)

Come back again if you face any issues. We would be more than happy to help you.

I hope you can get at least "some" sleep before heading to school. :cool:

Goldest