maps

Hello,

I want to write a method that will give me the union of 2 maps. So far i wrote some code that compiled and gave me no error, but when i run it it gives me an error which i couldnt find why it was giving it to me.

The error : java.lang.UnsupportedOperationException: null (in java.util.AbstractCollection)

and here is my code:

Code:

---

import java.util.Map;
import java.util.HashMap;
import java.util.Set;
import java.util.Iterator;

public class Ex9
{
    public static void main (String[] args)
    {
        Map<Integer, Integer> map1 = new HashMap<Integer, Integer> ();
       
        map1.put(7, 1);
        map1.put(18, 5);
        map1.put(42, 3);
        map1.put(76, 10);
        map1.put(98, 2);
        map1.put(234, 50);
       
        Map<Integer, Integer> map2 = new HashMap<Integer, Integer> ();
       
        map2.put(7, 2);
        map2.put(11, 9);
        map2.put(42, -12);
        map2.put(98, 4);
        map2.put(234, 0);
        map2.put(999, 3);
       
        System.out.println("Map 1 : " + map1);
        System.out.println("Map 2 : " + map2);
       
        Map<Integer, Integer> result = union(map1, map2);
        System.out.println("The union of the above maps is : " + result);
    }
   
    /**
    * Returns a new map of integer keys and values which consists on the union of 2 maps.
    *
    * @param map1 The first map of integer keys and values.
    * @param map2 The second map of integer keys and values.
    * @return A new map which is the union of both maps.
    */
    public static Map<Integer, Integer> union (Map<Integer, Integer> map1, Map<Integer, Integer> map2)
    {
        if (map1.isEmpty())
        {
            return map2;
        }else if (map2.isEmpty()) {
            return map1;
        }else{
            Map<Integer, Integer> result = new HashMap<Integer, Integer> ();
           
            Set<Integer> keys = map1.keySet();
            [B]keys.addAll(map2.keySet());[/B]
           
            Iterator<Integer> i = keys.iterator();
           
            while (i.hasNext())
            {
                int key = i.next();
               
                if (map1.containsKey(key) && map2.containsKey(key))
                {
                    int val1 = map1.get(key);
                    int val2 = map2.get(key);
                    result.put(key, (val1 + val2));
                }else if (map1.containsKey(key) && !map2.containsKey(key)){
                    result.put(key, map1.get(key));
                }else{
                    result.put(key, map2.get(key));
                }
            }
           
            return result;
        }
    }
}

---

Iam getting an error at the bold line position

Also, is this a correct way of doing the union of two maps?

Regards,

EDIT: I just tried this this line of code too but didnt work

Code:

---

Set<Integer> keys = map1.keySet();
Set<Integer> keys2 = map2.keySet();
           
Iterator<Integer> i2 = keys2.iterator();
while (i2.hasNext())
{
    keys.add(i2.next());
}

---

Please post the FULL text of the error message and not just one part of it. The full message has useful info for understanding the cause of the error.

I use BlueJ and it gave me the error down anyway I'll post a screenshot of the code page and the console

http://i52.tinypic.com/11ttr8g.png

Hope this helps

This is straight from the API documentation for the keySet() method in the HashMap class:

Quote:

---

Originally Posted by API docs

Returns a Set view of the keys contained in this map. The set is backed by the map, so changes to the map are reflected in the set, and vice-versa. If the map is modified while an iteration over the set is in progress (except through the iterator's own remove operation), the results of the iteration are undefined. The set supports element removal, which removes the corresponding mapping from the map, via the Iterator.remove, Set.remove, removeAll, retainAll, and clear operations. It does not support the add or addAll operations.

---

Pay special attention to the last sentence.

kind regards,

Jos

The key set returned is some form of abtract collection with mostly dummied out operations (the ones that add things), because you are not supposed to edit either the key set or the entry set, which would bypass the Map code.

Anyway, you want to know the union, so why not simply iterate over the key set from one of the maps. After all, you don't care about the ones in the other Map that aren't in the set you're iterating over...

So anything that returns a set view, I'm not supposed to modify it?

@Tolls: But if i iterate over one key set, and i get the values with the common keys, i then still have the ones without the common keys ...

Create a new clean object:

Set<Integer> keys = new HashSet<Integer>(map1.keySet());

@Norm : Okay, thnx it worked with creating a hash set object.

Thanks everybody for the help.

Quote:

---

Originally Posted by aizen92

So anything that returns a set view, I'm not supposed to modify it?

@Tolls: But if i iterate over one key set, and i get the values with the common keys, i then still have the ones without the common keys ...

---

No it doesn't.
You still use the same loop above, but loop over map1.
If map2 contains the key then add that into your result.

Code:

---

get map 1 keyset.
iterate over keyset.
if key exists in map 2 then add map1 and map2 values and add key and total value into result.

---