Where to put windowClosing Event

[darshanaprasad]

Hi Friends,
I need to add window Closing Event to following code to close the program when clicked close button.

<code>
import java.awt.*;
import java.awt.event.*;

public class App1 extends Frame implements ItemListener
{
private Choice choice1;
Label label1 = new Label("Make a Choice!");

App1()
{
super("Sample Choice");
add(label1, BorderLayout.NORTH);

choice1 = new Choice();
choice1.addItem("One");
choice1.addItem("Two");
choice1.addItem("Three");
choice1.addItemListener(this);
add(choice1, BorderLayout.CENTER);
pack();
setSize(200, getPreferredSize().height);
setLocation(25, 25);
setVisible(true);

}
public void itemStateChanged(ItemEvent ie)
{
String state = "Deselected";
if(ie.getStateChange() == ItemEvent.SELECTED)
{
state = "Selected";
}
label1.setText(ie.getItem() + " " +state);
}

public static void main(String args[])
{
new App1();
}
}
</code>

I need to insert the code,
<code>
addWindowListener(new WindowAdapter(){
public void WindowClosing(WindowEvent e) {System.exit(0);}});
</code>

into the above program.
Please help me to add this code into my program.

[JosAH]

I need to insert the code,
<code>
addWindowListener(new WindowAdapter(){
public void WindowClosing(WindowEvent e) {System.exit(0);}});
</code>

into the above program.
Please help me to add this code into my program.

Why not put it in your constructor? You're decorating your Frame there already ...

kind regards,

Jos

[dlorde]

Put it in the app constructor.

Having said that, calling System.exit() directly is nearly always a poor practice, and calling it from a window event handler is probably asking for trouble. If you want your application to exit when the frame is closed, set the frame's default close operation to DISPOSE_ON_CLOSE or EXIT_ON_CLOSE.

If you must use a WindowAdapter, don't forget that the method is windowClosing(..) not WindowClosing(..).

[darshanaprasad]

Thank you very much.

Great advices...

[DarrylBurke]

... calling System.exit() directly is nearly always a poor practice, and calling it from a window event handler is probably asking for trouble. If you want your application to exit when the frame is closed, set the frame's default close operation to DISPOSE_ON_CLOSE or EXIT_ON_CLOSE.

From JFrame.java, lines 273-294 (comment added)

    protected void processWindowEvent(WindowEvent e) {
        super.processWindowEvent(e);

        if (e.getID() == WindowEvent.WINDOW_CLOSING) {
            switch(defaultCloseOperation) {
:
:
	     case EXIT_ON_CLOSE:
                    System.exit(0); // <---- oops!
	         break;
	     }
        }
    }

DISPOSE_ON_CLOSE doesn't necessarily terminate the program. If you have a Swing Timer running, for example, it will keep the program alive.

db