need to read information from file into array

[sadeem]

hi
i need to create contact information class which is store the information from file to an array or (any collection).
the file include the first name and last name like this
Sadeem Shizan
Alban Alsha
and so on..

so what i do ..

public class Contact{
private String Fname;
private String Lname;
private int id;
    public Contact(int id,String fname,String lname) {
    Fname=fname;
    Lname=lname;
    this.id=id;	
    }
    
}

...

public class ContacInformation {

 public ContacInformation() {
  
    }
 public static void main(String[] args) throws IOException{
 	String fname,lname;
 	int id;
 	int i=0;
 	int d=1;
 	Contact[] contact=new Contact[30];
 	Scanner scan=new Scanner ("contactInfo.txt");
 	while(scan.hasNext()){
 		fname=scan.next();//read first word 
 		lname=scan.next();//read second word
 		id=d;
 		d++;
 		contact[i]=new Contact(id,fname,lname);
 		i++;
 		
 	}
 	for(int j=0;j<contact.length;j++){
 		System.out.println(contact[i]);
 	}
 	
 }   
    
}

i can't get the output, i don't know where is my wrong

can you help me :)

[sunde887]

Do you get no output, or just weird output? If it's weird output would you mind showing the output?

[Norm]

You need to provide a method in the Contact class to print out the contents of the class object. You are probably seeing an internal representation of the class object (the name and address perhaps).
One way is to override the Object class's toString() method and format the output the way you want to see.

[sadeem]

sunde887
i get an exception ..i attach the output

norm

are u mean like this

	for(int j=0;j<contact.length;j++){
 		System.out.println(contact[i].toString());

:confused::confused:

[Norm]

Your exception is because the loop variable and the index variable are NOT the same.

My comment was to override the toString method for the Contact class. By that I mean add a method/code to the Contact class that returns what you want to see when printing.

[sadeem]

i do this edit but the exception is still occure

public class Contact{
private String Fname;
private String Lname;

public Contact(){
}
    public Contact(String fname,String lname) {
    Fname=fname;
    Lname=lname;
   
    }
    


    public String getFname()
    {
       return Fname;
    }
     public String getLnname()
    {
       return Lname;
    }
      public String toString()
    {
       return getClass().getName()
          + "[name=" + Fname;
          
    }
}

>>

public ContacInformation() {
  
    }
 public static void main(String[] args) throws IOException{
 	String fname,lname;
 	int id;
 	int i=0;
 	
 	Contact[] contact=new Contact[30];
 	Scanner scan=new Scanner ("contactInfo.txt");
 	while(scan.hasNext()){
 		fname=scan.next();//read first word 
 		lname=scan.next();//read second word
 		
 		
 		contact[i]=new Contact(fname,lname);
 		i++;
 		
 	}

 	}
 	
 }

[Norm]

What is the source code at line 25?

Add a print statement after each next() call to show what was read. You'll see where the error is.


You are reading two lines with the next() method but you do NOT test with hasNext() before the second one.

[sadeem]

ok, see when i do this

public class ContacInformation {

 public ContacInformation() {
  
    }
 
 	public Contact[] readinfo()throws IOException{
 	
 	String fname,lname;
 	
 	int i=0;
 	
 	Contact[] contact=new Contact[30];
 	Scanner scan=new Scanner ("contactInfo.txt");
 	while(scan.hasNext()){
 		fname=scan.next();//read first word 
 		
 		
 		
 		contact[i]=new Contact(fname);
 		i++;
 		
 	}
return contact;
 	}
 	
  public static void main(String [] args) throws IOException{
  	ContacInformation cinf=new ContacInformation();
  	Contact c[]=null;
  	c=cinf.readinfo();
  	for(int i=0;i<c.length;i++)
  		System.out.println(c[i]);
  } 	
 }

why i get this output :confused::confused::mad:

[Norm]

What do you see in the first line that is printed out? What does that tell you?

You have changed the program so that there is only one call to next(). So now hasNext() does its job.