Buffered Writter While Loop

[Sobutai]

EDIT: Newer code below



Thank you for your time.

[pbrockway2]

I have a try catch where the catch is looping forever, leading me to believe that the while loop is for some reason not incrementing.

If you want the increment to always happen, put it in the finally part of try/catch/finally.

[Sobutai]

If you want the increment to always happen, put it in the finally part of try/catch/finally.

I changed the while loop to a for loop that increments ( for(int i = 1; i <= numrows; i++) and added a finally that increments if the try doesn't work. Now my catch still goes off but it only goes off for as many rows as I have in my database. (3)

[pbrockway2]

You should not increment twice. If you increment as part of the for statement, then all the catch should do is continue.

With so much catching going on it's not completely clear what the problem is exactly. Perhaps you could post the code you are using now and describe the actual behaviour (in objective terms: ie what gets written to out.)

[Sobutai]

I've been able to fix the majority of my problems on my own, but now I'm having a huge problem. Once I figure it out however, I'm done.

I have several stringer getting fed information in a for loop, that information gets wrote into a text file then it is suppose to go down a line on the text file. However, it only wants to write the last string entered and never go down a line and write there.

private void mnu1Save_Click() {

        
try{
         

         rs.last();
         rs.moveToCurrentRow();
         int numrows = rs.getRow();
         rs.first();
         rs.moveToCurrentRow();

        
        for(int i = 1; i <= numrows; i++){ 
         try{
          rs = stmt.executeQuery("SELECT Last, First, Street, City, State, Zip, Phone FROM MailList");
      
      //Sets the cursor to the first entry
      rs.absolute(i);
                
      //Sets the strings to the information in specific row and column
     
      String Last = rs.getString("Last");
      String First = rs.getString("First");
      String Street = rs.getString("Street");
      String City = rs.getString("City");
      String State = rs.getString("State");
      String Zip = rs.getString("Zip");
      String Phone = rs.getString("Phone");
      
      String Total = Last + "," + First + "," + Street + "," +  City + "," + State + "," +Zip + "," +Phone;
     
      FileWriter fstream = new FileWriter("out.txt");
      BufferedWriter out = new BufferedWriter(fstream);
      out.write( Total );
      out.newLine();
      out.close();


            rs.next();
             
             }
            
        
      
        catch (Exception e){//Catch exception if any
      System.err.println("Error: " + e.getMessage());
    }
   }
}
 catch (Exception e){//Catch exception if any
      System.err.println("Error: " + e.getMessage());
    } 
}

The output is suppose to say:
Morgan,Harry,123 Lotus Lane,Schenectady,NY,12345,518-445-4554
Trump,Donald,Borgata Room 999,Atlantic City,NJ,54321,305-445-5445
null,null,null,null,null,null,null

Only shows:
null,null,null,null,null,null,null

[DarrylBurke]

That's expected, since you construct a new writer, write each line and then close the writer. Each time you write a line it overwrites the file created for the previous line.

Open the writer before the for loop and close it in the finally block (with a null check).

And fix your indentation if you expect people here to read your code.
Code Conventions for the Java(TM) Programming Language: Contents

db

[Sobutai]

That's expected, since you construct a new writer, write each line and then close the writer. Each time you write a line it overwrites the file created for the previous line.

Open the writer before the for loop and close it in the finally block (with a null check).

And fix your indentation if you expect people here to read your code.
Code Conventions for the Java(TM) Programming Language: Contents

db

I apologize. I have fixed my code (and hopefully my indentations)is this what you meant:

private void mnu1Save_Click() {
 String[] writeArray = new String[100];
         
     try{
         

     rs.last();
     rs.moveToCurrentRow();
     int numrows = rs.getRow();
     rs.first();
     rs.moveToCurrentRow();

     FileWriter fstream = new FileWriter("out.txt");
     BufferedWriter out = new BufferedWriter(fstream);
           for(int i = 1; i <= numrows; i++){ 
              try{
          rs = stmt.executeQuery("SELECT Last, First, Street, City, State, Zip, Phone FROM MailList");
      
          //Sets the cursor to the first entry
           rs.absolute(i);
                
           //Sets the strings to the information in specific row and column
     
      
             Newstring[0] = rs.getString("Last");
             Newstring[1] = rs.getString("First");
             Newstring[2] = rs.getString("Street");
             Newstring[3] = rs.getString("City");
             Newstring[4] = rs.getString("State");
             Newstring[5] = rs.getString("Zip");
             Newstring[6] = rs.getString("Phone");
      
             String concat = Newstring[0] + "," + Newstring[1]+ + "," +Newstring[2] + "," + Newstring[3] + "," + Newstring[4] + "," + Newstring[5]  + "," + Newstring[6] "\n";
      
             writeArray[i] = concat;
        
      
             out.write( writeArray[i] );
             out.newLine();
      
      
               rs.next();
             
             }
            
        
        
      
           catch (Exception e){
           System.err.println("Error: " + e.getMessage());
            }
            finally {
            if (out != null) { 
            out.close();
             }
     }
   }
  }
   catch (Exception e){//Catch exception if any
          System.err.println("Error: " + e.getMessage());
    } 
}

I am now getting a Stream Closed Error in the Terminal Window.

[DarrylBurke]

You're still closing the writer inside the loop.

db

[Sobutai]

If I put the finally block with the other catch block it tells me it cannot find variable out.

EDIT: Added another Try Catch for the writer, it works perfectly. Thank you!