Any suggestions for My search method?

[kevkid]

This is my Binary search tree search method

public Node SearchBST(int number)
    {
        Node T = Root;
        if (T == null)//If tree is empty
        {
            return null;
        }
        else
            while(T != null){
            if(number == T.data){
                return T;
                //Key found
            }
            else if(number < T.data){//Checks if the key is smaller than the current T
                T = T.left;
            }
            else//Checks if the key is larger than the current T
                T = T.right;
            }
        if(T == null)
            return null;
            //Key not found
}

Anything would be helpful... I am not sure if it even works, I haven't implemented the graphical part of the BST.

[Toll]

Looks good to me, aside from a few minor things: The last check if T==null, is it even needed? It seems to me that the only way it will ever reach that far down is if T is null, so it seems to be a redundant check. Also, you can probably get rid of the "else" after the first check if T == null; after all, if it is null, you return null and the method exits. As such, the else will always fire.

EDIT: Oh, and one thing that just came to me; it might complain that it might lack a return, which will be solved by removing the last check if T==null.

[kevkid]

Thank you much, also if anyone can, this is My add method

public boolean AddToBST(int number)
    {
    	Node t  = new Node();
    	t.left  = null;
    	t.right = null;
    	t.data  = number;
    	//System.out.println(t.data);
    	Node Temp = Root;//This pointer points to the root
    	if (Temp == null)
    	{
    		Root = t; 
    		return true;
    	}
	else
	{
		while (Temp!=null){
		if(t.data == Temp.data){
			System.out.println("Same Value added");
			return true;
		}
		else if(t.data < Temp.data){
			if(Temp.left == null){
				Temp.left = t;
			}
			else
				Temp = Temp.left;
		}
		else//This is the if(t.data>Temp.data)
			if(Temp.right == null){
				Temp.right = t;
			}
			else
				Temp = Temp.right;
		System.out.println(Temp.data);
		//System.out.println("In while loop");
		}
		}
    	return true;
    	}

If anyone sees anything strange, please tell me.

[Toll]

I think you're missing a few returns there. Also, since you're returning a boolean... Is there any case where it should return false? Because it never does.

[Toll]

Or perhaps you're not missing a few returns, on a closer look. The other question still stands though.

[kevkid]

I do thank you :D I am almost done with my project.
again Thanks :D