Exam prep Question

[tonto2010]

Hi All

I have a Java exam on Friday and am going through some past papers to try and brush up. This is a written exam but Im trying to write some of the code questions in eclipse for practise.

Does this code look alright? it compiles but im not sure it reaches the requirements of the question.

Thanks in advance

Question
Write a rent() method in the game class, which will rent out a game. The cost of renting the game is €5.00 per night, the number of nights is to be passed in an as an argument to the method, the maximum number of nights a game can be rented for is 5, if number of nights greater than this then an error message is printed to the user. if the game is rented for 3 or more night the cost is €15.00. The method should check there is a copy of the game available for rent and should decrement the appropriate variable to indicate that the game is being is being rented. The totalEarned attribure should be updated appropriately.

public class game
{
	private String name;
	private String Genre;
	private int noOfCopies;
	private double totalEarned;
	private int noOut;

	public game(String name, String Genre, int noOfCopies)
	{
		this.name = name;
		this.Genre = Genre;
		if(noOfCopies <= 0)
		{
			System.out.println("Copies must be more than 0!");
			totalEarned = 0;
			noOut = 0;
		}
		this.noOfCopies = noOfCopies;
	}
	public void rent(int numNights)
	{
		double cost = 5.00;	
		if(numNights > 5)
		{
			System.out.println("Number of nights must be less than5!");
		}
		if(numNights >= 3 || numNights <= 5)
		{
			cost = 15.00;
			{
				if(noOfCopies > 0)	
				{
					noOfCopies --;
				}
				totalEarned = cost;
			}

		}
	}
	}

[Toll]

I can see plenty of problems with it, actually. First of all, you only set totalEarned and noOut to 0 if 0 or less copies exist? Second, you never print an error if there are no copies available to rent. Third, you never increment totalEarned, you only set it to cost. Those are the errors that jumped out at me right away; there might be others.

[Solarsonic]

Why don't you test it yourself to see if it meets the requirements listed by instructor? If you run into any problems then post the error code here and the line that causes it.

[dpspine420]

I am new but just suggesting, correct if wrong but I think you would need a while loop for days input to prompt the user to input the correct one. from what I saw it would just print that line and have to have user start program over

[sunde887]

I am new but just suggesting, correct if wrong but I think you would need a while loop for days input to prompt the user to input the correct one. from what I saw it would just print that line and have to have user start program over

While it makes sense to re-prompt, the assignment doesn't say to re-prompt.

@op: Your condition is if(arg >= 3 || arg <= 5) is incorrect. What if the user enters 2? Will the condition produce true or false?