Split string

[codeAJ]

Hello,

I need to split a string like the following example:

word1 | word2 | word3 | word4 : word5 : word6

I am splitting the string into an array as follows:

String[] words = input.nextLine().split("[|:]");

I'm finding that before word2 to word6 there is a space, and I can't figure out why! :

word1
_word2
_word3
_word4
_word5
_word6

Can someone please help?

[sunde887]

Since you are trying to remove the spaces as well, add the leading space to your split argument.
[ | :] works for me in a quick test.

[Fubarable]

Or add optional white space before and after the [|:], e.g.,

String[] words = test.split("\\s+[|:]\\s+");

[codeAJ]

Or add optional white space before and after the [|:], e.g.,

String[] words = test.split("\\s+[|:]\\s+");

Many thanks, this worked a treat. :)

[Fubarable]

Many thanks, this worked a treat. :)

I'm sorry, but it's wrong. It should be:

String[] words = test.split("\\s*[|:]\\s*");

The one I did before, the white space wasn't optional.

[codeAJ]

I'm sorry, but it's wrong. It should be:

String[] words = test.split("\\s*[|:]\\s*");

The one I did before, the white space wasn't optional.

Thanks for your help.

When I print these strings to screen with System.out.println they are fine.

However when they are passed as arguments to an object's constructor they are being saved as 'null'! :confused:

User user = new User(words[0], words[1], words[2]);

Any ideas on what may be causing this problem?

[sunde887]

They shouldn't be null, mind showing some of your code?

[codeAJ]

They shouldn't be null, mind showing some of your code?

I have extracted out the following code:

import java.util.*;
import java.io.*;

public class Words {

   public static void main(String[] args) {

      Scanner input = new Scanner(new File("words.txt"));
      while (input.hasNext()) {
         String[] words = input.nextLine().split("\\s*[|:]\\s*");
         System.out.println(words[0]);  // Prints ok
         System.out.println(words[1]);  // Prints ok
         User user = new User(words[0], words[1]);
         user.printDetails(); // Prints wrong. e.g. Word1: null 
      }
   }
}

public class User {

   private String word1, word2;

   public User(String word1, String word2) {
      this.word1 = word1;
      this.word2 = word2;
   }

   public void printDetails() {

      System.out.println("Word1: " + word1);
      System.out.println("Word2: " + word2);
   }
}

Has me beat!

[codeAJ]

Please ignore my previous post.

I had made mistakenly overridden the User's instance variables.

[sunde887]

What change did you make to fix it? The code you posted looks good.

[codeAJ]

What change did you make to fix it? The code you posted looks good.

My previous post of code was only a snippet of what I thought was relevant.

User extends another class, and being a newbie I made the mistake of declaring the private instance variables again in the subclass.

So I removed these declarations and updated the print method:

public void printDetails() {

System.out.println("Word1: " + super.getWord1);
System.out.println("Word2: " + super.getWord2);
}

[sunde887]

Glad you solved it. Please mark your solved with the thread tools at the top.

[DarrylBurke]

The super keyword is only needed to invoke the superclass's implementation of a method that's overridden in the subclass. This doesn't appear to be the case here.

db

[sunde887]

The super keyword is only needed to invoke the superclass's implementation of a method that's overridden in the subclass. This doesn't appear to be the case here.

db

Good point, didnt even notice that. Op, if getWord is in the super class as public it is inherited by the subclass making the call to super unnecessary as Darryl stated.

[codeAJ]

Thanks for the tips. I have removed the "super." as this public method is indeed inherited. :D