Jar file making - picture problem

[amman]

Hi everyone!

I have a big problem. Me and my team made a java project (for our studies), and i need to make a jar of it.

I tell you what i've tried (and then how i've fall):
I have a package named "graph", so i have a folder named "graph".
In this folder i have several source files (*.java), and 2 other folder named "model" and "images". The folder "model" contains more sourcefile, and the folder "images" contains some *.jpg picture, what i need for my program.

I made a build.bat and a run.bat file with these containments:
build.bat:

javac graph/*.java graph/model/*.java
jar cvfe app.jar graph/Control graph/*.class graph/model/*.class graph/images/*.jpg

run.bat:

java -jar app.jar

The program is running, but i have a big problem: i can't see the pictures...
In one of the files whitch uses a picture i use it like this:

icon = new ImageIcon("images/switchfalse.jpg");

What could be the problem?

Please help!
Thanks,
Amman

[DarrylBurke]

The ImageIcon constructor you use requires a String that represents a file name. A resource inside a jar isn't a file.

Learn here how to construct an ImageIcon from an image in a jar, using a URL obtained from getResource(...)
How to Use Icons (The Java™ Tutorials > Creating a GUI With JFC/Swing > Using Swing Components)


db

[amman]

Hi!

I tried to figure out how to do this magic with the resources, but i couldn't.
Can you help me?

Here is the code, where i'm using the picture:

package graph;

import graph.model.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;

public class SwitchView extends JLabel{

    private Switch sw;
    ImageIcon icon;

    SwitchView(String viewname, Switch newsw)
    {
        super(viewname);
        
        sw = newsw;
        //java.net.URL imageURL = java.lang.ClassLoader.class.getResource("images/switchfalse.jpg");
        icon = new ImageIcon("switchfalse.jpg");
        //icon = new ImageIcon(imageURL);
        super.setIcon(icon);
        this.addMouseListener(new MouseAdapter(){
            public void mouseClicked(MouseEvent e) {
                     SwitchView swview = (SwitchView)e.getSource();
                     
                     if(swview.sw.getValue())
                     {
                    	 swview.setIcon(new ImageIcon("switchfalse.jpg"));
                    	 swview.sw.switchSwitch();
                     }
                     else
                     {
                    	 swview.setIcon(new ImageIcon("switchtrue.jpg"));
                    	 swview.sw.switchSwitch();
                     }
            }
        });
    }

}

This works, if i run in under eclipse.
But now i tried to replace the

icon = new ImageIcon("switchfalse.jpg");

line with

//java.net.URL imageURL = java.lang.ClassLoader.class.getResource("images/switchfalse.jpg");
        icon = new ImageIcon(imageURL);

but i'm getting nullpointerexception for the line "icon = new ImageIcon(imageURL);"

To refresh the info about the folder hierarchy in the jar:

/graph <-sourcefiles
/graph/model <-sourcefiles
/graph/images <-images

[Solarsonic]

You need to include the pictures in the same path as you coded them to be. So in this case, your jar file must contain pictures in the same directory as your class file.

jar cvfm program.jar manifest.mf *.class *.jpg