Can't determine whether a text file ends with carriage return

[PrinceSendai]

I am making a program that must determine whether a text file ends with a newline or not, or a carriage return.

For example, suppose I create a file called text.txt and add some text, but I add a carriage return at the end.

I want my program to return true if the file ends in a new line character or carriage return, and false if it doesn't. However, my program always returns false.

Here is a complilable SSCCE representing my problem. In order to test it, please create a random "text.txt" file and make sure it ends in a newline. You will see that my program returns false regardless.

Here it is>

import java.io.*;


public class mySSCCE{


	public static final String newline = System.getProperty("line.separator");




	public static void main(String[] args){

		try{

		System.out.println(endsInNewLine("text.txt"));

		}catch(IOException ioe){}

	}




	public static boolean endsInNewLine(String path) throws IOException{

        	File file = new File(path);
		String line = new String();

        	InputStreamReader streamReader = new InputStreamReader(new FileInputStream(file));
        	BufferedReader br = new BufferedReader(streamReader);

        	
		//get last line of file

        	while (br.ready()) {
           	line = br.readLine();
		
        	}


		br.close();

		return line.endsWith(newline) || line.endsWith("\n");


	}


}

Thanks for your help. To sum up my question: how do I check whether a text file ends in a carriage return or new line?

[ozzyman]

try this

...
String line = "";
while (br.ready()) {
  line += br.readLine();
}
char lastChar = line.charAt(line.length()-1);
isNewLine(lastChar);
...

method to check char for new line

public static final char CR = '\r';
public static final char LF = '\n';
 
public void isNewLine(char c) {
   boolean newLine = (c==LF) || (c==CR);
   System.out.println("Ended with new line: " + newline);
}

Edit:
On second thoughts, i think readLine() returns the String line without the new line char?

[DarrylBurke]

i think readLine() returns the String line without the new line char?

That's right.

db

[PrinceSendai]

The solution didn't really work for me because it seems like readline() will ignore the last new line character whether or not I used "line += br.readLine()" the last character simply will not be a new line.

I decided to skip this issue in my program. However, thank you guys for clearing up the fact that readline() does exclude the new line character. Otherwise I would still be scratching my head at why it doesn't work.

Thanks guys.

[JosAH]

Use a RandomAccessFile, position the file pointer near the end of the file, read one or two bytes and check whether or not they are \r and/or \n.

kind regards,

Jos