Help with Array please

[jjth39347]

okay I need to write a program that takes 5 names, votes ext... and displays them and names the winner. Also I can't get the count to work right >.<

import java.util.Scanner;


public class Lab11
{
	public static void main(String[] args)
	{
		Scanner kb = new Scanner(System.in); // declaring/defining a Scanner object and giving it a handle to the standard input stream
		String[] names = new String [5]; // empty string array declaration/definition, stores 5 Strings

		int[] votes = new int[5]; // empty int array declaration/definition, stores 5 ints

		for(int i = 0; i < 5; i++) // doing something 5 times
		{
			System.out.print("Enter the name of Candidate: " + (i+1) + " "); // request for input
			names[i] = kb.nextLine(); // Scanner blocks - waits for input from user
			System.out.print("Enter the total votes associated with Candidate: " + (i+1) + " "); // request for input
			votes[i] = kb.nextInt(); // scanner block - waits for input from user			}

		}

		String winner = ""; // String data-type placeholder for the winner
		int winnerVotes = 0; // votes the winner has
		int totalVotes = 0; // total votes accumulated
		int j; // declared int named j, not defined

		for (j = 0; j< votes.length; j++) // doing something 5 times...
		{
			totalVotes += votes[j]; // summing the votes... !
		}



		System.out.println("\nCandidate Votes Received % of Total Votes");
		System.out.println("--------- -------------- ----------------");

		for (j = 0; j< names.length; j++) // doing something 5 times
		{
			if (votes[j]>winnerVotes) // if the vote in index j of vote array is greater than winner votes..
			{
				winner = names[j]; // store the name associated with the vote in the String winner
				winnerVotes = votes[j]; // store the vote in the int winnerVotes
			}


	} // ^^ printing stuff out

		System.out.println("Total " + totalVotes); // the total votes,
		System.out.println("The winner of the election is " + winner); // printing out hte winner!
	}//main
}//election

It complies but the exceptions are

Exception in thread "main" java.util.InputMismatchException
        at java.util.Scanner.throwFor(Scanner.java:840)
        at java.util.Scanner.next(Scanner.java:1461)
        at java.util.Scanner.nextInt(Scanner.java:2091)
        at java.util.Scanner.nextInt(Scanner.java:2050)
        at Lab11.main(Lab11.java:18)
Press any key to continue . . .

[sunde887]

Is the exception thrown immediately, or when you input some data? What input caused it to be thrown? The code looks good, although I may be overlooking something.

[jjth39347]

it is thrown after I type in the 2nd name

[DarrylBurke]

Scanner#nextInt doesn't consume the newline, leaving it in the buffer where it is consumed by nextLine in the second iteration of the loop. When you type the second name, that is read by nextInt and results in an input mismatch.

db

[farahm]

I checked out your code and you have a couple of minor mistakes the below code is the corrected version: (check out the comments for the corrections)

import java.util.Scanner;

public class Lab11
{
    public static void main(String[] args)
    {
        Scanner kb = new Scanner(System.in); 
        Scanner kb2 = new Scanner(System.in); //a second scanner to read the numbers

        String[] names = new String [5];

        int[] votes = new int[5]; 
        for(int i = 0; i <5; i++) 
        {
            System.out.println("Enter the name of Candidate: " + (i+1) + " "); 
            names[i] = kb.nextLine(); 
            System.out.println("Enter the total votes associated with Candidate: " + (i+1) + " ");  
            votes[i] = kb2.nextInt(); //used second scanner
        }

        String winner = ""; 
        int winnerVotes = 0; 
        int totalVotes = 0; 

        for (int j = 0; j< votes.length; j++) //no need for int j to be initialized outside
        {
            totalVotes += votes[j]; 
        }

        System.out.println("\nCandidate Votes Received % of Total Votes");
        System.out.println("--------- -------------- ----------------");

        for (int k = 0; k< names.length; k++) //different variable not int j to be used/ different variable for each loop
        {
            if (votes[k]>winnerVotes) 
            {
                winner = names[k]; 
                winnerVotes = votes[k]; 
            }

        }

        System.out.println("Total " + totalVotes); 
        System.out.println("The winner of the election is " + winner); 
    }
}

[jjth39347]

I checked out your code and you have a couple of minor mistakes the below code is the corrected version: (check out the comments for the corrections)

import java.util.Scanner;

public class Lab11
{
    public static void main(String[] args)
    {
        Scanner kb = new Scanner(System.in); 
        Scanner kb2 = new Scanner(System.in); //a second scanner to read the numbers

        String[] names = new String [5];

        int[] votes = new int[5]; 
        for(int i = 0; i <5; i++) 
        {
            System.out.println("Enter the name of Candidate: " + (i+1) + " "); 
            names[i] = kb.nextLine(); 
            System.out.println("Enter the total votes associated with Candidate: " + (i+1) + " ");  
            votes[i] = kb2.nextInt(); //used second scanner
        }

        String winner = ""; 
        int winnerVotes = 0; 
        int totalVotes = 0; 

        for (int j = 0; j< votes.length; j++) //no need for int j to be initialized outside
        {
            totalVotes += votes[j]; 
        }

        System.out.println("\nCandidate Votes Received % of Total Votes");
        System.out.println("--------- -------------- ----------------");

        for (int k = 0; k< names.length; k++) //different variable not int j to be used/ different variable for each loop
        {
            if (votes[k]>winnerVotes) 
            {
                winner = names[k]; 
                winnerVotes = votes[k]; 
            }

        }

        System.out.println("Total " + totalVotes); 
        System.out.println("The winner of the election is " + winner); 
    }
}

I made your changes but I'm still getting the same exceptions, and its still not properly asking for the input of the names.

Enter the name of Candidate: 1 jason
Enter the total votes associated with Candidate: 1 jm
Exception in thread "main" java.util.InputMismatchException
        at java.util.Scanner.throwFor(Scanner.java:840)
        at java.util.Scanner.next(Scanner.java:1461)
        at java.util.Scanner.nextInt(Scanner.java:2091)
        at java.util.Scanner.nextInt(Scanner.java:2050)
        at Lab11.main(Lab11.java:19)
Press any key to continue . . .

[farahm]

After each time you enter the name or the number of votes make sure you press enter and when it says enter the number of votes you have entered "1 jm" and you are parsing a number so i will give an exception. Make sure when it asks for the name you enter a string and when it asks for a number you enter a number.
Here is a sample of what should happen when you run the code:
Enter the name of Candidate: 1
farah1
Enter the total votes associated with Candidate: 1
12
Enter the name of Candidate: 2
farah2
Enter the total votes associated with Candidate: 2
13
Enter the name of Candidate: 3
farah3
Enter the total votes associated with Candidate: 3
14
Enter the name of Candidate: 4
farah4
Enter the total votes associated with Candidate: 4
15
Enter the name of Candidate: 5
farah5
Enter the total votes associated with Candidate: 5
2

Candidate Votes Received % of Total Votes
--------- -------------- ----------------
Total 56
The winner of the election is farah4

[jjth39347]

dhope >.< I can't run my own program lol

[sunde887]

I don't entirely agree with farahms changes. First, you absolutely do not need a second scanner, in fact, it's a waste. Why create a second scanner which is doing nothing that the first scanner couldn't do?

Also, changing local loop variable names is not necessary. I can put 1000000 loops that look like this

for(int i = 0; i < 10; i++){
  Do stuff
}

and it will work fine.

Disregard this, did not see you did not declare j locally, however your code was still fine since each loop will set the value of j back to 0 before running.

Since you declared and initialized a new variable at the beginning of the loop, it will be destroyed after the loop finishes running, it will not be able to be referenced again. Because of this you don't run into problems when creating a new loop.

I highly suggest you re read darylls post.

When you extract something from a scanner with nextInt it gets the input and leaves the pointer just after that position, it does not swallow the rest of the line, this causes your error. Try adding this after prompting for the vote count

kb.nextLine();

[jjth39347]

I don't entirely agree with farahms changes. First, you absolutely do not need a second scanner, in fact, it's a waste. Why create a second scanner which is doing nothing that the first scanner couldn't do?

Also, changing local loop variable names is not necessary. I can put 1000000 loops that look like this

for(int i = 0; i < 10; i++){
  Do stuff
}

and it will work fine.

Disregard this, did not see you did not declare j locally, however your code was still fine since each loop will set the value of j back to 0 before running.

Since you declared and initialized a new variable at the beginning of the loop, it will be destroyed after the loop finishes running, it will not be able to be referenced again. Because of this you don't run into problems when creating a new loop.

I highly suggest you re read darylls post.

When you extract something from a scanner with nextInt it gets the input and leaves the pointer just after that position, it does not swallow the rest of the line, this causes your error. Try adding this after prompting for the vote count

kb.nextLine();

First of all, as always I love seeing your name on here :)
second. yea I looked at what was suggested and everything is running fine, the only question I have left is how can I line up the answers under the columns I made for them.

such as
name votes received % of total votes.
Jason 5 40%
ext....

3rd I cannot remember how to find the percentage of an array.

[sunde887]

1) thanks, I appreciate that, I enjoy helping people out where I can.

2) If you would like to format it better you will have to use either String.format, or System.out.printf.

I am not amazing about these and when I do use them I have to look up the flags. The general form however is

System.out.printf("%d is the number", 5);

this will substitute d with an integer from the following arguments, in this case, 5. There are flags that can be added between the % and the d which allow a lot of formatting, including using leading spaces(which is what you want). As stated, please check the tutorials for more specifics on which flags do what.

String.format works very similarly.

3) you won't be finding the percentage of an array, instead you will be finding the percentage of each item in the array. If you have the total number of votes in the array you are halfway there. From there you just divide each item in the array by the total.

int[] x = {1, 6, 9, 10, 4};
total = 30; //normally you use a loop to find the total, in this example
                //I am adding it with my brain
The percentage of x[0] is x[0]/total, and so on for each successive index.

[jjth39347]

so there isn't a way I could add all the numbers in each array index and then just dividing it by the total number of indexes in that array?

[JosAH]

so there isn't a way I could add all the numbers in each array index and then just dividing it by the total number of indexes in that array?

Sure there is, you just have to write it yourself (a few lines at most).

kind regards,

Jos

[sunde887]

Did you mean to say average votes? If so, how would you find the average of these numbers?

1 7 9 5 0 7 5 3

[jjth39347]

sorry my mistake, I asked the question wrong, I was thinking percentages not average I just ended up asking for average.

Any way I can find percentage out of the total votes?

[sunde887]

The percentage of votes each candidate got is what I showed above, array[i]/total.

[jjth39347]

okay thank you, I've been awake for far to long lol. Hell week ya know.

[jjth39347]

gah sorry to keep bugging you, I guess my question was how do I add up all the votes?

[sunde887]

Your second loop calculates the total.

[jjth39347]

gah no more cram sessions then do home work lol.

but I think I have it all done now

import java.util.Scanner;

public class Lab11_2
{
    public static void main(String[] args)
    {
        Scanner kb = new Scanner(System.in);
        Scanner kb2 = new Scanner(System.in); //a second scanner to read the numbers

        String[] names = new String [5];

        int[] votes = new int[5];
        for(int i = 0; i <5; i++)
        {
            System.out.println("Enter the name of Candidate: " + (i+1) + " ");
            names[i] = kb.nextLine();
            System.out.println("Enter the total votes associated with Candidate: " + (names[i]) + " ");
            votes[i] = kb2.nextInt();

        }

        String winner = "";
        int winnerVotes = 0;
        int totalVotes = 0;

        for (int j = 0; j< votes.length; j++)
        {
            totalVotes += votes[j];
        }

        System.out.println("\nCandidate Votes Received % of Total Votes");
        System.out.println("--------- -------------- ----------------");

        for (int k = 0; k< names.length; k++)
        {
            if (votes[k]>winnerVotes)
            {
                winner = names[k];
                winnerVotes = votes[k];
            }

        }

        System.out.println("% of total votes =%");
        System.out.println("The winner of the election is:" + winner+" Total number of votes:" + totalVotes+" percentage of votes: %"+(totalVotes/winnerVotes));
    }
}