method not working out side of class when all others do

[Guen]

public check {

int[][] test = new int[3][3];

public int getVal(int col, int row) {
     return test[col][row]
}
}

The above works fine in the class, but not out. All other methods relating to the array work fine outside of the class.

public class2 {
check test;
int Number = test.getVal(2,2)
}
}

Returns null pointer exception.

Why? It works inside the class and I can add to the array etc from another class using setVal(int col, int row) method.

[pbrockway2]

Do you mean "public class check {"? In that case a better name would be Check. (Also Number should be number)

Perhaps in the code that throws the NullPointerException you are declaring test to be of type check. But not assigning any value to it. That will give a NPE when you attempt to dereference test by saying "test.getVal(2, 2)".

-----------------

But this is only a guess: the code as posted isn't very coherent. Perhaps you could post a small runnable example that illustrates the problem (SSCCE)

[ozzyman]

i think test needs to be instantiated otherwise it will remain null,

i.e.
check test;

should be:
check test = new check();

on top of that, you will also get a nullpointer if the array in the class check doesn't have any values set to it.

this is all assuming that the code you posted was typed quickly and in your real code you've declared the check class properly i.e. public class check {

[Guen]

This was example code as I cannot post real code. Yes public class, sorry. And I know those var names are not very good, I was typing quickly. Im also aware I missed out semicolons. It was just a rough idea of my code.

Also in another class I do use = new check();, but it still doesnt work. I dont want a new object in the code above so (also according to my tutor) = new check(); is wrong. I tried that and it makes a new state/object.

the array does have vaules added further down.

[Guen]

OK, so it works with = new check();

But I dont want to create a new object. All my classes work on the same object including array, if I create a 'new' check I get a copy without the values I have added from another class. What is an alternative to = new check? The set methods work with just check test; ??

[JosAH]

OK, so it works with = new check();

But I dont want to create a new object. All my classes work on the same object including array, if I create a 'new' check I get a copy without the values I have added from another class. What is an alternative to = new check? The set methods work with just check test; ??

I think there's something you don't understand: for the expression o.f() where o is an object of any type and f() is any method defined for the type of o, you are saying f() to an object o, i.e. there has to be an object o to which you can say f(). If you don't want to create a new object o (which is understandable) you have to find another (already existing) object o, i.e. you have to pass such an object to that something that wants to say f() to the object. That 'something' is an object of the 'other class' you mentioned.

kind regards,

Jos

[Guen]

Thanks, this is my problem. I do not know how to send the object into the class without creating a new instance of it. Could someone please post code as an example?

[JosAH]

Thanks, this is my problem. I do not know how to send the object into the class without creating a new instance of it. Could someone please post code as an example?

There has to be at least one object (from whatever class) that has to 'own' or 'know' about this object. You should build a small get() method in that class that passes the object around so other objects (from other classes) can 'ask' for this object. Think about those objects a persons: if you have a piece of cake and I want some I have to ask for it.

kind regards,

Jos

[Guen]

I have to follow a template and I cannot add a get method. If I did im not sure what I need to send in it though?

[Fubarable]

I have to follow a template and I cannot add a get method. If I did im not sure what I need to send in it though?

Can you please clarify then what is your current problem, your current "template" and restrictions, and all information necessary to allow us to help you.

[Guen]

template has a method to set a value in an array which is in the initial class, but used from outside the class. Other irrelevant methods that affect the array, such as findLine. These all work. the method to return the value from the array (as above) only works inside the class. I need to call it from outside the class (as above). I do not want to create a new instance of the class (= new check();).

sorry i cannot post code

[Fubarable]

template has a method to set a value in an array which is in the initial class, but used from outside the class. Other irrelevant methods that affect the array, such as findLine. These all work. the method to return the value from the array (as above) only works inside the class. I need to call it from outside the class (as above). I do not want to create a new instance of the class (= new check();).

sorry i cannot post code

You will need to call the method on an instance of the class, period. How you get this instance will depend a lot on how your program is structured and your current code. Unfortunately the quality of our answers will depend directly on the quality of information that you supply us, and I don't know how much help will be able to give though given the limited information you're allowed to give us. Perhaps you can create a small compilable and runnable example program that doesn't have the exact code but that demonstrates your problem.

[ozzyman]

Guen, you can instantiate the class without 'creating' a new object... just use it as a temporary variable so it gets garbaged once you're done with it...

public int getValue() {
    check test = new check();
    int Number = test.getVal(2,2);
    return Number;
}

test becomes null once Number is returned

[Fubarable]

Guen, you can instantiate the class without 'creating' a new object... just use it as a temporary variable so it gets garbaged once you're done with it...

public int getValue() {
    check test = new check();
    int Number = test.getVal(2,2);
    return Number;
}

test becomes null once Number is returned

I don't see how this will help since you'll be getting the state of an object that doesn't really mean anything.

[Guen]

getValue is the method name I need to use. I want it to return the vaule at the point (col, row) in the array stored in check. The method returns the correct value in the class, but gets a null pointer outside the class. I only want one vaule and am not allowed the whole array to be exported directly.

[JosAH]

getValue is the method name I need to use. I want it to return the vaule at the point (col, row) in the array stored in check. The method returns the correct value in the class, but gets a null pointer outside the class. I only want one vaule and am not allowed the whole array to be exported directly.

Wouldn't it be nice if you showed us some more of your code; now we're just guessing while you say that you're not allowed do that etc.

kind regards,

Jos