Simple array question..

[Arigo]

So I'm trying to create a program that will go through a one dimensional array of numbers (10,9,8,7,6,5,4,3,2,1,0). I need the program to print the index of which an inputted number is at - e.g If the user inputs 9, it will print 1 (because 9 is at the index 1.) The problem I am having is that I need it to print -1 if a number entered is NOT in the array.. I am kind of confused as to how I can do this, any tips are appreciated.. thanks

Here is the code I have so far.. (unfinished)

    static int findIndexOf (int[] numbers, int target)
    {
        int index = 0;

        for (index = 0 ; index < numbers.length ; index++)
        {
            if (numbers [target] != index)
            {
                c.println (index);

            }
            else
            {
                c.println ("The number is at position: " + numbers [target]);
            }
       }
        return index;
    }
}

[pbrockway2]

if (numbers [target] != index)

Shouldn't that be

if (numbers[index] != target)

[Arigo]

Shouldn't that be

if (numbers[index] != target)

When I run it like that, I get the output

0
The number is at position: 1
2
3
4
5
6
7
8
9
10
The number is at position: 1

If I enter a number say 9999, I will get an ArrayIndexOutOfBoundsException..

[pbrockway2]

Post a short runnable example (SSCCE) which results in the exception.

[Arigo]

Post a short runnable example (SSCCE) which results in the exception.

I don't really understand what you mean by this, are you asking me to post a short amount of code that results in the error? Can't you get that from my first post?

[f1gh]

i believe you changed the above but probably didn't fix the print statement:

System.out.println ("The number is at position: " + numbers [target]);

over here target probably needs to be changed to index.

[pbrockway2]

The code you posted is not runnable.

Yes, I am puzzled by the claim that using the condition 'if(numbers[index] != target)' rather than the line you had will result in an AIOOBE. So it would be helpful to see code illustrating that.

[Edit] Ah! f1gh is probably right!

[Arigo]

The code you posted is not runnable.

Yes, I am puzzled by the claim that using the condition 'if(numbers[index] != target)' rather than the line you had will result in an AIOOBE. So it would be helpful to see code illustrating that.

Here is everything I have, its not long just a simple program

import java.awt.*;
import hsa.Console;

public class Array_Assignment_1
{
    static Console c;           // The output console

    public static void main (String[] args)
    {
        c = new Console ();

        int[] numbers = {10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0};
        int target = 0;
        int findIndex = 0;

        c.println ("Please enter the number you wish to find the index of. ");
        target = c.readInt ();

        findIndex = findIndexOf (numbers, target);
        //c.println ("The number is at position: " + numbers [target]);
    }


    static int findIndexOf (int[] numbers, int target)
    {
        int index = 0;

        for (index = 0 ; index < numbers.length ; index++)
        {
            if (numbers [index] != target)
            {
                c.println (index);
            }
            else
            {
                c.println ("The number is at position: " + numbers [index]);
            }
        }
        return index;
    }
}

[pbrockway2]

findIndexOf() is not finding the index of the target. It is always returning numbers.length because that is what finishes the for loop.

It would be better to returning index as soon as numbers[index] equals target. If you get all the way through the for loop without finding a match, that is the time to return -1.

(I'm guessing you get the AIOOBE at the line you commented out. That makes sense because findIndexOf() returns numbers.length and when you try and use that as an index you will get an exception as it's too big.)

[Arigo]

findIndexOf() is not finding the index of the target. It is always returning numbers.length because that is what finishes the for loop.

It would be better to returning index as soon as numbers[index] equals target. If you get all the way through the for loop without finding a match, that is the time to return -1.

(I'm guessing you get the AIOOBE at the line you commented out. That makes sense because findIndexOf() returns numbers.length and when you try and use that as an index you will get an exception as it's too big.)

I can't really seem to figure this out.... are you saying make the for loop:

for (index = 0 ; numbers[index] == target ; index++)

Or something similar, I don't really understand this.. That loop I just printed would start at the index of 0, and continue until the value of index in the numbers array is equal to target, and if not it will add one to index, and continue until it does equal target?

[pbrockway2]

No, the for loop initialisation etc is correct. There is no reason to change it.

The thing is in the body of the for loop. You are trying to return the index vcalue that matches target right? So do that: remove all the println() stuff and return the value.

for (index = 0 ; index < numbers.length ; index++)
{
    if (numbers [index] == target)
    {
        return index;
    }
}

[Arigo]

No, the for loop initialisation etc is correct. There is no reason to change it.

The thing is in the body of the for loop. You are trying to return the index vcalue that matches target right? So do that: remove all the println() stuff and return the value.

for (index = 0 ; index < numbers.length ; index++)
{
    if (numbers [index] == target)
    {
        return index;
    }
}

This still dosent seem to be working for me, I replaced my for loop, with that and still get an AIOOBE error, and for some reason it dosent seem to be letting me have the return, inside the if statement?

[Arigo]

When trying to run this

    static int findIndexOf (int[] numbers, int target)
    {
        int index = 0;

        for (index = 0 ; index < numbers.length ; index++)
        {
            if (numbers [index] == target)
            {
                return index;
            }
        }
    }
}

I get a compile error saying Method findIndexOf must contain a return statement...

[pbrockway2]

Every possible "path of execution" must return a value. At the moment the method returns a value (index) when a match is found between numbers[index] and target but the method must also return something if no match is found: ie if the for loop gets all the way through because target is not present in the array.

static int findIndexOf (int[] numbers, int target)
{
    int index = 0;

    for (index = 0 ; index < numbers.length ; index++)
    {
        if (numbers [index] == target)
        {
            return index;
        }
    }
    [color=green]// you must return some value here (indicating that target was not in the array)[/color]
}