Match Generator Assignment Help / Error Message

Hiya guys, I've been ill recently and not had time to finish my assignment, my tutor has given me a reaessment and I really can't fail it, so far I've got 30/40 points for the module. The last 10 points are for valiadation which I am stuck on.

My current assignment is a football match generator, I scan a file and store the data, I then output the data to read football teams scores which is working fine but for the last 10 points I need to be able to validate the data so it read the scores correctly from the fake and real once. I'm new to this forum so not really sure what to do and I'm also new to programming so I'm not that epic at it =/

Can anyone help me at all? I really can't fail this module!

Kitty x

Below is my current code and the error message I have.

Code:

---

import java.io.File;
import java.io.FileNotFoundException;
import java.util.Scanner;
public class requirement1 {
        public class Teams {
               
                String home_team;
                String away_team;
                int home_score;
                int away_score;

               
                }
       
        public static void main(String[] args) throws FileNotFoundException {

// scans the file named in brackets
                Scanner s = new Scanner(new File("src/results2.txt"));       

               
                String line;        // stores the each line of text read from the file
//declaring all values
                int InvalidCount = 0; // declares all the variables which are set to 0
                int ValidCount = 0;
                int ScoreCount = 0;



                while ( s.hasNext() ) {

                        line = s.nextLine();               



                        String [] splitupText = line.split(":");                       
                        line = line.trim();
// trims all the text
                        splitupText[0]=splitupText[0].trim();
                        splitupText[1]=splitupText[0].trim();       


                        if (splitupText.length != 4)
                        {InvalidCount = InvalidCount+1 ;}

                        else if (splitupText[0].isEmpty() ){
                                InvalidCount = InvalidCount+1 ;}

                        else if (splitupText[1].isEmpty() ){
                                InvalidCount = InvalidCount+1 ;}

                        else {                               
                                String hometeamName = splitupText[0].trim();
                                String awayteamName = splitupText[1].trim();
                                String hometeamScore = splitupText[2].trim();
                                String awayteamScore = splitupText[3].trim();
                                try {                                                                                // parses all the data from the file
                                        int homescore = Integer.parseInt(hometeamScore);       
                                        int awayscore = Integer.parseInt(awayteamScore);
                                        ScoreCount = ScoreCount + (homescore + awayscore);
                                        System.out.println( hometeamName + " [" + hometeamScore + "] " + "| "+ awayteamName + " [" + awayteamScore + "]"); // prints all the data from the .txt file in the given format
                                        ValidCount = ValidCount+1 ;

                                }
                                catch (NumberFormatException e) {


                                        InvalidCount = InvalidCount+1 ;
                                }       
                        }
                }
                System.out.println( ("\n") ); // prints a blank line
                System.out.println ("Number of Goals: " + ScoreCount);       
                System.out.println ("Number of invalid entries: " + InvalidCount);       
                System.out.println ("Number of valid entries: " + ValidCount);
        }}

---

Error Message

Code:

---


Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1
        at requirement1.main(requirement1.java:39)

---

I've also attached the file that I read the data off.

Trace the thrown exception. It says at line 39 you had an array index out of bounds error. What happens if you find the length of split up text before indexing into it?

Code:

---

System.out.println(splitupText.length);

---

Also, I am not entirely sure what you are stuck on. Would you mind clarifying? Perhaps posting the exact assignment may be helpful to me and others.

Quote:

---

Originally Posted by sunde887

Trace the thrown exception. It says at line 39 you had an array index out of bounds error. What happens if you find the length of split up text before indexing into it?

Code:

---

System.out.println(splitupText.length);

---

Also, I am not entirely sure what you are stuck on. Would you mind clarifying? Perhaps posting the exact assignment may be helpful to me and others.

---

I'm not really sure what you mean? I only started this recently so I'm still getting to terms understanding it.

This is my assignment breif:

"Requirement 1 : Basic Level (40%-50%) - Threshold pass.

The Generator program must read in the specified match results file and validate the contents. The results of each valid match should be output to the screen (stdout) in the following format.

<home_team_name> [<home_team_score>] | <away_team_name> [<away_team_score>]

At the end of the output statistics should be generated to show the total number of valid and invalid matches that were processed. Also the total number of goals scored should be shown.

The following is an example of the typical output to be generated.

Leeds United [1] | Liverpool [10]
Chelsea [2] | Manchester City [1]
Manchester United [2] | Luton [0]

Valid Match count was 3, total goals scored were 16.
Invalid Match Count was 1"

Also to mention I used eclipse at school on a windows computer and it was working fine but it seems to diff from when I'm at home working on my mac with a mac version of eclipse.

First decide on what constitutes a valid line.
How many colons (:) should it have?
Then write a method called isValid which takes a line and returns true if it's a valid line.
In your main code you then only process the valid lines and increment the invalids counter if isValid returned false.

Quote:

---

Originally Posted by r035198x

First decide on what constitutes a valid line.
How many colons (:) should it have?
Then write a method called isValid which takes a line and returns true if it's a valid line.
In your main code you then only process the valid lines and increment the invalids counter if isValid returned false.

---

"Leeds United : Liverpool : 1: 10
Chelsea : Manchester City :1
Hull : :2:3
: :2:0
Arsenal Liverpool :2:2"

This is another of the text files that has the invaild enteries in, how can I read two files btw?

I understand in theory what your saying but not really sure how to do it in actually code, it's half term atm so my tutor is away and our hand in is tomorrow so im just stressing out atm trying to get this solved

Found some notes too that I had

Need to use ExampleReader, ExampleSplitter, NumberProcessor

String[]splitText = linesplit (;)
String hometeam = splitText [0]
String awayteam = splitText [1]

Array
Pass it

If statement to see if their validated

If (splitText.length() == 4
If not 4 then it is not valid

Hope it helps.

Have you corrected your array out of bounds error? I don't do a lot of string manipulation but I'm pretty sure you're not declaring your array properly with this.

Code:

---

String [] splitupText = line.split(":");                       
line = line.trim();

---

If I'm correct, that would be why you're getting an index out of bounds error.

Quote:

---

Originally Posted by Dark

Have you corrected your array out of bounds error? I don't do a lot of string manipulation but I'm pretty sure you're not declaring your array properly with this.

Code:

---

String [] splitupText = line.split(":");                       
line = line.trim();

---

If I'm correct, that would be why you're getting an index out of bounds error.

---

How am I suppose to correct in? I'm really new to this and don't fully understand.

I'm sorry, I was mistaken. I took a look at the API and it does indeed intialize an array.

I suggest that you print the length of your array to the console before writing splitupText, as sunde suggested. Somewhere your array length is not equaling your indexing.

Array (Java 2 Platform SE v1.4.2))

Code:

---

splitupText[0]=splitupText[0].trim();
splitupText[0]=splitupText[0].trim();

---

I switched them to 0 instead of 1 but it doesn't display any data, just tells me 0 goals, I'm really lost at trying to understand any of this :(