setLabel(""); problem / Clear board

[Big Bundy]

I am having troubles with my MenuItem clear. When I do hit clear nothing happens, yet everything is compiling fine. The part of code I need looked at is this:

Trying to set the board to clear everything. Which is using setLabel(""); Am I doing something wrong, which is why it will not work?

clearAction.addActionListener(new ActionListener(){
	public void actionPerformed(ActionEvent g){
		String arg= g.getActionCommand();{
		if (arg.equals("Clear")){
		for (int i = 0, count = 0; i < 3; i++) {
		button[i] = new TicTacToeButton[3];
		for (int j = 0; j < 3; j++, count++) {
		button[i][j].setLabel("");

}
}
}
}
}
});

Full Code

import java.awt.*;
import java.awt.event.*;
import java.awt.font.*;
import javax.swing.*;
//import java.text.*;

public class tictactoe extends Frame{

//Color red = new Color(153,255,255);;
Font font = new Font("Dialog", Font.BOLD, 18);
Font font2 = new Font("Dialog", Font.ITALIC, 20);
String turn = "O"; //value is either "O" or "X"
Panel board;
TicTacToeButton button[][];
Label playerTurn;
ButtonHandler bH = new ButtonHandler();
int usedCells = 0; //number of cells in use



tictactoe(String title) {
super(title);
board = new Panel();
button = new TicTacToeButton[3][];
playerTurn = new Label("Player 1's Turn");
playerTurn.setFont(font2);
playerTurn.setForeground(Color.white);
}

void launchGame() {
setBackground(Color.red);
board.setLayout(new GridLayout(3, 3, 6, 6));


//setMenuBar//
MenuBar menuBar = new MenuBar();
setMenuBar(menuBar);

Menu fileMenu = new Menu("File");
menuBar.add(fileMenu);

MenuItem clearAction = new MenuItem("Clear");
MenuItem aboutAction = new MenuItem("About");
MenuItem exitAction = new MenuItem("Exit");

fileMenu.add(clearAction);
fileMenu.add(aboutAction);
fileMenu.add(exitAction);



exitAction.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
   {
String arg = e.getActionCommand();{
if (arg.equals("Exit")){
System.exit(0);
}
}
}
});

aboutAction.addActionListener(new ActionListener(){
	public void actionPerformed(ActionEvent f){
	String arg= f.getActionCommand();{
	if (arg.equals("About")){
String message = " Shawn's TicTacToe \n Structured Programming Java";
JOptionPane.showMessageDialog(null,message,
"About Tic Tac Toe", JOptionPane.INFORMATION_MESSAGE);
}
}
}
});

clearAction.addActionListener(new ActionListener(){
	public void actionPerformed(ActionEvent g){
		String arg= g.getActionCommand();{
		if (arg.equals("Clear")){
		for (int i = 0, count = 0; i < 3; i++) {
		button[i] = new TicTacToeButton[3];
		for (int j = 0; j < 3; j++, count++) {
		button[i][j].setLabel("");

}
}
}
}
}
});


//clearAction.setActionCommand("Clear");
//aboutAction.setActionCommand("About");
//exitAction.setActionCommand("Exit");


/* initialize buttons */
for (int i = 0, count = 0; i < 3; i++) {
button[i] = new TicTacToeButton[3];
for (int j = 0; j < 3; j++, count++) {
button[i][j] = new TicTacToeButton();

/* inialize button values to 0,1, 2,...,8 */
button[i][j].value = (new Integer(count)).toString();
board.add(button[i][j]);

/* add listeners to the buttons */
button[i][j].addActionListener(bH);
button[i][j].setFont(font);
button[i][j].setForeground(Color.green);
button[i][j].setBackground(Color.black);

	}
}

add(board);
board.setSize(300,300);
add(playerTurn, BorderLayout.SOUTH);


/* add listeners for closing the frame */
addWindowListener( new WindowAdapter() {
public void windowClosing( WindowEvent event ) {
System.exit( 0 );
	}
} );

/* display */
pack();
setVisible(true);
}

class ButtonHandler implements ActionListener {
void changeButtonLabel(TicTacToeButton b) {
b.setLabel(turn);
b.value = turn;

/* remove listener */
b.removeActionListener(bH);
usedCells++;

}



public void actionPerformed(ActionEvent ae) {

boolean win = false;
boolean draw = false;
int player = 0;
TicTacToeButton b = (TicTacToeButton) ae.getSource();


/* change content of button to O or X */
changeButtonLabel(b);

/* check for a win */
/* horizontal */
for (int i = 0; i < 3; i++) {
if ((button[i][0].value).equals(button[i][1].value) &&
(button[i][0].value).equals(button[i][2].value)) {
win = true;
	}
}

/* vertical */
for (int i = 0; i < 3; i++) {
if ((button[0][i].value).equals(button[1][i].value) &&
(button[0][i].value).equals(button[2][i].value)) {
win = true;
	}
}

/* diagonal */
if ((button[0][0].value).equals(button[1][1].value) &&
(button[0][0].value).equals(button[2][2].value)) {
win = true;
} else if ((button[0][2].value).equals(button[1][1].value) &&
(button[0][2].value).equals(button[2][0].value)) {
win = true;
}

/* check for a draw */
if (!win) {
if (usedCells==9) {
draw = true;
	}
}

/* Change message */
String message = "";

//continued on next page
if (win) {
if (turn.equals("O")) {
player = 1;
} else {
player = 2;
}
message += "Player " + player + " wins!";

/* remove all listeners */
for (int i = 0; i < 3; i++) {
for (int j = 0; j < 3; j++) {
button[i][j].removeActionListener(bH);
	}
}
} else if (draw) {
message += "It's a draw!";
for (int i = 0; i < 3; i++) {
for (int j = 0; j < 3; j++) {
button[i][j].removeActionListener(bH);
	}
}
} else {

/* change turn */
if (turn.equals("O")){
//setBackground(Color.red);
turn = new String("X");
player = 2;
message += "Player 2's Turn";
} else {
turn = new String("O");
player = 1;
message += "Player 1's Turn";
	}
}
playerTurn.setText(message);
	}
}

class TicTacToeButton extends Button {
String value;
}



public static void main(String args[]) {
tictactoe game = new tictactoe("Tic-Tac-Toe");
game.launchGame();
	}
}

[Fubarable]

Is all your code really left-justified? I don't know about others, but I find this code very difficult if not impossible to read and interpret.

[Big Bundy]

Yea, I'm very sorry for this. What can I do to fix?

[Maximus-EVG]

Modify your class as follows:

public class tictactoe extends Frame{

//Color red = new Color(153,255,255);;
Font font = new Font("Dialog", Font.BOLD, 18);
Font font2 = new Font("Dialog", Font.ITALIC, 20);
String turn = "O"; //value is either "O" or "X"
Panel board;
TicTacToeButton button[][];
Label playerTurn;
ButtonHandler bH = new ButtonHandler();
int usedCells = 0; //number of cells in use
public static ArrayList<TicTacToeButton> allButtons = new ArrayList<TicTacToeButton>();


....

clearAction.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent g){
String arg= g.getActionCommand();{
if (arg.equals("Clear")){
// for (int i = 0, count = 0; i < 3; i++) {
// button[i] = new TicTacToeButton[3];
// for (int j = 0; j < 3; j++, count++) {
// button[i][j].setLabel("");
// //repaint();
//
//
//}
//}
for (TicTacToeButton current : allButtons){
current.setLabel(" ");
}
}




/* initialize buttons */
for (int i = 0, count = 0; i < 3; i++) {
button[i] = new TicTacToeButton[3];
for (int j = 0; j < 3; j++, count++) {
button[i][j] = new TicTacToeButton();
allButtons.add(button[i][j]);

/* inialize button values to 0,1, 2,...,8 */
button[i][j].value = (new Integer(count)).toString();
board.add(button[i][j]);

/* add listeners to the buttons */
button[i][j].addActionListener(bH);
button[i][j].setFont(font);
button[i][j].setForeground(Color.green);
button[i][j].setBackground(Color.black);
}
}
});


.....
It clears now, but Id still test it if my hack broke something else instead.

[ra4king]

Ummm code tags Maximus??

[Big Bundy]

2 Errors:

C:\Users\Shawn\Documents\tictactoe.java:18: cannot find symbol
symbol  : class ArrayList
location: class tictactoe
public static ArrayList<TicTacToeButton> allButtons= new ArrayList<TicTacToeButton>();
              ^
C:\Users\Shawn\Documents\tictactoe.java:18: cannot find symbol
symbol  : class ArrayList
location: class tictactoe
public static ArrayList<TicTacToeButton> allButtons= new ArrayList<TicTacToeButton>();
                                                         ^
2 errors

Tool completed with exit code 1

[ra4king]

Did you import ArrayList? ;)

[Big Bundy]

What is the syntax for that haha :p

[Big Bundy]

Ok I figured it out. Clear works Wonders! Thanks. Now how am I to again play the game again? It clears but then nothing shows if I were to "play again"

[Big Bundy]

So if the player clicks clear , I need to set all the variables back to the beginning

If this helps something similar to this code but mine is a MenuItem not a Button:
Java Applet Example -Tictactoe

How would I go about doing this using my code? I have a drop down menu not a "button"

[ra4king]

You just do "setText("")".

[Big Bundy]

Ok and where would I add setText(""); and to what?

[ra4king]

You do setText("") on all the menu items that you want to clear...

[Big Bundy]

I have Clear working, and now I want to make it so it starts out like it does in the beginning of the game. After I clear I wanted all to basically reset so when the first player goes an X will show. Nothing shows after I clear.

[Fubarable]

I have Clear working, and now I want to make it so it starts out like it does in the beginning of the game. After I clear I wanted all to basically reset so when the first player goes an X will show. Nothing shows after I clear.

Then you've done something wrong....

[Big Bundy]

Do you understand what I'm saying? This link shows what I want to do but when I hit clear it clears FINE but when I want to play again and click a button nothing shows. What do I have to do? (His "reset" button is the same as my "clear" menuItem same purpose)
Java Applet Example -Tictactoe

import java.awt.*;
import java.awt.event.*;
import java.awt.font.*;
import javax.swing.*;
import java.util.ArrayList;
//import java.text.*;

public class tictactoe extends Frame{


Font font = new Font("Dialog", Font.BOLD, 18);
Font font2 = new Font("Dialog", Font.ITALIC, 20);
String turn = "O"; //value is either "O" or "X"
Panel board;
TicTacToeButton button[][];
Label playerTurn;
ButtonHandler bH = new ButtonHandler();
int usedCells = 0; //number of cells in use
public static ArrayList<TicTacToeButton> allButtons= new ArrayList<TicTacToeButton>();



tictactoe(String title) {
super(title);
board = new Panel();
button = new TicTacToeButton[3][];
playerTurn = new Label("Player 1's Turn");
playerTurn.setFont(font2);
playerTurn.setForeground(Color.white);
}

void launchGame() {
setBackground(Color.red);
board.setLayout(new GridLayout(3, 3, 6, 6));


//setMenuBar//
MenuBar menuBar = new MenuBar();
setMenuBar(menuBar);

Menu fileMenu = new Menu("File");
menuBar.add(fileMenu);

MenuItem clearAction = new MenuItem("Clear");
MenuItem aboutAction = new MenuItem("About");
MenuItem exitAction = new MenuItem("Exit");

fileMenu.add(clearAction);
fileMenu.add(aboutAction);
fileMenu.add(exitAction);



	exitAction.addActionListener(new ActionListener(){
	public void actionPerformed(ActionEvent e){
	String arg = e.getActionCommand();{
	if (arg.equals("Exit")){
	System.exit(0);
			}
 		}
	}
});

	aboutAction.addActionListener(new ActionListener(){
	public void actionPerformed(ActionEvent f){
	String arg= f.getActionCommand();{
	if (arg.equals("About")){
	String message = " Shawn's TicTacToe \n Structured Programming Java";
	JOptionPane.showMessageDialog(null,message,
	"About Tic Tac Toe", JOptionPane.INFORMATION_MESSAGE);
			}
		}
	}
});

	clearAction.addActionListener(new ActionListener(){
	public void actionPerformed(ActionEvent g){
	String arg= g.getActionCommand();{
	if (arg.equals("Clear")){
	for (TicTacToeButton current : allButtons){
	current.setLabel(" ");
				}
			}
		}
	}
});


////////////////////////////////////////////////
/* initialize buttons */
for (int i = 0, count = 0; i < 3; i++) {
button[i] = new TicTacToeButton[3];
for (int j = 0; j < 3; j++, count++) {
button[i][j] = new TicTacToeButton();
allButtons.add(button[i][j]);

///////////////////////////////////////////////
/* inialize button values to 0,1, 2,...,8 */
button[i][j].value = (new Integer(count)).toString();
board.add(button[i][j]);

///////////////////////////////////////////////
/* add listeners to the buttons */
button[i][j].addActionListener(bH);
button[i][j].setFont(font);
button[i][j].setForeground(Color.green);
button[i][j].setBackground(Color.black);

	}
}

add(board);
board.setSize(300,300);
add(playerTurn, BorderLayout.SOUTH);

/////////////////////////////////
/* add listeners for closing the frame */
addWindowListener( new WindowAdapter() {
public void windowClosing( WindowEvent event ) {
System.exit( 0 );
	}
});
/////////////////////////////////
/* display */
pack();
setVisible(true);
}

class ButtonHandler implements ActionListener {
void changeButtonLabel(TicTacToeButton b) {
b.setLabel(turn);
b.value = turn;
//////////////////////////////////
/* remove listener */
b.removeActionListener(bH);
usedCells++;

}



public void actionPerformed(ActionEvent ae) {

boolean win = false;
boolean draw = false;
int player = 0;
TicTacToeButton b = (TicTacToeButton) ae.getSource();

///////////////////////////////////
/* change content of button to O or X */
changeButtonLabel(b);
///////////////////////////////////
/* check for a win */
/* horizontal */
for (int i = 0; i < 3; i++) {
if ((button[i][0].value).equals(button[i][1].value) &&
(button[i][0].value).equals(button[i][2].value)) {
win = true;
	}
}
///////////////////////////////////
/* vertical */
for (int i = 0; i < 3; i++) {
if ((button[0][i].value).equals(button[1][i].value) &&
(button[0][i].value).equals(button[2][i].value)) {
win = true;
	}
}
///////////////////////////////////
/* diagonal */
if ((button[0][0].value).equals(button[1][1].value) &&
(button[0][0].value).equals(button[2][2].value)) {
win = true;
} else if ((button[0][2].value).equals(button[1][1].value) &&
(button[0][2].value).equals(button[2][0].value)) {
win = true;
}
/////////////////////////////////
/* check for a draw */
if (!win) {
if (usedCells==9) {
draw = true;
	}
}
//////////////////////////////////
/* Change message */
String message = "";
//////////////////////////////////
//continued on next page
if (win) {
if (turn.equals("O")) {
player = 1;
} else {
player = 2;
}
message += "Player " + player + " wins!";
///////////////////////////////////
/* remove all listeners */
for (int i = 0; i < 3; i++) {
for (int j = 0; j < 3; j++) {
button[i][j].removeActionListener(bH);
	}
}
} else if (draw) {
message += "It's a draw!";
for (int i = 0; i < 3; i++) {
for (int j = 0; j < 3; j++) {
button[i][j].removeActionListener(bH);
	}
}
} else {
//////////////////////////////////////
/* change turn */
if (turn.equals("O")){
turn = new String("X");
player = 2;
message += "Player 2's Turn";
} else {
turn = new String("O");
player = 1;
message += "Player 1's Turn";
	}
}
playerTurn.setText(message);
	}
}

class TicTacToeButton extends Button {
String value;
}



public static void main(String args[]) {
tictactoe game = new tictactoe("Tic-Tac-Toe");
game.launchGame();
	}
}

[ra4king]

Maybe set win to false? Try setting every variable back to its default setting when you clear.

[sunde887]

Your code is very difficult to read. You should consider indenting code, it will greatly help you, and others read your code.


Polk high!

[Big Bundy]

Could you lead me into some syntax help?

Maybe set win to false? Try setting every variable back to its default setting when you clear.

[Fubarable]

Could you lead me into some syntax help?

Why not try it first and then show us your problems? And I second the other recommendation, that you fix your code formatting. You'll find that if more can read and understand your code, more will be able and willing to help you.