Comparing 2 CSV files

[gcclinux]

Hi,

I am trying to compare two CSV files and write the difference to a 3rd file but I am having issues and I am not sure why can someone please help me.

public class CompareLog {
  public static String[] readCSVFile(String fileName) throws FileNotFoundException, IOException {
	BufferedReader me = null;
      FileReader readerFile = new FileReader(fileName);
	me = new BufferedReader(readerFile);
	String line;
	String out[] = null;
	while((line = me.readLine()) != null)
	  {
	     out = line.toString().split(",");
          }
	     return out;
  }
  public static void writeToFile(Set<String[]> records, String fileName) throws IOException {
    // your code here
	     File outputFile=new File("C:/temp/compare_3.log");
	     FileWriter out = new FileWriter(outputFile);
	     out.write(records+"\n");
	     out.close();
  }

  public static void main(String[] args) throws FileNotFoundException, IOException {
    // Read both files
	String[] recordsA = readCSVFile("C:/temp/compare_1.log");
        String[] recordsB = readCSVFile("C:/temp/compare_2.log");

        // Create a set to store all unique records in
        Set<String[]> uniqueRecords = new HashSet<String[]>();
        uniqueRecords.addAll(recordsA);
        uniqueRecords.addAll(recordsB);

        // write the 'uniqueRecorsd' to file
        writeToFile(uniqueRecords, "outputFile");
  }
}

I am having the following error by
uniqueRecords.addAll(recordsA);
uniqueRecords.addAll(recordsB);

cannot find symbol
  symbol:   method addAll(java.lang.String[])
  location: interface java.util.Set<java.lang.String[]>

Any help would be greatly appreciated.

[eRaaaa]

addAll wants a Collection --> Set (Java Platform SE 6) not an String array :)

Set<String[]> ?? --> then you have to use only add(...)
But if you really want Set<String> you can write addAll(Arrays.asList(recordsA))

[gcclinux]

Hi eRaaaa, thank you for your advise, unfortunately that still did not work, so made loads of changes and it now shifted to the return statment.

public class CompareLogl1 {
  public static Set<String[]> readCSVFile(String fileName) throws FileNotFoundException, IOException {
	BufferedReader me = null;
        FileReader readerFile = new FileReader(fileName);
	me = new BufferedReader(readerFile);
	String line;
	String out[] = null;
	while((line = me.readLine()) != null)
	  {
	     out = line.toString().split(line);
          }
	     [COLOR="Red"]return out;[/COLOR]
  }
  public static void writeToFile(Set<String[]> records, String fileName) throws IOException {
    // your code here
	     File outputFile=new File("C:/temp/compare_3.log");
	     FileWriter out = new FileWriter(outputFile);
	     out.write(records+"\n");
	     out.close();
  }

  public static void main(String[] args) throws FileNotFoundException, IOException {
    // Read both files
	Set<String[]> recordsA = readCSVFile("C:/temp/compare_1.log");
        Set<String[]> recordsB = readCSVFile("C:/temp/compare_2.log");

        // Create a set to store all unique records in
        Set<String[]> uniqueRecords = new HashSet<String[]>();
        uniqueRecords.addAll(recordsA);
        uniqueRecords.addAll(recordsB);

        // write the 'uniqueRecorsd' to file
        writeToFile(uniqueRecords, "outputFile");
  }
}

Same error and I already tried assigning Set<String[]> to line & out but then I shift the error to out = line.toString().split(line);

So whatever I do the error seems to shift from one place to another.

Any further help would be great.

Many Thanks

[Tolls]

  public static [B]Set<String[]>[/B] readCSVFile(String fileName) throws FileNotFoundException, IOException {
	BufferedReader me = null;
        FileReader readerFile = new FileReader(fileName);
	me = new BufferedReader(readerFile);
	String line;
	[B]String out[] = null;[/B]
	while((line = me.readLine()) != null)
	  {
	     out = line.toString().split(line);
          }
         return out;
  }

You're returning a String[], but your method says it should be returning a Set<String>.
You can't do that.

If you need a Set<String> back then you have to create one in the method and populate it.

Also, you are setting you String[] to the split(), each time round the loop. So you're only ever returning the last split() line. Which I'm sure isn't correct?

[Tolls]

Spam reported

[Fubarable]

Spam reported

squashed .

[gcclinux]

Hello I have been trying to change the whole class and although I almost got it the way I want something is not quite right.

What I tying to do:

1 - read through file1, split "," and get field 3.
2 - read through file2 line by line and see if (file1.field3 contains in any line in file2)

then if true, print out the line that contains in file2 but not in file1

This is my bit of code.

        for (String line = recordsA.readLine();line != null;line = recordsA.readLine()){
        String[] fields = line.split(",");
        String fieldsA = (fields[2]);

            for (String line2 = recordsB.readLine();line2 != null;line2 = recordsB.readLine()){
                String fieldsB = (line2);


                if ((fieldsB).contains(fieldsA)){
                System.out.println((fieldsB));}
            }
        }

For some reason it goes through and only print out the first line in File1 that does existe in both logs.

Please can someone tell me ehat I am doing wrong.

Many Thanks