Creating a card class for a Deck of cards

[adjit]

So I have my code below, and for getSuit() I keep getting an error saying that the return value is outside the method, which I don't get. Also my display() method is completely wrong... I just don't know how to go about fixing it.

Also, the methods just have to return either the values of what was input into public Card()

public class Card
{
private String suit;
int value;
private Picture face;
public Card(Picture f, String s, int v)
{
suit = s;
value = v;
face = f;
}
public int getValue()
{
return value;
}
public String getSuit();
{
return suit;
}
public Picture display();
{
face.show();
}

[jonstewart]

hah, this looks too familiar..im gonna assume you're taking the csi201 class at ualbany? xD since i'm also struggling with this assignment, i think your display() method is fine, because that's what i have as well...

[adjit]

hahaha yes I am, but my display method keeps giving me an error of missing method body, or declare abstract

[Iron Lion]

Is it a requirement of the assignment that you use String for suit and int for rank? If not, consider using enums.

Your display() method is failing because its return type is Picture, but there's no return statement in the method.

[jonstewart]

Is it a requirement of the assignment that you use String for suit and int for rank? If not, consider using enums.

Your display() method is failing because its return type is Picture, but there's no return statement in the method.

Yeah the assignment says "This class will have 3 fields:
• A String variable called suit
• An integer called value
• A Picture variable called face"

[adjit]

Our class has not yet discussed enums, so I am assuming we cannot use them.
Our class's need to have 3 fields:
• A String variable called suit
• An integer called value
• A Picture variable called face

so for my picture class would it be

public void display()
{
this.show() // it is calling a method from a different class called show() but idk if this is right because I still got the error
}

[Iron Lion]

It would help if you post the code for your Picture class.

[adjit]

the show() method is public.
display()
This method will take no parameters and will return nothing. It will utilize the show() method in
the Picture class to display the card’s face image to the user.

[Iron Lion]

this.show() doesn't work because your Card class doesn't have a show() method. Instead, call face.show().

[adjit]

so I have that part down, I just need the getSuit() method. That is where I am getting the majority of my problems.

[Iron Lion]

public String getSuit();
{
return suit;
}

Get rid of the semicolon after the method declaration.

[adjit]

god I'm a retard... thanks so much!!

[Iron Lion]

Easy mistake to make. It's less likely to catch you out if you put your opening brace on the same line as the declaration, like so:

public String getSuit() {
...
}

Of course, if your tutor insists on you placing your braces the other way, there's not much you can do about it.

[adjit]

yeah, I just feel like it makes it look more crowded and stuff, so its just personal preferences. Would you mind if I added you in case I get any more easy problems?